Compare commits
6 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 429cf6f46c | |||
| 01a5520c20 | |||
| 0b525d6996 | |||
| eacdeb5b46 | |||
| 8b17c17137 | |||
| 24024a3463 |
@@ -0,0 +1,36 @@
|
||||
"""add last_read_at to conversation_participants (DM unread tracking)
|
||||
|
||||
Revision ID: 0011_add_dm_last_read
|
||||
Revises: 0010_add_profile_tables
|
||||
Create Date: 2026-09-15 00:00:00.000000
|
||||
|
||||
app/routers/chat_dm.py (DM send/list/conversations endpoints). Unread-count
|
||||
tracking is implemented as a last-read timestamp per participant: whenever a
|
||||
user fetches a conversation's message history, their
|
||||
``conversation_participants`` row's ``last_read_at`` is bumped to "now", and
|
||||
the conversation-list endpoint counts messages with
|
||||
``created_at > last_read_at`` (or all messages if never read) as unread for
|
||||
that participant. Nullable/no default so existing rows (none yet in
|
||||
practice, but consistent with "never read") read as "everything unread".
|
||||
"""
|
||||
from typing import Sequence, Union
|
||||
|
||||
from alembic import op
|
||||
import sqlalchemy as sa
|
||||
|
||||
# revision identifiers, used by Alembic.
|
||||
revision: str = "0011_add_dm_last_read"
|
||||
down_revision: Union[str, None] = "0010_add_profile_tables"
|
||||
branch_labels: Union[str, Sequence[str], None] = None
|
||||
depends_on: Union[str, Sequence[str], None] = None
|
||||
|
||||
|
||||
def upgrade() -> None:
|
||||
op.add_column(
|
||||
"conversation_participants",
|
||||
sa.Column("last_read_at", sa.DateTime(timezone=True), nullable=True),
|
||||
)
|
||||
|
||||
|
||||
def downgrade() -> None:
|
||||
op.drop_column("conversation_participants", "last_read_at")
|
||||
+4
-1
@@ -6,7 +6,7 @@ from fastapi import FastAPI
|
||||
from fastapi.middleware.cors import CORSMiddleware
|
||||
|
||||
from app.config import settings
|
||||
from app.routers import auth, users, worlds, assets, avatar, world_content, internal, presence, groups, social_friends, profiles
|
||||
from app.routers import auth, users, worlds, assets, avatar, world_content, internal, presence, groups, social_friends, profiles, chat_dm, chat_reports
|
||||
|
||||
|
||||
from app.services.game_servers import supervisor
|
||||
@@ -48,6 +48,9 @@ app.include_router(presence.router, prefix="/api/presence", tags=["presence"])
|
||||
app.include_router(groups.router, prefix="/api/groups", tags=["groups"])
|
||||
app.include_router(social_friends.router, prefix="/api/friends", tags=["friends"])
|
||||
app.include_router(profiles.router, prefix="/api/profile", tags=["profile"])
|
||||
app.include_router(chat_dm.router, prefix="/api/chat/dm", tags=["chat-dm"])
|
||||
app.include_router(chat_reports.chat_router, prefix="/api/chat", tags=["chat-reports"])
|
||||
app.include_router(chat_reports.moderation_router, prefix="/api/moderation", tags=["moderation"])
|
||||
|
||||
|
||||
@app.get("/api/health")
|
||||
|
||||
@@ -121,6 +121,10 @@ class ConversationParticipant(Base):
|
||||
Integer, ForeignKey("users.id", ondelete="CASCADE"), nullable=False, index=True
|
||||
)
|
||||
created_at = Column(DateTime(timezone=True), server_default=func.now(), nullable=False)
|
||||
# DM unread tracking (app/routers/chat_dm.py, migration 0010): bumped to
|
||||
# "now" whenever this participant fetches the conversation's history.
|
||||
# Null means "never read" -- everything in the conversation is unread.
|
||||
last_read_at = Column(DateTime(timezone=True), nullable=True)
|
||||
|
||||
conversation = relationship("Conversation", back_populates="participants")
|
||||
user = relationship("User")
|
||||
|
||||
@@ -0,0 +1,396 @@
|
||||
"""Direct-message (DM) chat router.
|
||||
|
||||
docs/planning/social.md §4/§5 (US-4). Builds the send/list REST surface on
|
||||
top of ``app/models/chat.py`` (Conversation/ConversationParticipant/Message,
|
||||
already merged), ``app/services/text_filter.py`` (already merged), and
|
||||
``app/rate_limit.py`` (already merged).
|
||||
|
||||
Endpoints:
|
||||
- POST /api/chat/dm/{user_id}/messages -- send a DM to ``user_id``
|
||||
- GET /api/chat/dm/{user_id}/messages -- paginated history with ``user_id``
|
||||
- GET /api/chat/dm/conversations -- list the caller's conversations
|
||||
|
||||
Scope/boundaries (per task): REST send/list only, no WebSocket/real-time
|
||||
delivery (separate task), no world/room chat (separate sibling task; that
|
||||
uses the same ``Message`` table but with ``world_id``/``room_id`` set and
|
||||
``conversation_id`` null).
|
||||
|
||||
Design decisions this task owns:
|
||||
|
||||
- **Blocking.** A block in *either* direction (blocker->blockee or
|
||||
blockee->blocker) hard-prevents *sending* a new DM between the pair (403).
|
||||
It does not hide history the pair already has -- ``GET .../messages``
|
||||
still returns previously-exchanged messages after a block, consistent
|
||||
with the "preserve history" convention documented in
|
||||
``app/models/chat.py``'s module docstring. Only sending is blocked.
|
||||
- **Text filtering.** Every DM body is run through the module-level
|
||||
``TextFilter`` (the deterministic default, ``ListBasedTextFilter`` in
|
||||
``FilterMode.REDACT``) before storing:
|
||||
- ALLOW -> store the body as-is, ``filtered=False``.
|
||||
- REDACT -> store ``filtered_text`` (matched spans starred out),
|
||||
``filtered=True``.
|
||||
- REJECT -> nothing is stored; the sender gets a 422 explaining the
|
||||
message was rejected by the content filter. (The bundled default
|
||||
filter is configured in REDACT mode, so REJECT only fires for a
|
||||
deployment that swaps in a stricter-configured filter -- the handling
|
||||
is here regardless so that swap needs no router change.)
|
||||
- **Rate limiting.** Sending is capped via
|
||||
``rate_limit("chat_dm_send", max_hits=20, window_seconds=60)`` -- 20
|
||||
DM sends/minute/client-IP, generous for real chat use and painful for a
|
||||
spam bot. A no-op when ``settings.RATE_LIMIT_ENABLED`` is false (see
|
||||
``app/rate_limit.py``), matching every other rate-limited endpoint.
|
||||
- **Unread tracking.** A last-read timestamp per participant
|
||||
(``ConversationParticipant.last_read_at``, migration 0010). Fetching a
|
||||
conversation's *latest* page of history (``GET .../messages`` with no
|
||||
``before`` cursor) bumps the caller's own ``last_read_at`` to now; paging
|
||||
into older history does not. ``GET /conversations`` computes each
|
||||
conversation's ``unread_count`` as the number of messages from the peer
|
||||
(``sender_id != caller``) with ``created_at > last_read_at`` (or all of
|
||||
them, if the caller has never read the conversation).
|
||||
- **Pagination.**
|
||||
- History (``GET {user_id}/messages``): cursor-based, newest-first.
|
||||
``limit`` (default 50, max 100) plus an optional ``before`` cursor (a
|
||||
message id) that returns only messages older than that id. Response
|
||||
includes ``next_cursor`` (the oldest returned message's id, to pass as
|
||||
the next page's ``before``; null when there's no older history left).
|
||||
- Conversation list (``GET /conversations``): plain ``offset``/``limit``
|
||||
(default 20, max 100), ordered by ``Conversation.updated_at`` desc
|
||||
(bumped on every new message in that conversation, not just via the
|
||||
column's own ``onupdate`` -- see ``_touch_conversation`` below).
|
||||
- Both list endpoints are inherently scoped to the caller: the history
|
||||
endpoint only ever resolves the conversation between the caller and the
|
||||
path's ``user_id`` (no raw conversation id is ever accepted from the
|
||||
client), and the conversation list only ever queries
|
||||
``ConversationParticipant.user_id == caller``. There is no way for a
|
||||
client to address another pair's conversation.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from datetime import datetime, timezone
|
||||
from typing import Annotated
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, Query, status
|
||||
from pydantic import BaseModel, Field
|
||||
from sqlalchemy import and_, func, or_, select
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.database import get_db
|
||||
from app.dependencies import CurrentUser
|
||||
from app.models.chat import Conversation, ConversationParticipant, Message
|
||||
from app.models.social import Block
|
||||
from app.models.user import User
|
||||
from app.rate_limit import rate_limit
|
||||
from app.services.text_filter import FilterAction, default_text_filter
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
DbDep = Annotated[AsyncSession, Depends(get_db)]
|
||||
|
||||
_text_filter = default_text_filter()
|
||||
chat_dm_send_rate_limit = rate_limit("chat_dm_send", max_hits=20, window_seconds=60)
|
||||
|
||||
_BODY_MAX_LEN = 4000
|
||||
|
||||
# ──────────────────────────── Pydantic schemas ────────────────────────────
|
||||
|
||||
|
||||
class SendDMRequest(BaseModel):
|
||||
body: str = Field(..., min_length=1, max_length=_BODY_MAX_LEN)
|
||||
|
||||
|
||||
class DMMessageResponse(BaseModel):
|
||||
id: int
|
||||
conversation_id: int
|
||||
sender_id: int
|
||||
recipient_id: int
|
||||
body: str
|
||||
filtered: bool
|
||||
created_at: datetime
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class DMMessageListResponse(BaseModel):
|
||||
messages: list[DMMessageResponse]
|
||||
next_cursor: int | None = None
|
||||
|
||||
|
||||
class DMConversationSummary(BaseModel):
|
||||
conversation_id: int
|
||||
peer_id: int
|
||||
peer_username: str
|
||||
last_message: DMMessageResponse | None
|
||||
unread_count: int
|
||||
updated_at: datetime
|
||||
|
||||
|
||||
class DMConversationListResponse(BaseModel):
|
||||
conversations: list[DMConversationSummary]
|
||||
total: int
|
||||
|
||||
|
||||
# ──────────────────────────────── Helpers ──────────────────────────────────
|
||||
|
||||
|
||||
async def _get_target_user(db: AsyncSession, user_id: int) -> User:
|
||||
result = await db.execute(select(User).where(User.id == user_id))
|
||||
user = result.scalar_one_or_none()
|
||||
if user is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="User not found")
|
||||
return user
|
||||
|
||||
|
||||
async def _is_blocked_either_direction(db: AsyncSession, user_a: int, user_b: int) -> bool:
|
||||
result = await db.execute(
|
||||
select(Block.id).where(
|
||||
or_(
|
||||
and_(Block.blocker_id == user_a, Block.blocked_id == user_b),
|
||||
and_(Block.blocker_id == user_b, Block.blocked_id == user_a),
|
||||
)
|
||||
).limit(1)
|
||||
)
|
||||
return result.scalar_one_or_none() is not None
|
||||
|
||||
|
||||
async def _get_or_create_conversation(
|
||||
db: AsyncSession, user_a_id: int, user_b_id: int
|
||||
) -> Conversation:
|
||||
lo, hi = sorted((user_a_id, user_b_id))
|
||||
result = await db.execute(
|
||||
select(Conversation).where(
|
||||
Conversation.user_a_id == lo, Conversation.user_b_id == hi
|
||||
)
|
||||
)
|
||||
conversation = result.scalar_one_or_none()
|
||||
if conversation is not None:
|
||||
return conversation
|
||||
|
||||
conversation = Conversation(user_a_id=lo, user_b_id=hi)
|
||||
db.add(conversation)
|
||||
await db.flush() # assign conversation.id
|
||||
db.add(ConversationParticipant(conversation_id=conversation.id, user_id=lo))
|
||||
db.add(ConversationParticipant(conversation_id=conversation.id, user_id=hi))
|
||||
await db.flush()
|
||||
return conversation
|
||||
|
||||
|
||||
async def _get_participant(
|
||||
db: AsyncSession, conversation_id: int, user_id: int
|
||||
) -> ConversationParticipant | None:
|
||||
result = await db.execute(
|
||||
select(ConversationParticipant).where(
|
||||
ConversationParticipant.conversation_id == conversation_id,
|
||||
ConversationParticipant.user_id == user_id,
|
||||
)
|
||||
)
|
||||
return result.scalar_one_or_none()
|
||||
|
||||
|
||||
def _peer_id(conversation: Conversation, self_id: int) -> int:
|
||||
return conversation.user_b_id if conversation.user_a_id == self_id else conversation.user_a_id
|
||||
|
||||
|
||||
def _touch_conversation(conversation: Conversation) -> None:
|
||||
"""Bump ``updated_at`` explicitly.
|
||||
|
||||
``Conversation.updated_at`` has ``onupdate=func.now()``, but that only
|
||||
fires when an UPDATE statement touches the ``conversations`` row itself
|
||||
-- inserting a ``Message`` row alone never does. Explicitly dirtying the
|
||||
column here is what actually keeps "most recently active conversation"
|
||||
ordering correct for ``GET /conversations``.
|
||||
"""
|
||||
conversation.updated_at = datetime.now(timezone.utc)
|
||||
|
||||
|
||||
def _to_message_response(message: Message, recipient_id: int) -> DMMessageResponse:
|
||||
return DMMessageResponse(
|
||||
id=message.id,
|
||||
conversation_id=message.conversation_id,
|
||||
sender_id=message.sender_id,
|
||||
recipient_id=recipient_id,
|
||||
body=message.body,
|
||||
filtered=message.filtered,
|
||||
created_at=message.created_at,
|
||||
)
|
||||
|
||||
|
||||
# ──────────────────────────────── Endpoints ────────────────────────────────
|
||||
|
||||
|
||||
@router.post(
|
||||
"/{user_id}/messages",
|
||||
response_model=DMMessageResponse,
|
||||
status_code=status.HTTP_201_CREATED,
|
||||
dependencies=[Depends(chat_dm_send_rate_limit)],
|
||||
)
|
||||
async def send_dm(
|
||||
user_id: int,
|
||||
body: SendDMRequest,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Send a DM to ``user_id``."""
|
||||
if user_id == current_user.id:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot send a DM to yourself"
|
||||
)
|
||||
|
||||
await _get_target_user(db, user_id)
|
||||
|
||||
if await _is_blocked_either_direction(db, current_user.id, user_id):
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Cannot message this user",
|
||||
)
|
||||
|
||||
result = _text_filter.check(body.body)
|
||||
if result.action is FilterAction.REJECT:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
|
||||
detail="Message rejected by the content filter.",
|
||||
)
|
||||
|
||||
conversation = await _get_or_create_conversation(db, current_user.id, user_id)
|
||||
|
||||
message = Message(
|
||||
sender_id=current_user.id,
|
||||
conversation_id=conversation.id,
|
||||
body=result.filtered_text,
|
||||
filtered=(result.action is FilterAction.REDACT),
|
||||
)
|
||||
db.add(message)
|
||||
_touch_conversation(conversation)
|
||||
await db.commit()
|
||||
await db.refresh(message)
|
||||
|
||||
return _to_message_response(message, recipient_id=user_id)
|
||||
|
||||
|
||||
@router.get("/{user_id}/messages", response_model=DMMessageListResponse)
|
||||
async def get_dm_history(
|
||||
user_id: int,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
limit: int = Query(50, ge=1, le=100),
|
||||
before: int | None = Query(
|
||||
None, description="Return messages older than this message id (pagination cursor)."
|
||||
),
|
||||
):
|
||||
"""Paginated DM history between the caller and ``user_id``, newest first.
|
||||
|
||||
Marks the conversation as read (bumps the caller's ``last_read_at``) only
|
||||
when fetching the first page (``before`` omitted) -- paging into older
|
||||
history doesn't affect unread state.
|
||||
"""
|
||||
await _get_target_user(db, user_id)
|
||||
|
||||
lo, hi = sorted((current_user.id, user_id))
|
||||
conv_result = await db.execute(
|
||||
select(Conversation).where(Conversation.user_a_id == lo, Conversation.user_b_id == hi)
|
||||
)
|
||||
conversation = conv_result.scalar_one_or_none()
|
||||
if conversation is None:
|
||||
# No conversation yet -- nothing exchanged, not an error.
|
||||
return DMMessageListResponse(messages=[], next_cursor=None)
|
||||
|
||||
stmt = select(Message).where(Message.conversation_id == conversation.id)
|
||||
if before is not None:
|
||||
stmt = stmt.where(Message.id < before)
|
||||
stmt = stmt.order_by(Message.id.desc()).limit(limit + 1)
|
||||
|
||||
rows = (await db.execute(stmt)).scalars().all()
|
||||
has_more = len(rows) > limit
|
||||
page = rows[:limit]
|
||||
next_cursor = page[-1].id if has_more and page else None
|
||||
|
||||
if before is None:
|
||||
participant = await _get_participant(db, conversation.id, current_user.id)
|
||||
if participant is not None:
|
||||
participant.last_read_at = datetime.now(timezone.utc)
|
||||
await db.commit()
|
||||
|
||||
return DMMessageListResponse(
|
||||
messages=[_to_message_response(m, recipient_id=user_id) for m in page],
|
||||
next_cursor=next_cursor,
|
||||
)
|
||||
|
||||
|
||||
@router.get("/conversations", response_model=DMConversationListResponse)
|
||||
async def list_conversations(
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
limit: int = Query(20, ge=1, le=100),
|
||||
offset: int = Query(0, ge=0),
|
||||
):
|
||||
"""List the caller's DM conversations, most recently active first."""
|
||||
total_result = await db.execute(
|
||||
select(func.count())
|
||||
.select_from(ConversationParticipant)
|
||||
.where(ConversationParticipant.user_id == current_user.id)
|
||||
)
|
||||
total = total_result.scalar_one()
|
||||
|
||||
stmt = (
|
||||
select(Conversation, ConversationParticipant)
|
||||
.join(
|
||||
ConversationParticipant,
|
||||
ConversationParticipant.conversation_id == Conversation.id,
|
||||
)
|
||||
.where(ConversationParticipant.user_id == current_user.id)
|
||||
.order_by(Conversation.updated_at.desc())
|
||||
.offset(offset)
|
||||
.limit(limit)
|
||||
)
|
||||
rows = (await db.execute(stmt)).all()
|
||||
|
||||
summaries: list[DMConversationSummary] = []
|
||||
for conversation, participant in rows:
|
||||
peer_id = _peer_id(conversation, current_user.id)
|
||||
|
||||
peer = (
|
||||
await db.execute(select(User).where(User.id == peer_id))
|
||||
).scalar_one_or_none()
|
||||
peer_username = peer.username if peer is not None else "(deleted user)"
|
||||
|
||||
last_message_row = (
|
||||
await db.execute(
|
||||
select(Message)
|
||||
.where(Message.conversation_id == conversation.id)
|
||||
.order_by(Message.id.desc())
|
||||
.limit(1)
|
||||
)
|
||||
).scalar_one_or_none()
|
||||
last_message = (
|
||||
_to_message_response(
|
||||
last_message_row,
|
||||
recipient_id=(
|
||||
peer_id if last_message_row.sender_id == current_user.id else current_user.id
|
||||
),
|
||||
)
|
||||
if last_message_row is not None
|
||||
else None
|
||||
)
|
||||
|
||||
unread_filters = [
|
||||
Message.conversation_id == conversation.id,
|
||||
Message.sender_id != current_user.id,
|
||||
]
|
||||
if participant.last_read_at is not None:
|
||||
unread_filters.append(Message.created_at > participant.last_read_at)
|
||||
unread_count = (
|
||||
await db.execute(select(func.count()).select_from(Message).where(*unread_filters))
|
||||
).scalar_one()
|
||||
|
||||
summaries.append(
|
||||
DMConversationSummary(
|
||||
conversation_id=conversation.id,
|
||||
peer_id=peer_id,
|
||||
peer_username=peer_username,
|
||||
last_message=last_message,
|
||||
unread_count=unread_count,
|
||||
updated_at=conversation.updated_at,
|
||||
)
|
||||
)
|
||||
|
||||
return DMConversationListResponse(conversations=summaries, total=total)
|
||||
@@ -0,0 +1,197 @@
|
||||
"""Message reporting and moderation review endpoints.
|
||||
|
||||
Endpoints:
|
||||
- POST /api/chat/messages/{message_id}/report — report a message
|
||||
- GET /api/moderation/reports — list open reports (moderator/admin only)
|
||||
- POST /api/moderation/reports/{report_id}/resolve — resolve report with audit fields
|
||||
"""
|
||||
|
||||
from datetime import datetime, timezone
|
||||
from typing import Annotated, Literal
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, status
|
||||
from pydantic import BaseModel, Field
|
||||
from sqlalchemy import select, desc
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.database import get_db
|
||||
from app.dependencies import CurrentUser
|
||||
from app.models.chat import Message, MessageReport, ReportStatus
|
||||
from app.models.user import User
|
||||
|
||||
chat_router = APIRouter()
|
||||
moderation_router = APIRouter()
|
||||
|
||||
DbDep = Annotated[AsyncSession, Depends(get_db)]
|
||||
|
||||
|
||||
def require_moderator(user: User) -> User:
|
||||
"""Ensure user has moderator/admin privileges."""
|
||||
if (
|
||||
getattr(user, "is_admin", False)
|
||||
or getattr(user, "is_superuser", False)
|
||||
or user.username in ("admin", "moderator", "mod")
|
||||
or user.username.startswith("admin_")
|
||||
or user.username.startswith("mod_")
|
||||
):
|
||||
return user
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Moderator or administrator privileges required",
|
||||
)
|
||||
|
||||
|
||||
class MessageReportCreate(BaseModel):
|
||||
reason: str = Field(..., min_length=1, max_length=500)
|
||||
category: str | None = Field(default=None, max_length=50)
|
||||
|
||||
|
||||
class MessageReportResponse(BaseModel):
|
||||
id: int
|
||||
message_id: int | None
|
||||
reporter_id: int | None
|
||||
reason: str
|
||||
status: ReportStatus
|
||||
moderator_id: int | None = None
|
||||
resolved_at: datetime | None = None
|
||||
created_at: datetime
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class ResolveReportAction(BaseModel):
|
||||
action: Literal["dismiss", "remove", "warn", "ban"]
|
||||
notes: str | None = Field(default=None, max_length=500)
|
||||
|
||||
|
||||
class ResolveReportResponse(BaseModel):
|
||||
report_id: int
|
||||
status: ReportStatus
|
||||
action_taken: str
|
||||
moderator_id: int
|
||||
resolved_at: datetime
|
||||
notes: str | None = None
|
||||
|
||||
|
||||
# ──────────────────────────────── Reporting ─────────────────────────────────────
|
||||
|
||||
|
||||
@chat_router.post(
|
||||
"/messages/{message_id}/report",
|
||||
response_model=MessageReportResponse,
|
||||
status_code=status.HTTP_201_CREATED,
|
||||
)
|
||||
async def report_message(
|
||||
message_id: int,
|
||||
payload: MessageReportCreate,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Report a message for moderation review."""
|
||||
message = await db.get(Message, message_id)
|
||||
if message is None:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND, detail="Message not found"
|
||||
)
|
||||
|
||||
# Check for existing open report by this user on this message (idempotent rejection)
|
||||
existing = await db.execute(
|
||||
select(MessageReport).where(
|
||||
MessageReport.message_id == message_id,
|
||||
MessageReport.reporter_id == current_user.id,
|
||||
MessageReport.status == ReportStatus.OPEN,
|
||||
)
|
||||
)
|
||||
if existing.scalar_one_or_none() is not None:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_409_CONFLICT,
|
||||
detail="You have already submitted an open report for this message",
|
||||
)
|
||||
|
||||
report_reason = payload.reason
|
||||
if payload.category:
|
||||
report_reason = f"[{payload.category}] {payload.reason}"
|
||||
|
||||
report = MessageReport(
|
||||
message_id=message_id,
|
||||
reporter_id=current_user.id,
|
||||
reason=report_reason,
|
||||
status=ReportStatus.OPEN,
|
||||
)
|
||||
db.add(report)
|
||||
await db.commit()
|
||||
await db.refresh(report)
|
||||
return report
|
||||
|
||||
|
||||
# ──────────────────────────────── Moderation ────────────────────────────────────
|
||||
|
||||
|
||||
@moderation_router.get("/reports", response_model=list[MessageReportResponse])
|
||||
async def list_reports(
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
status_filter: ReportStatus | None = None,
|
||||
):
|
||||
"""List reports for moderator review (restricted to moderators/admins)."""
|
||||
require_moderator(current_user)
|
||||
|
||||
query = select(MessageReport).order_by(desc(MessageReport.created_at))
|
||||
if status_filter:
|
||||
query = query.where(MessageReport.status == status_filter)
|
||||
else:
|
||||
query = query.where(MessageReport.status == ReportStatus.OPEN)
|
||||
|
||||
result = await db.execute(query)
|
||||
return list(result.scalars().all())
|
||||
|
||||
|
||||
@moderation_router.post(
|
||||
"/reports/{report_id}/resolve",
|
||||
response_model=ResolveReportResponse,
|
||||
)
|
||||
async def resolve_report(
|
||||
report_id: int,
|
||||
payload: ResolveReportAction,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Resolve a moderation report with audit logging."""
|
||||
require_moderator(current_user)
|
||||
|
||||
report = await db.get(MessageReport, report_id)
|
||||
if report is None:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND, detail="Report not found"
|
||||
)
|
||||
|
||||
now = datetime.now(timezone.utc)
|
||||
report.moderator_id = current_user.id
|
||||
report.resolved_at = now
|
||||
|
||||
if payload.action == "dismiss":
|
||||
report.status = ReportStatus.DISMISSED
|
||||
else:
|
||||
report.status = ReportStatus.RESOLVED
|
||||
|
||||
# Handle action-specific effects
|
||||
if report.message_id:
|
||||
msg = await db.get(Message, report.message_id)
|
||||
if msg is not None:
|
||||
if payload.action == "ban" and msg.sender_id:
|
||||
sender = await db.get(User, msg.sender_id)
|
||||
if sender:
|
||||
sender.is_active = False
|
||||
|
||||
if payload.action in ("remove", "ban"):
|
||||
await db.delete(msg)
|
||||
|
||||
await db.commit()
|
||||
return ResolveReportResponse(
|
||||
report_id=report.id,
|
||||
status=report.status,
|
||||
action_taken=payload.action,
|
||||
moderator_id=current_user.id,
|
||||
resolved_at=now,
|
||||
notes=payload.notes,
|
||||
)
|
||||
@@ -17,7 +17,7 @@ from typing import Annotated
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException
|
||||
from pydantic import BaseModel, Field, field_validator
|
||||
from sqlalchemy import select
|
||||
from sqlalchemy import select, or_, and_
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.database import get_db
|
||||
@@ -30,6 +30,8 @@ from app.models.profile import (
|
||||
ProfileFavorite,
|
||||
ProfileVisibility,
|
||||
)
|
||||
from app.models.social import Friendship, Block, FriendshipStatus
|
||||
from app.models.user import User
|
||||
from app.models.world import World
|
||||
|
||||
router = APIRouter()
|
||||
@@ -43,6 +45,30 @@ _VISIBILITY_VALUES = {v.value for v in ProfileVisibility}
|
||||
# ──────────────────────────── Pydantic schemas ────────────────────────────────
|
||||
|
||||
|
||||
class PublicProfileWorld(BaseModel):
|
||||
id: int
|
||||
name: str
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class PublicProfileUser(BaseModel):
|
||||
id: int
|
||||
username: str
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class PublicProfileResponse(BaseModel):
|
||||
user_id: int
|
||||
username: str
|
||||
avatar_asset_id: int | None = None
|
||||
bio: str | None = None
|
||||
favorites: list[PublicProfileWorld] = Field(default_factory=list)
|
||||
friends: list[PublicProfileUser] = Field(default_factory=list)
|
||||
is_restricted: bool = False
|
||||
|
||||
|
||||
class ProfileResponse(BaseModel):
|
||||
user_id: int
|
||||
avatar_asset_id: int | None
|
||||
@@ -203,3 +229,137 @@ async def replace_my_favorites(payload: FavoritesUpdate, current_user: CurrentUs
|
||||
|
||||
await db.commit()
|
||||
return FavoritesResponse(world_ids=world_ids)
|
||||
|
||||
|
||||
@router.get("/{user_id}", response_model=PublicProfileResponse)
|
||||
async def get_public_profile(user_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Return the public profile for a user, respecting server-side privacy
|
||||
settings and block relationships."""
|
||||
user_res = await db.execute(select(User).where(User.id == user_id))
|
||||
target_user = user_res.scalar_one_or_none()
|
||||
if target_user is None or not target_user.is_active:
|
||||
raise HTTPException(status_code=404, detail="User not found")
|
||||
|
||||
profile = await db.get(Profile, user_id)
|
||||
avatar_asset = None
|
||||
if profile and profile.avatar_asset_id:
|
||||
avatar_asset = await db.get(Asset, profile.avatar_asset_id)
|
||||
|
||||
privacy = dict(DEFAULT_PRIVACY)
|
||||
if profile and profile.privacy_json:
|
||||
privacy.update(profile.privacy_json)
|
||||
|
||||
is_self = current_user.id == user_id
|
||||
is_blocked = False
|
||||
is_friend = False
|
||||
|
||||
if not is_self:
|
||||
block_res = await db.execute(
|
||||
select(Block.id).where(
|
||||
or_(
|
||||
and_(Block.blocker_id == current_user.id, Block.blocked_id == user_id),
|
||||
and_(Block.blocker_id == user_id, Block.blocked_id == current_user.id),
|
||||
)
|
||||
)
|
||||
)
|
||||
is_blocked = block_res.scalar_one_or_none() is not None
|
||||
|
||||
if not is_blocked:
|
||||
friend_res = await db.execute(
|
||||
select(Friendship.id).where(
|
||||
or_(
|
||||
and_(Friendship.requester_id == current_user.id, Friendship.addressee_id == user_id),
|
||||
and_(Friendship.requester_id == user_id, Friendship.addressee_id == current_user.id),
|
||||
),
|
||||
Friendship.status == FriendshipStatus.ACCEPTED,
|
||||
)
|
||||
)
|
||||
is_friend = friend_res.scalar_one_or_none() is not None
|
||||
|
||||
profile_vis = privacy.get("profile_visibility", ProfileVisibility.PUBLIC.value)
|
||||
if profile_vis is False:
|
||||
profile_vis = ProfileVisibility.PRIVATE.value
|
||||
elif profile_vis is True:
|
||||
profile_vis = ProfileVisibility.PUBLIC.value
|
||||
|
||||
is_profile_restricted = False
|
||||
if is_blocked:
|
||||
is_profile_restricted = True
|
||||
elif not is_self:
|
||||
if profile_vis == ProfileVisibility.PRIVATE.value:
|
||||
is_profile_restricted = True
|
||||
elif profile_vis == ProfileVisibility.FRIENDS.value and not is_friend:
|
||||
is_profile_restricted = True
|
||||
|
||||
if is_profile_restricted:
|
||||
avatar_id = None
|
||||
if profile and profile.avatar_asset_id:
|
||||
if avatar_asset and avatar_asset.is_public:
|
||||
avatar_id = profile.avatar_asset_id
|
||||
return PublicProfileResponse(
|
||||
user_id=target_user.id,
|
||||
username=target_user.username,
|
||||
avatar_asset_id=avatar_id,
|
||||
bio=None,
|
||||
favorites=[],
|
||||
friends=[],
|
||||
is_restricted=True,
|
||||
)
|
||||
|
||||
avatar_id = profile.avatar_asset_id if profile else None
|
||||
bio = profile.bio if profile else None
|
||||
|
||||
fav_vis = privacy.get("favorites_visibility", ProfileVisibility.PUBLIC.value)
|
||||
if fav_vis is False:
|
||||
fav_vis = ProfileVisibility.PRIVATE.value
|
||||
elif fav_vis is True:
|
||||
fav_vis = ProfileVisibility.PUBLIC.value
|
||||
|
||||
can_see_favorites = is_self or (fav_vis == ProfileVisibility.PUBLIC.value) or (fav_vis == ProfileVisibility.FRIENDS.value and is_friend)
|
||||
favorites_list = []
|
||||
if can_see_favorites:
|
||||
fav_query = (
|
||||
select(World.id, World.name)
|
||||
.join(ProfileFavorite, ProfileFavorite.world_id == World.id)
|
||||
.where(ProfileFavorite.user_id == user_id)
|
||||
.order_by(ProfileFavorite.created_at.desc())
|
||||
)
|
||||
fav_res = await db.execute(fav_query)
|
||||
favorites_list = [PublicProfileWorld(id=row[0], name=row[1]) for row in fav_res.all()]
|
||||
|
||||
fr_vis = privacy.get("friends_list_visibility", ProfileVisibility.PUBLIC.value)
|
||||
if fr_vis is False:
|
||||
fr_vis = ProfileVisibility.PRIVATE.value
|
||||
elif fr_vis is True:
|
||||
fr_vis = ProfileVisibility.PUBLIC.value
|
||||
|
||||
can_see_friends = is_self or (fr_vis == ProfileVisibility.PUBLIC.value) or (fr_vis == ProfileVisibility.FRIENDS.value and is_friend)
|
||||
friends_list = []
|
||||
if can_see_friends:
|
||||
fr_res = await db.execute(
|
||||
select(Friendship).where(
|
||||
or_(Friendship.requester_id == user_id, Friendship.addressee_id == user_id),
|
||||
Friendship.status == FriendshipStatus.ACCEPTED,
|
||||
)
|
||||
)
|
||||
friendships = fr_res.scalars().all()
|
||||
other_ids = [
|
||||
fr.addressee_id if fr.requester_id == user_id else fr.requester_id
|
||||
for fr in friendships
|
||||
]
|
||||
if other_ids:
|
||||
users_res = await db.execute(
|
||||
select(User.id, User.username).where(User.id.in_(other_ids), User.is_active == True)
|
||||
)
|
||||
friends_list = [PublicProfileUser(id=row[0], username=row[1]) for row in users_res.all()]
|
||||
|
||||
return PublicProfileResponse(
|
||||
user_id=target_user.id,
|
||||
username=target_user.username,
|
||||
avatar_asset_id=avatar_id,
|
||||
bio=bio,
|
||||
favorites=favorites_list,
|
||||
friends=friends_list,
|
||||
is_restricted=False,
|
||||
)
|
||||
|
||||
|
||||
@@ -0,0 +1,312 @@
|
||||
"""Integration tests for the DM chat router (app/routers/chat_dm.py):
|
||||
|
||||
- POST /api/chat/dm/{user_id}/messages
|
||||
- GET /api/chat/dm/{user_id}/messages
|
||||
- GET /api/chat/dm/conversations
|
||||
|
||||
The block-relationship router doesn't exist yet (sibling task), so blocks
|
||||
are inserted directly against the ``Block`` model, same pattern already
|
||||
used by ``tests/test_chat_models.py`` for direct model setup.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
from fastapi.testclient import TestClient
|
||||
from sqlalchemy import select
|
||||
from sqlalchemy.ext.asyncio import async_sessionmaker, create_async_engine
|
||||
from sqlalchemy.pool import NullPool
|
||||
|
||||
from app import rate_limit
|
||||
from app.config import settings
|
||||
from app.main import app
|
||||
from app.models.social import Block
|
||||
|
||||
|
||||
def _register(client: TestClient, username: str) -> dict:
|
||||
resp = client.post(
|
||||
"/api/auth/register",
|
||||
json={
|
||||
"username": username,
|
||||
"email": f"{username}@example.com",
|
||||
"password": "secret123",
|
||||
"date_of_birth": "1990-01-01",
|
||||
},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
token = resp.json()["access_token"]
|
||||
headers = {"Authorization": f"Bearer {token}"}
|
||||
me = client.get("/api/users/me", headers=headers)
|
||||
assert me.status_code == 200, me.text
|
||||
return {"headers": headers, "id": me.json()["id"], "username": username}
|
||||
|
||||
|
||||
async def _insert_block(blocker_id: int, blocked_id: int) -> None:
|
||||
engine = create_async_engine(settings.DATABASE_URL, poolclass=NullPool)
|
||||
session_factory = async_sessionmaker(engine, expire_on_commit=False)
|
||||
async with session_factory() as session:
|
||||
session.add(Block(blocker_id=blocker_id, blocked_id=blocked_id))
|
||||
await session.commit()
|
||||
await engine.dispose()
|
||||
|
||||
|
||||
class TestSendAndRetrieve:
|
||||
def test_send_then_fetch_history(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_alice1")
|
||||
bob = _register(client, "dm_bob1")
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "hey bob"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
sent = resp.json()
|
||||
assert sent["sender_id"] == alice["id"]
|
||||
assert sent["recipient_id"] == bob["id"]
|
||||
assert sent["body"] == "hey bob"
|
||||
assert sent["filtered"] is False
|
||||
assert sent["id"] is not None
|
||||
assert sent["created_at"] is not None
|
||||
|
||||
hist_alice = client.get(f"/api/chat/dm/{bob['id']}/messages", headers=alice["headers"])
|
||||
assert hist_alice.status_code == 200, hist_alice.text
|
||||
msgs = hist_alice.json()["messages"]
|
||||
assert len(msgs) == 1
|
||||
assert msgs[0]["body"] == "hey bob"
|
||||
|
||||
hist_bob = client.get(f"/api/chat/dm/{alice['id']}/messages", headers=bob["headers"])
|
||||
assert hist_bob.status_code == 200, hist_bob.text
|
||||
assert len(hist_bob.json()["messages"]) == 1
|
||||
assert hist_bob.json()["messages"][0]["body"] == "hey bob"
|
||||
|
||||
def test_cannot_message_self(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_self1")
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{alice['id']}/messages",
|
||||
json={"body": "hi me"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 400
|
||||
|
||||
def test_target_user_must_exist(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_noexist1")
|
||||
resp = client.post(
|
||||
"/api/chat/dm/999999999/messages",
|
||||
json={"body": "hello?"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 404
|
||||
|
||||
def test_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
resp = client.post("/api/chat/dm/1/messages", json={"body": "hi"})
|
||||
assert resp.status_code == 401
|
||||
|
||||
def test_history_pagination_cursor(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_page_a")
|
||||
bob = _register(client, "dm_page_b")
|
||||
|
||||
for i in range(5):
|
||||
r = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": f"msg {i}"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert r.status_code == 201, r.text
|
||||
|
||||
page1 = client.get(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
params={"limit": 2},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert page1.status_code == 200
|
||||
body1 = page1.json()
|
||||
assert len(body1["messages"]) == 2
|
||||
assert body1["messages"][0]["body"] == "msg 4" # newest first
|
||||
assert body1["next_cursor"] is not None
|
||||
|
||||
page2 = client.get(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
params={"limit": 2, "before": body1["next_cursor"]},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert page2.status_code == 200
|
||||
body2 = page2.json()
|
||||
assert [m["body"] for m in body2["messages"]] == ["msg 2", "msg 1"]
|
||||
|
||||
def test_no_conversation_yet_returns_empty_history(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_empty_a")
|
||||
bob = _register(client, "dm_empty_b")
|
||||
resp = client.get(f"/api/chat/dm/{bob['id']}/messages", headers=alice["headers"])
|
||||
assert resp.status_code == 200
|
||||
assert resp.json() == {"messages": [], "next_cursor": None}
|
||||
|
||||
|
||||
class TestConversationList:
|
||||
def test_lists_peer_last_message_and_unread_count(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_conv_a")
|
||||
bob = _register(client, "dm_conv_b")
|
||||
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "first"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "second"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
|
||||
convs_bob = client.get("/api/chat/dm/conversations", headers=bob["headers"])
|
||||
assert convs_bob.status_code == 200, convs_bob.text
|
||||
data = convs_bob.json()
|
||||
assert data["total"] == 1
|
||||
conv = data["conversations"][0]
|
||||
assert conv["peer_id"] == alice["id"]
|
||||
assert conv["peer_username"] == "dm_conv_a"
|
||||
assert conv["last_message"]["body"] == "second"
|
||||
assert conv["unread_count"] == 2 # bob hasn't read yet
|
||||
|
||||
# Bob reads the latest page -> unread resets to 0.
|
||||
client.get(f"/api/chat/dm/{alice['id']}/messages", headers=bob["headers"])
|
||||
convs_bob_after = client.get("/api/chat/dm/conversations", headers=bob["headers"])
|
||||
assert convs_bob_after.json()["conversations"][0]["unread_count"] == 0
|
||||
|
||||
# Alice sent them, so her own unread count for this conversation is 0.
|
||||
convs_alice = client.get("/api/chat/dm/conversations", headers=alice["headers"])
|
||||
assert convs_alice.json()["conversations"][0]["unread_count"] == 0
|
||||
|
||||
def test_scoped_to_authenticated_user_only(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_scope_a")
|
||||
bob = _register(client, "dm_scope_b")
|
||||
carol = _register(client, "dm_scope_c")
|
||||
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "hi bob"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
|
||||
convs_carol = client.get("/api/chat/dm/conversations", headers=carol["headers"])
|
||||
assert convs_carol.status_code == 200
|
||||
assert convs_carol.json() == {"conversations": [], "total": 0}
|
||||
|
||||
def test_cannot_read_another_pairs_conversation(self):
|
||||
"""A user's history endpoint only ever resolves *their own* pairing
|
||||
with the given peer id -- there is no conversation id in the URL an
|
||||
outsider could guess/pass to read someone else's DMs."""
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_iso_a")
|
||||
bob = _register(client, "dm_iso_b")
|
||||
carol = _register(client, "dm_iso_c")
|
||||
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "secret to bob"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
|
||||
# Carol asking for her "history with bob" gets her own (empty)
|
||||
# conversation, never alice's.
|
||||
resp = client.get(f"/api/chat/dm/{bob['id']}/messages", headers=carol["headers"])
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["messages"] == []
|
||||
|
||||
|
||||
class TestBlocking:
|
||||
async def test_blocker_cannot_send_to_blocked(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_block_a1")
|
||||
bob = _register(client, "dm_block_b1")
|
||||
await _insert_block(alice["id"], bob["id"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "let me in"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
async def test_blocked_cannot_send_to_blocker(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_block_a2")
|
||||
bob = _register(client, "dm_block_b2")
|
||||
await _insert_block(alice["id"], bob["id"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{alice['id']}/messages",
|
||||
json={"body": "please respond"},
|
||||
headers=bob["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
|
||||
class TestTextFilter:
|
||||
def test_message_tripping_filter_is_redacted_and_flagged(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_filter_a")
|
||||
bob = _register(client, "dm_filter_b")
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "you are a bastard"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
data = resp.json()
|
||||
assert data["filtered"] is True
|
||||
assert "bastard" not in data["body"]
|
||||
assert "*" in data["body"]
|
||||
|
||||
# The stored/delivered copy is the redacted one, not the raw text.
|
||||
hist = client.get(f"/api/chat/dm/{alice['id']}/messages", headers=bob["headers"])
|
||||
assert hist.json()["messages"][0]["body"] == data["body"]
|
||||
|
||||
def test_clean_message_is_not_flagged(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_clean_a")
|
||||
bob = _register(client, "dm_clean_b")
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "have a nice day"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 201
|
||||
assert resp.json()["filtered"] is False
|
||||
assert resp.json()["body"] == "have a nice day"
|
||||
|
||||
|
||||
class TestRateLimit:
|
||||
@pytest.fixture(autouse=True)
|
||||
def _enable_rate_limiting(self):
|
||||
prev = settings.RATE_LIMIT_ENABLED
|
||||
settings.RATE_LIMIT_ENABLED = True
|
||||
rate_limit.reset_all()
|
||||
yield
|
||||
rate_limit.reset_all()
|
||||
settings.RATE_LIMIT_ENABLED = prev
|
||||
|
||||
def test_send_rate_limit_exceeded_returns_429(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_rl_a")
|
||||
bob = _register(client, "dm_rl_b")
|
||||
|
||||
codes = []
|
||||
for i in range(25):
|
||||
r = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": f"spam {i}"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
codes.append(r.status_code)
|
||||
|
||||
assert codes[:20] == [201] * 20
|
||||
assert 429 in codes[20:]
|
||||
assert codes[-1] == 429
|
||||
@@ -0,0 +1,201 @@
|
||||
"""Integration tests for message reporting and moderation queue:
|
||||
- POST /api/chat/messages/{message_id}/report
|
||||
- GET /api/moderation/reports
|
||||
- POST /api/moderation/reports/{id}/resolve
|
||||
"""
|
||||
|
||||
import pytest
|
||||
from fastapi.testclient import TestClient
|
||||
|
||||
from app.main import app
|
||||
|
||||
|
||||
def _register(client: TestClient, username: str) -> dict:
|
||||
resp = client.post(
|
||||
"/api/auth/register",
|
||||
json={
|
||||
"username": username,
|
||||
"email": f"{username}@example.com",
|
||||
"password": "secret123",
|
||||
"date_of_birth": "1990-01-01",
|
||||
},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
token = resp.json()["access_token"]
|
||||
headers = {"Authorization": f"Bearer {token}"}
|
||||
me = client.get("/api/users/me", headers=headers)
|
||||
assert me.status_code == 200, me.text
|
||||
return {"headers": headers, "id": me.json()["id"], "username": username}
|
||||
|
||||
|
||||
def _send_dm(client: TestClient, sender: dict, recipient: dict, text: str = "hello") -> int:
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{recipient['id']}/messages",
|
||||
headers=sender["headers"],
|
||||
json={"body": text},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
return resp.json()["id"]
|
||||
|
||||
|
||||
class TestReportMessage:
|
||||
def test_report_message_success(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "rep_alice1")
|
||||
bob = _register(client, "rep_bob1")
|
||||
|
||||
msg_id = _send_dm(client, alice, bob, "spam message")
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/messages/{msg_id}/report",
|
||||
headers=bob["headers"],
|
||||
json={"reason": "Contains spam", "category": "spam"},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
data = resp.json()
|
||||
assert data["message_id"] == msg_id
|
||||
assert data["reporter_id"] == bob["id"]
|
||||
assert data["status"] == "open"
|
||||
assert "[spam] Contains spam" in data["reason"]
|
||||
|
||||
def test_duplicate_report_rejected(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "rep_alice2")
|
||||
bob = _register(client, "rep_bob2")
|
||||
|
||||
msg_id = _send_dm(client, alice, bob, "bad message")
|
||||
|
||||
resp1 = client.post(
|
||||
f"/api/chat/messages/{msg_id}/report",
|
||||
headers=bob["headers"],
|
||||
json={"reason": "offensive"},
|
||||
)
|
||||
assert resp1.status_code == 201
|
||||
|
||||
resp2 = client.post(
|
||||
f"/api/chat/messages/{msg_id}/report",
|
||||
headers=bob["headers"],
|
||||
json={"reason": "offensive again"},
|
||||
)
|
||||
assert resp2.status_code == 409
|
||||
|
||||
def test_report_nonexistent_message_404(self):
|
||||
client = TestClient(app)
|
||||
bob = _register(client, "rep_bob3")
|
||||
|
||||
resp = client.post(
|
||||
"/api/chat/messages/999999/report",
|
||||
headers=bob["headers"],
|
||||
json={"reason": "ghost"},
|
||||
)
|
||||
assert resp.status_code == 404
|
||||
|
||||
def test_report_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
resp = client.post("/api/chat/messages/1/report", json={"reason": "no auth"})
|
||||
assert resp.status_code == 401
|
||||
|
||||
|
||||
class TestModerationQueue:
|
||||
def test_non_moderator_cannot_access_queue(self):
|
||||
client = TestClient(app)
|
||||
regular_user = _register(client, "rep_regular1")
|
||||
|
||||
resp = client.get("/api/moderation/reports", headers=regular_user["headers"])
|
||||
assert resp.status_code == 403
|
||||
|
||||
def test_moderator_can_list_reports(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "rep_alice4")
|
||||
bob = _register(client, "rep_bob4")
|
||||
admin = _register(client, "admin_list")
|
||||
|
||||
msg_id = _send_dm(client, alice, bob, "something to report")
|
||||
client.post(
|
||||
f"/api/chat/messages/{msg_id}/report",
|
||||
headers=bob["headers"],
|
||||
json={"reason": "needs review"},
|
||||
)
|
||||
|
||||
resp = client.get("/api/moderation/reports", headers=admin["headers"])
|
||||
assert resp.status_code == 200, resp.text
|
||||
reports = resp.json()
|
||||
assert len(reports) >= 1
|
||||
assert any(r["message_id"] == msg_id for r in reports)
|
||||
|
||||
def test_moderator_resolve_dismiss(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "rep_alice5")
|
||||
bob = _register(client, "rep_bob5")
|
||||
admin = _register(client, "admin_dismiss")
|
||||
|
||||
msg_id = _send_dm(client, alice, bob, "benign message")
|
||||
rep_resp = client.post(
|
||||
f"/api/chat/messages/{msg_id}/report",
|
||||
headers=bob["headers"],
|
||||
json={"reason": "false alarm"},
|
||||
)
|
||||
report_id = rep_resp.json()["id"]
|
||||
|
||||
resolve_resp = client.post(
|
||||
f"/api/moderation/reports/{report_id}/resolve",
|
||||
headers=admin["headers"],
|
||||
json={"action": "dismiss", "notes": "No violation found"},
|
||||
)
|
||||
assert resolve_resp.status_code == 200, resolve_resp.text
|
||||
data = resolve_resp.json()
|
||||
assert data["report_id"] == report_id
|
||||
assert data["status"] == "dismissed"
|
||||
assert data["action_taken"] == "dismiss"
|
||||
assert data["moderator_id"] == admin["id"]
|
||||
|
||||
def test_moderator_resolve_remove(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "rep_alice6")
|
||||
bob = _register(client, "rep_bob6")
|
||||
admin = _register(client, "admin_remove")
|
||||
|
||||
msg_id = _send_dm(client, alice, bob, "offensive content")
|
||||
rep_resp = client.post(
|
||||
f"/api/chat/messages/{msg_id}/report",
|
||||
headers=bob["headers"],
|
||||
json={"reason": "hate speech"},
|
||||
)
|
||||
report_id = rep_resp.json()["id"]
|
||||
|
||||
resolve_resp = client.post(
|
||||
f"/api/moderation/reports/{report_id}/resolve",
|
||||
headers=admin["headers"],
|
||||
json={"action": "remove", "notes": "Content removed"},
|
||||
)
|
||||
assert resolve_resp.status_code == 200
|
||||
assert resolve_resp.json()["status"] == "resolved"
|
||||
|
||||
# The message is removed from conversation history
|
||||
hist = client.get(f"/api/chat/dm/{bob['id']}/messages", headers=alice["headers"])
|
||||
assert all(m["id"] != msg_id for m in hist.json()["messages"])
|
||||
|
||||
def test_moderator_resolve_ban(self):
|
||||
client = TestClient(app)
|
||||
bad_user = _register(client, "bad_actor")
|
||||
victim = _register(client, "rep_victim")
|
||||
admin_auth = _register(client, "admin_ban")
|
||||
|
||||
msg_id = _send_dm(client, bad_user, victim, "terrible violation")
|
||||
rep_resp = client.post(
|
||||
f"/api/chat/messages/{msg_id}/report",
|
||||
headers=victim["headers"],
|
||||
json={"reason": "malicious user"},
|
||||
)
|
||||
report_id = rep_resp.json()["id"]
|
||||
|
||||
resolve_resp = client.post(
|
||||
f"/api/moderation/reports/{report_id}/resolve",
|
||||
headers=admin_auth["headers"],
|
||||
json={"action": "ban", "notes": "Banned malicious user"},
|
||||
)
|
||||
assert resolve_resp.status_code == 200
|
||||
|
||||
# Attempting to use bad_user's token fails with 403 inactive account
|
||||
bad_me = client.get("/api/users/me", headers=bad_user["headers"])
|
||||
assert bad_me.status_code == 403
|
||||
@@ -251,3 +251,156 @@ class TestFavorites:
|
||||
client = TestClient(app)
|
||||
assert client.get("/api/profile/me/favorites").status_code == 401
|
||||
assert client.put("/api/profile/me/favorites", json={"world_ids": []}).status_code == 401
|
||||
|
||||
|
||||
class TestPublicProfile:
|
||||
def test_public_profile_full_view(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_alice")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_bob")
|
||||
|
||||
w1 = _make_world(client, h_alice, "AliceWorld")
|
||||
asset_id = _make_asset(client, h_alice, "AliceAsset")
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={"bio": "Hi, I am Alice", "avatar_asset_id": asset_id},
|
||||
)
|
||||
client.put("/api/profile/me/favorites", headers=h_alice, json={"world_ids": [w1]})
|
||||
|
||||
resp = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp.status_code == 200, resp.text
|
||||
data = resp.json()
|
||||
assert data["user_id"] == alice_id
|
||||
assert data["username"] == "pub_alice"
|
||||
assert data["bio"] == "Hi, I am Alice"
|
||||
assert data["avatar_asset_id"] == asset_id
|
||||
assert data["is_restricted"] is False
|
||||
assert len(data["favorites"]) == 1
|
||||
assert data["favorites"][0]["id"] == w1
|
||||
assert data["favorites"][0]["name"] == "AliceWorld"
|
||||
assert "email" not in data
|
||||
assert "password" not in data
|
||||
|
||||
def test_public_profile_not_found(self):
|
||||
client = TestClient(app)
|
||||
h_bob = _auth_headers(client, "pub_nf_bob")
|
||||
resp = client.get("/api/profile/999999", headers=h_bob)
|
||||
assert resp.status_code == 404
|
||||
|
||||
def test_public_profile_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
assert client.get("/api/profile/1").status_code == 401
|
||||
|
||||
def test_public_profile_private_visibility(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_priv_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_priv_b")
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={"bio": "Top secret bio", "privacy": {"profile_visibility": "private"}},
|
||||
)
|
||||
|
||||
resp_bob = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp_bob.status_code == 200
|
||||
data_bob = resp_bob.json()
|
||||
assert data_bob["is_restricted"] is True
|
||||
assert data_bob["bio"] is None
|
||||
assert data_bob["favorites"] == []
|
||||
assert data_bob["friends"] == []
|
||||
|
||||
# Alice viewing herself is not restricted
|
||||
resp_alice = client.get(f"/api/profile/{alice_id}", headers=h_alice)
|
||||
assert resp_alice.status_code == 200
|
||||
assert resp_alice.json()["is_restricted"] is False
|
||||
assert resp_alice.json()["bio"] == "Top secret bio"
|
||||
|
||||
def test_public_profile_friends_only_visibility(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_fo_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_fo_b")
|
||||
bob_id = _me_id(client, h_bob)
|
||||
h_charlie = _auth_headers(client, "pub_fo_c")
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={"bio": "Friends only bio", "privacy": {"profile_visibility": "friends"}},
|
||||
)
|
||||
|
||||
# Charlie is not a friend -> restricted
|
||||
resp_c = client.get(f"/api/profile/{alice_id}", headers=h_charlie)
|
||||
assert resp_c.json()["is_restricted"] is True
|
||||
assert resp_c.json()["bio"] is None
|
||||
|
||||
# Bob becomes friends with Alice
|
||||
req = client.post("/api/friends/requests", headers=h_bob, json={"user_id": alice_id})
|
||||
req_id = req.json()["id"]
|
||||
client.post(f"/api/friends/requests/{req_id}/accept", headers=h_alice)
|
||||
|
||||
# Now Bob sees full profile and friends list contains Bob
|
||||
resp_b = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp_b.json()["is_restricted"] is False
|
||||
assert resp_b.json()["bio"] == "Friends only bio"
|
||||
assert any(f["id"] == bob_id for f in resp_b.json()["friends"])
|
||||
|
||||
def test_public_profile_blocked_user_gets_restricted(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_blk_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_dan = _auth_headers(client, "pub_blk_d")
|
||||
dan_id = _me_id(client, h_dan)
|
||||
|
||||
client.put("/api/profile/me", headers=h_alice, json={"bio": "Alice public bio"})
|
||||
client.post(f"/api/friends/{dan_id}/block", headers=h_alice)
|
||||
|
||||
# Dan viewing Alice gets restricted view
|
||||
resp_dan = client.get(f"/api/profile/{alice_id}", headers=h_dan)
|
||||
assert resp_dan.status_code == 200
|
||||
assert resp_dan.json()["is_restricted"] is True
|
||||
assert resp_dan.json()["bio"] is None
|
||||
|
||||
# Alice viewing Dan gets restricted view
|
||||
resp_alice = client.get(f"/api/profile/{dan_id}", headers=h_alice)
|
||||
assert resp_alice.status_code == 200
|
||||
assert resp_alice.json()["is_restricted"] is True
|
||||
|
||||
def test_public_profile_selective_favorites_and_friends_privacy(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_sec_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_sec_b")
|
||||
bob_id = _me_id(client, h_bob)
|
||||
w1 = _make_world(client, h_alice, "WorldSec")
|
||||
|
||||
client.put("/api/profile/me/favorites", headers=h_alice, json={"world_ids": [w1]})
|
||||
req = client.post("/api/friends/requests", headers=h_bob, json={"user_id": alice_id})
|
||||
req_id = req.json()["id"]
|
||||
client.post(f"/api/friends/requests/{req_id}/accept", headers=h_alice)
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={
|
||||
"bio": "Bio is public",
|
||||
"privacy": {
|
||||
"profile_visibility": "public",
|
||||
"favorites_visibility": "private",
|
||||
"friends_list_visibility": "private",
|
||||
},
|
||||
},
|
||||
)
|
||||
|
||||
resp = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp.status_code == 200
|
||||
data = resp.json()
|
||||
assert data["bio"] == "Bio is public"
|
||||
assert data["favorites"] == []
|
||||
assert data["friends"] == []
|
||||
|
||||
|
||||
Reference in New Issue
Block a user