WIP checkpoint: Address review feedback: Plan: MVP Vertical Slice: Client-Server Wiring

backend/app/models/asset.py

@@ -3,8 +3,6 @@ from sqlalchemy.dialects.postgresql import ENUM
 from sqlalchemy.orm import relationship
 from sqlalchemy.sql import func
 import enum
-import json
-from typing import Any, Optional
 
 from app.database import Base
 
@@ -40,32 +38,3 @@ class Asset(Base):
 
     owner = relationship("User", back_populates="assets")
     world = relationship("World", back_populates="assets")
-
-    # ------------------------------------------------------------------
-    # Computed properties
-    # ------------------------------------------------------------------
-
-    @property
-    def has_gltf_metadata(self) -> bool:
-        """Return True when metadata_json contains glTF-specific keys.
-
-        glTF metadata is considered present when the stored JSON contains at
-        least one of the keys that *extract_gltf_metadata* produces
-        (mesh_count, vertex_count, has_animation, texture_refs,
-        bounding_box_min, bounding_box_max).
-        """
-        if not self.metadata_json:
-            return False
-        try:
-            data: dict[str, Any] = json.loads(self.metadata_json)
-        except (json.JSONDecodeError, TypeError):
-            return False
-        gltf_keys = {
-            "mesh_count",
-            "vertex_count",
-            "has_animation",
-            "texture_refs",
-            "bounding_box_min",
-            "bounding_box_max",
-        }
-        return bool(gltf_keys & data.keys())

docs/planning/client-server-wiring.md

@@ -23,10 +23,9 @@ explicitly out of scope.
 | # | Type | Task | Depends on |
 |---|------|------|-----------|
 | 1 | architecture | `ApiClient` autoload: HTTP + JWT storage + error contract | — |
-| 2 | implementation | Main-menu **login** wiring (form-encoded) | 1 |
+| 2 | implementation | Main-menu **login + register** UI built & wired (form-encoded + JSON/age gate) | 1 |
-| 3 | implementation | Main-menu **register** wiring (JSON + age gate) | 2 |
+| 3 | implementation | **World list** screen consuming `GET /api/worlds` | 1 |
-| 4 | implementation | **World list** screen consuming `GET /api/worlds` | 2 |
+| 4 | testing | End-to-end headless smoke test + manual verify | 1,2,3 |
-| 5 | testing | End-to-end headless smoke test + manual verify | 1,3,4 |
 
 ## Design decisions captured (resolved in task 1)
 - Token storage: in-memory singleton property for the MVP; a `save_to_disk` seam is left
@@ -35,3 +34,8 @@ explicitly out of scope.
   never crash on network failure; non-2xx surfaces `{status, detail}` from the backend.
 - Base URL: read from a ProjectSetting, defaulting to `http://127.0.0.1:8000`.
 - Login is form-encoded; register is JSON — the client helper must support both content types.
+
+## Notes
+- The main-menu auth UI does **not** exist yet (main_menu.gd currently has only Play/Quit
+  stubs). Task 2 must **build** the login/register UI, not merely wire an existing one.
+- The world-list screen also needs to be **built** (a new scene), not just wired.

scripts/api_client.gd.uid

@@ -1 +0,0 @@
-uid://cjd0uhll7iylj

scripts/main_menu.gd.uid

@@ -1 +0,0 @@
-uid://bgnc3iamfgf6k