daddy/modbison
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Address review feedback: Implement chunk streaming system in GDScript #20

Merged
reviewer-bot merged 21 commits from agent/bd718b31b595 into main 2026-08-18 14:41:08 +00:00
Conversation 0 Commits 21 Files Changed 22
+5 -5
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 25f2dffc53 - Show all commits
scripts/chunk_scene.gd
+5 -5
View File
@@ -11,9 +11,9 @@ extends Node3D
## ##
## ``` ## ```
## ChunkScene (Node3D) ## ChunkScene (Node3D)
## ├── TileLayer (Node3D) # one per tile layer (ground, walls, decor, ...) ## ├─ TileLayer (Node3D) # one per tile layer (ground, walls, decor, ...)
## ├── StaticObject (Node3D) # props, geometry, interactables ## ├─ StaticObject (Node3D) # props, geometry, interactables
## └── DynamicObject (Node3D) # spawnable entities (templates) ## └─ DynamicObject (Node3D) # spawnable entities (templates)
## ``` ## ```
## ##
## ## Lifecycle ## ## Lifecycle
@@ -92,7 +92,7 @@ func _add_static_object(obj: WorldObject) -> void:
var static_obj := StaticObjectNode.new() var static_obj := StaticObjectNode.new()
static_obj.world_object = obj static_obj.world_object = obj
static_obj.position = obj.position static_obj.position = obj.position
static_obj.rotation = obj.rotation static_obj.quaternion = Quaternion(obj.rotation.x, obj.rotation.y, obj.rotation.z, obj.rotation.w)
static_obj.scale = obj.scale static_obj.scale = obj.scale
static_obj.name = "static_%s" % obj.id static_obj.name = "static_%s" % obj.id
add_child(static_obj) add_child(static_obj)
@@ -102,7 +102,7 @@ func _add_dynamic_object(obj: WorldObject) -> void:
var dynamic_obj := DynamicObjectNode.new() var dynamic_obj := DynamicObjectNode.new()
dynamic_obj.world_object = obj dynamic_obj.world_object = obj
dynamic_obj.position = obj.position dynamic_obj.position = obj.position
dynamic_obj.rotation = obj.rotation dynamic_obj.quaternion = Quaternion(obj.rotation.x, obj.rotation.y, obj.rotation.z, obj.rotation.w)
dynamic_obj.scale = obj.scale dynamic_obj.scale = obj.scale
dynamic_obj.name = "dynamic_%s" % obj.id dynamic_obj.name = "dynamic_%s" % obj.id
add_child(dynamic_obj) add_child(dynamic_obj)