claude-checkpoint-tooling
3679e4dbc4
Reported directly by the user playtesting the exported exe: Play was permanently disabled and there was no way to log in or register. Root cause: main_menu.tscn wired Play and Quit, but nothing was ever connected to _on_login_button_pressed()/_on_register_button_pressed() -- the AuthPanel, its form, and all its backend-calling logic were fully correct, just completely unreachable. The script's own top comment even said "(the existing Play/Quit buttons)" as if Play/Quit somehow doubled as login triggers, which they never did -- a sign nobody ever actually clicked through the running scene, only checked things at the API level. Fix: added a real AuthButtonsRow (LoginButton, RegisterButton) wired to the existing handlers, which now hide themselves once auth succeeds. Also fixed grab_focus() targeting the AuthPanel (which can't accept focus, just a background warning) to focus the username field instead. Verified via two new smoke tests (smoke_test_main_menu_ui.gd, smoke_test_main_menu_full_flow.gd) using a *real signal emission* on the buttons, not a direct method call -- that distinction is exactly what would have caught the original bug. Full click-through confirmed against a real backend: open register form, fill it, submit, Play actually becomes enabled, welcome message shows, auth buttons hide. Also documents a real headless-testing gotcha found while verifying this: a synthetic Button.pressed.emit() on an await-using handler doesn't reliably get driven forward in --script/SceneTree mode the way real GUI input dispatch does -- confirmed by comparing direct-call vs emit() behavior side by side. Not a bug in the actual click-driven flow, a test-harness quirk to route around (call the handler directly, awaited, instead of emitting the signal). Full checkpoint suite re-verified clean on this branch: migrations, 68/68 pytest, all 6 Godot smoke tests (including the 2 new ones, picked up automatically by run_checkpoint_tests.py's glob). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
77 lines
3.4 KiB
GDScript
77 lines
3.4 KiB
GDScript
extends SceneTree
|
|
## Full click-through simulation of the real user flow: press Register,
|
|
## fill the form exactly as a human would, submit, confirm Play actually
|
|
## becomes clickable. This is the check that would have caught the
|
|
## original bug (no way to even open the form) and would catch a repeat
|
|
## of it.
|
|
|
|
var passed := 0
|
|
var failed := 0
|
|
|
|
|
|
func _initialize() -> void:
|
|
_run()
|
|
|
|
|
|
func _run() -> void:
|
|
await process_frame
|
|
|
|
var packed: PackedScene = load("res://scenes/main_menu.tscn")
|
|
var instance: Control = packed.instantiate()
|
|
root.add_child(instance)
|
|
await process_frame
|
|
|
|
var register_button: Button = instance.get_node("CenterContainer/VBoxContainer/AuthButtonsRow/RegisterButton")
|
|
var auth_buttons_row: HBoxContainer = instance.get_node("CenterContainer/VBoxContainer/AuthButtonsRow")
|
|
var username_edit: LineEdit = instance.get_node("CenterContainer/VBoxContainer/AuthPanel/MarginContainer/AuthVBox/UsernameEdit")
|
|
var password_edit: LineEdit = instance.get_node("CenterContainer/VBoxContainer/AuthPanel/MarginContainer/AuthVBox/PasswordEdit")
|
|
var email_edit: LineEdit = instance.get_node("CenterContainer/VBoxContainer/AuthPanel/MarginContainer/AuthVBox/EmailEdit")
|
|
var dob_edit: LineEdit = instance.get_node("CenterContainer/VBoxContainer/AuthPanel/MarginContainer/AuthVBox/DOBEdit")
|
|
var auth_button: Button = instance.get_node("CenterContainer/VBoxContainer/AuthPanel/MarginContainer/AuthVBox/AuthButton")
|
|
var welcome_label: Label = instance.get_node("CenterContainer/VBoxContainer/AuthPanel/MarginContainer/AuthVBox/WelcomeLabel")
|
|
var play_button: Button = instance.get_node("CenterContainer/VBoxContainer/PlayButton")
|
|
|
|
_check("Play starts disabled", play_button.disabled)
|
|
|
|
# Click Register -- a real signal emission is fine here since
|
|
# _on_register_button_pressed() is synchronous (no await), same as a
|
|
# real click's GUI event dispatch would drive it.
|
|
register_button.pressed.emit()
|
|
await process_frame
|
|
|
|
_check("auth panel opened in register mode", instance.get_node("CenterContainer/VBoxContainer/AuthPanel").visible)
|
|
|
|
# Fill the form exactly as a user would type into it.
|
|
var unique_id := int(Time.get_unix_time_from_system() * 1000)
|
|
username_edit.text = "mainmenu_e2e_%d" % unique_id
|
|
password_edit.text = "TestPass123!"
|
|
email_edit.text = "mainmenu_e2e_%d@test.example.com" % unique_id
|
|
dob_edit.text = "2000-01-01"
|
|
|
|
# Call the submit handler directly (awaited) rather than via
|
|
# auth_button.pressed.emit() -- a synthetic .emit() in --script/
|
|
# SceneTree headless mode doesn't drive an await-using handler's
|
|
# coroutine forward the same way real GUI input event dispatch does
|
|
# (confirmed via a direct-call vs emit() comparison: the direct call
|
|
# always resolves, the synthetic emit sometimes doesn't advance past
|
|
# its own await point even after 50 real process_frame waits). This
|
|
# is a headless-mode test-harness limitation, not a bug in the actual
|
|
# click-driven flow.
|
|
await instance._on_auth_button_pressed()
|
|
|
|
_check("Play became enabled after real register submission", not play_button.disabled)
|
|
_check("Welcome label visible", welcome_label.visible)
|
|
_check("Auth buttons row hid itself after success", not auth_buttons_row.visible)
|
|
|
|
print("\n=== SMOKE RESULT: %d/%d passed ===" % [passed, passed + failed])
|
|
quit(0 if failed == 0 else 1)
|
|
|
|
|
|
func _check(description: String, condition: bool) -> void:
|
|
if condition:
|
|
print(" PASS: ", description)
|
|
passed += 1
|
|
else:
|
|
printerr(" FAIL: ", description)
|
|
failed += 1
|