claude-checkpoint-tooling
8fc9d378e4
Reported directly by the user after seeding a test world through the browse-worlds screen: "screen is blank now". Two compounding layout bugs, both real: 1. world_list.tscn's root VBoxContainer had no anchors at all, only size_flags -- but its parent (the scene's root node) is a plain Control, not a Container, so size_flags on a Control's direct child are meaningless there. Without anchors it never actually filled the screen, so it (and everything under it) collapsed toward zero size. 2. size_flags_horizontal/vertical used the raw integer 4 everywhere expand-fill was clearly intended (ScrollContainer, its WorldList child, HeaderHBox, TitleLabel) -- but 4 is Control.SIZE_SHRINK_CENTER in Godot 4, not SIZE_EXPAND_FILL (which is 3). ScrollContainer with SHRINK_CENTER takes only its own minimum size instead of expanding, cascading a ~1px width down through every card and every label. Confirmed the actual enum values by asking Godot directly rather than assuming. Both are exactly the kind of bug a headless smoke test checking only "did cards get added to the tree" can't catch -- child_count was correctly non-zero, nothing crashed, the content was just rendered invisibly thin. Verified the fix is real by deliberately reintroducing bug #2 and confirming the test now correctly fails (card width 25px, below the 200px sanity threshold) before restoring it. Also replaced the card background: it was a ColorRect manually moved to child index 0 of a VBoxContainer, which doesn't work as an overlay -- a VBoxContainer lays out ALL its children in sequence, so the "moved to front" ColorRect rendered as an empty dark bar ABOVE the text, not behind it. Now a proper PanelContainer with a StyleBoxFlat background, the idiomatic way to get a colored panel behind auto-laid-out content in Godot. smoke_test_world_list.gd strengthened to actually catch this class of bug going forward: seeds a real world via POST /api/worlds/ first (the checkpoint runner's fresh DB meant the populated-card path never ran in CI at all before this, only empty-list did), and asserts each card's real computed width, not just that cards exist. Full checkpoint suite re-verified clean on this branch: migrations, 68/68 pytest, all 6 Godot smoke tests, both platform exports. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
143 lines
4.8 KiB
GDScript
143 lines
4.8 KiB
GDScript
extends Control
|
|
## World list screen — browses public worlds via GET /api/worlds.
|
|
##
|
|
## Displays a scrollable list of world cards (name + description).
|
|
## Handles loading, empty list, errors, and refresh.
|
|
|
|
|
|
# UI references
|
|
@onready var scroll_container: ScrollContainer = $VBoxContainer/ScrollContainer
|
|
@onready var world_list: VBoxContainer = $VBoxContainer/ScrollContainer/WorldList
|
|
@onready var loading_label: Label = $VBoxContainer/LoadingLabel
|
|
@onready var error_label: Label = $VBoxContainer/ErrorLabel
|
|
@onready var refresh_button: Button = $VBoxContainer/HeaderHBox/RefreshButton
|
|
@onready var back_button: Button = $VBoxContainer/HeaderHBox/BackButton
|
|
@onready var empty_label: Label = $VBoxContainer/EmptyLabel
|
|
|
|
|
|
func _ready() -> void:
|
|
refresh_button.disabled = false
|
|
back_button.disabled = false
|
|
loading_label.visible = false
|
|
error_label.visible = false
|
|
empty_label.visible = false
|
|
world_list.visible = false
|
|
_refresh_worlds()
|
|
|
|
|
|
func _on_refresh_button_pressed() -> void:
|
|
_refresh_worlds()
|
|
|
|
|
|
func _on_back_button_pressed() -> void:
|
|
get_tree().change_scene_to_file("res://scenes/main_menu.tscn")
|
|
|
|
|
|
## Fetch the world list from the backend and update the UI.
|
|
func _refresh_worlds() -> void:
|
|
# Reset UI state
|
|
loading_label.visible = true
|
|
error_label.visible = false
|
|
empty_label.visible = false
|
|
world_list.visible = false
|
|
refresh_button.disabled = true
|
|
|
|
# Clear previous world cards
|
|
for child in world_list.get_children():
|
|
child.queue_free()
|
|
|
|
var result := await ApiClient.get_worlds()
|
|
|
|
loading_label.visible = false
|
|
refresh_button.disabled = false
|
|
|
|
if not result.ok:
|
|
# Show error message (401, network failure, etc.)
|
|
error_label.text = "Error: %s" % result.detail
|
|
error_label.visible = true
|
|
empty_label.visible = false
|
|
world_list.visible = false
|
|
return
|
|
|
|
var data = result.data
|
|
if not data is Array:
|
|
error_label.text = "Unexpected response format."
|
|
error_label.visible = true
|
|
empty_label.visible = false
|
|
world_list.visible = false
|
|
return
|
|
|
|
if data.is_empty():
|
|
empty_label.text = "No worlds yet. Check back later!"
|
|
empty_label.visible = true
|
|
error_label.visible = false
|
|
world_list.visible = false
|
|
return
|
|
|
|
# Render world cards
|
|
world_list.visible = true
|
|
empty_label.visible = false
|
|
error_label.visible = false
|
|
|
|
for world_dict in data:
|
|
if not world_dict is Dictionary:
|
|
continue
|
|
var card := _create_world_card(world_dict)
|
|
world_list.add_child(card)
|
|
|
|
|
|
## Create a visual card for a single world entry.
|
|
func _create_world_card(world_dict: Dictionary) -> Control:
|
|
# PanelContainer for the background, not a ColorRect moved to child index
|
|
# 0 of a VBoxContainer -- a VBoxContainer lays out ALL its children in a
|
|
# vertical sequence, it has no concept of "float this one child behind
|
|
# the others as an overlay". That version rendered as an empty dark bar
|
|
# sitting above the text, not a background behind it.
|
|
var panel := PanelContainer.new()
|
|
panel.size_flags_horizontal = Control.SIZE_EXPAND_FILL
|
|
panel.custom_minimum_size = Vector2(0, 80)
|
|
var style := StyleBoxFlat.new()
|
|
style.bg_color = Color(0.15, 0.15, 0.15, 1.0)
|
|
style.content_margin_left = 12
|
|
style.content_margin_right = 12
|
|
style.content_margin_top = 8
|
|
style.content_margin_bottom = 8
|
|
panel.add_theme_stylebox_override("panel", style)
|
|
|
|
var card := VBoxContainer.new()
|
|
card.size_flags_horizontal = Control.SIZE_EXPAND_FILL
|
|
card.add_theme_constant_override("separation", 4)
|
|
panel.add_child(card)
|
|
|
|
var name_label := Label.new()
|
|
name_label.text = world_dict.get("name", "Unnamed World")
|
|
name_label.autowrap_mode = TextServer.AUTOWRAP_WORD
|
|
name_label.size_flags_horizontal = Control.SIZE_FILL
|
|
name_label.size_flags_vertical = Control.SIZE_SHRINK_BEGIN
|
|
name_label.add_theme_font_size_override("font_size", 18)
|
|
|
|
var desc_label := Label.new()
|
|
var description: String = str(world_dict.get("description", ""))
|
|
desc_label.text = description if description != "" else "No description."
|
|
desc_label.autowrap_mode = TextServer.AUTOWRAP_WORD
|
|
desc_label.size_flags_horizontal = Control.SIZE_FILL
|
|
desc_label.size_flags_vertical = Control.SIZE_EXPAND_FILL
|
|
desc_label.add_theme_font_size_override("font_size", 14)
|
|
desc_label.add_theme_color_override("font_color", Color(0.7, 0.7, 0.7, 1.0))
|
|
|
|
var meta_label := Label.new()
|
|
var visibility: String = str(world_dict.get("visibility", "public"))
|
|
var created: String = str(world_dict.get("created_at", ""))
|
|
meta_label.text = "Visibility: %s%s" % [visibility, " | Created: " + created if created != "" else ""]
|
|
meta_label.autowrap_mode = TextServer.AUTOWRAP_WORD
|
|
meta_label.size_flags_horizontal = Control.SIZE_FILL
|
|
meta_label.size_flags_vertical = Control.SIZE_SHRINK_BEGIN
|
|
meta_label.add_theme_font_size_override("font_size", 12)
|
|
meta_label.add_theme_color_override("font_color", Color(0.5, 0.5, 0.5, 1.0))
|
|
|
|
card.add_child(name_label)
|
|
card.add_child(desc_label)
|
|
card.add_child(meta_label)
|
|
|
|
return panel
|