Compare commits
18 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 0b525d6996 | |||
| eacdeb5b46 | |||
| 8b17c17137 | |||
| 24024a3463 | |||
| 0a0dde3d50 | |||
| abd05b266d | |||
| 11c4810231 | |||
| e2c8671c57 | |||
| f6c55d888f | |||
| eac6cf81ef | |||
| 10a431e7a1 | |||
| 0b3622d6b3 | |||
| eb2328b427 | |||
| 55f849f221 | |||
| 600261dba2 | |||
| c256fb2334 | |||
| 9334caf533 | |||
| de2d431571 |
@@ -0,0 +1,65 @@
|
||||
"""add profile tables (profiles, profile_favorites)
|
||||
|
||||
Revision ID: 0010_add_profile_tables
|
||||
Revises: 0009_add_group_tables
|
||||
Create Date: 2026-09-15 00:00:00.000000
|
||||
|
||||
app/models/profile.py. Models + migration + owner-only /api/profile/me
|
||||
endpoints only -- the public profile view endpoint (GET /api/profile/{user_id})
|
||||
belongs to a sibling task that depends on this one.
|
||||
"""
|
||||
from typing import Sequence, Union
|
||||
|
||||
from alembic import op
|
||||
import sqlalchemy as sa
|
||||
from sqlalchemy.dialects import postgresql
|
||||
|
||||
# revision identifiers, used by Alembic.
|
||||
revision: str = "0010_add_profile_tables"
|
||||
down_revision: Union[str, None] = "0009_add_group_tables"
|
||||
branch_labels: Union[str, Sequence[str], None] = None
|
||||
depends_on: Union[str, Sequence[str], None] = None
|
||||
|
||||
|
||||
def upgrade() -> None:
|
||||
op.create_table(
|
||||
"profiles",
|
||||
sa.Column("user_id", sa.Integer(), sa.ForeignKey("users.id", ondelete="CASCADE"), primary_key=True),
|
||||
sa.Column(
|
||||
"avatar_asset_id",
|
||||
sa.Integer(),
|
||||
sa.ForeignKey("assets.id", ondelete="SET NULL"),
|
||||
nullable=True,
|
||||
),
|
||||
sa.Column("bio", sa.Text(), nullable=True),
|
||||
sa.Column("privacy_json", postgresql.JSONB(), nullable=False, server_default="{}"),
|
||||
sa.Column("created_at", sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=False),
|
||||
sa.Column("updated_at", sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=False),
|
||||
)
|
||||
op.create_index("ix_profiles_avatar_asset_id", "profiles", ["avatar_asset_id"])
|
||||
|
||||
op.create_table(
|
||||
"profile_favorites",
|
||||
sa.Column(
|
||||
"user_id",
|
||||
sa.Integer(),
|
||||
sa.ForeignKey("users.id", ondelete="CASCADE"),
|
||||
primary_key=True,
|
||||
),
|
||||
sa.Column(
|
||||
"world_id",
|
||||
sa.Integer(),
|
||||
sa.ForeignKey("worlds.id", ondelete="CASCADE"),
|
||||
primary_key=True,
|
||||
),
|
||||
sa.Column("created_at", sa.DateTime(timezone=True), server_default=sa.func.now(), nullable=False),
|
||||
)
|
||||
op.create_index("ix_profile_favorites_world_id", "profile_favorites", ["world_id"])
|
||||
|
||||
|
||||
def downgrade() -> None:
|
||||
op.drop_index("ix_profile_favorites_world_id", table_name="profile_favorites")
|
||||
op.drop_table("profile_favorites")
|
||||
|
||||
op.drop_index("ix_profiles_avatar_asset_id", table_name="profiles")
|
||||
op.drop_table("profiles")
|
||||
@@ -0,0 +1,36 @@
|
||||
"""add last_read_at to conversation_participants (DM unread tracking)
|
||||
|
||||
Revision ID: 0011_add_dm_last_read
|
||||
Revises: 0010_add_profile_tables
|
||||
Create Date: 2026-09-15 00:00:00.000000
|
||||
|
||||
app/routers/chat_dm.py (DM send/list/conversations endpoints). Unread-count
|
||||
tracking is implemented as a last-read timestamp per participant: whenever a
|
||||
user fetches a conversation's message history, their
|
||||
``conversation_participants`` row's ``last_read_at`` is bumped to "now", and
|
||||
the conversation-list endpoint counts messages with
|
||||
``created_at > last_read_at`` (or all messages if never read) as unread for
|
||||
that participant. Nullable/no default so existing rows (none yet in
|
||||
practice, but consistent with "never read") read as "everything unread".
|
||||
"""
|
||||
from typing import Sequence, Union
|
||||
|
||||
from alembic import op
|
||||
import sqlalchemy as sa
|
||||
|
||||
# revision identifiers, used by Alembic.
|
||||
revision: str = "0011_add_dm_last_read"
|
||||
down_revision: Union[str, None] = "0010_add_profile_tables"
|
||||
branch_labels: Union[str, Sequence[str], None] = None
|
||||
depends_on: Union[str, Sequence[str], None] = None
|
||||
|
||||
|
||||
def upgrade() -> None:
|
||||
op.add_column(
|
||||
"conversation_participants",
|
||||
sa.Column("last_read_at", sa.DateTime(timezone=True), nullable=True),
|
||||
)
|
||||
|
||||
|
||||
def downgrade() -> None:
|
||||
op.drop_column("conversation_participants", "last_read_at")
|
||||
+5
-1
@@ -6,7 +6,7 @@ from fastapi import FastAPI
|
||||
from fastapi.middleware.cors import CORSMiddleware
|
||||
|
||||
from app.config import settings
|
||||
from app.routers import auth, users, worlds, assets, avatar, world_content, internal, presence
|
||||
from app.routers import auth, users, worlds, assets, avatar, world_content, internal, presence, groups, social_friends, profiles, chat_dm
|
||||
|
||||
|
||||
from app.services.game_servers import supervisor
|
||||
@@ -45,6 +45,10 @@ app.include_router(assets.router, prefix="/api/assets", tags=["assets"])
|
||||
app.include_router(avatar.router, prefix="/api/avatar", tags=["avatar"])
|
||||
app.include_router(internal.router, prefix="/api/internal", tags=["internal"])
|
||||
app.include_router(presence.router, prefix="/api/presence", tags=["presence"])
|
||||
app.include_router(groups.router, prefix="/api/groups", tags=["groups"])
|
||||
app.include_router(social_friends.router, prefix="/api/friends", tags=["friends"])
|
||||
app.include_router(profiles.router, prefix="/api/profile", tags=["profile"])
|
||||
app.include_router(chat_dm.router, prefix="/api/chat/dm", tags=["chat-dm"])
|
||||
|
||||
|
||||
@app.get("/api/health")
|
||||
|
||||
@@ -9,6 +9,7 @@ from app.models.chat import (
|
||||
Conversation, ConversationParticipant, Message, MessageReport, ReportStatus,
|
||||
)
|
||||
from app.models.groups import Group, GroupMember, GroupRole
|
||||
from app.models.profile import Profile, ProfileFavorite, ProfileVisibility
|
||||
|
||||
__all__ = [
|
||||
"User", "Session", "World", "Asset", "AvatarLoadout",
|
||||
@@ -16,4 +17,5 @@ __all__ = [
|
||||
"Friendship", "Follow", "Block", "FriendshipStatus",
|
||||
"Conversation", "ConversationParticipant", "Message", "MessageReport", "ReportStatus",
|
||||
"Group", "GroupMember", "GroupRole",
|
||||
"Profile", "ProfileFavorite", "ProfileVisibility",
|
||||
]
|
||||
|
||||
@@ -23,7 +23,12 @@ class Asset(Base):
|
||||
name = Column(String(255), nullable=False)
|
||||
description = Column(Text, nullable=True)
|
||||
asset_type = Column(
|
||||
ENUM(AssetType, name="asset_type", create_type=False),
|
||||
ENUM(
|
||||
AssetType,
|
||||
name="asset_type",
|
||||
create_type=False,
|
||||
values_callable=lambda enum_cls: [e.value for e in enum_cls],
|
||||
),
|
||||
nullable=False,
|
||||
)
|
||||
file_path = Column(String(512), nullable=False)
|
||||
|
||||
@@ -121,6 +121,10 @@ class ConversationParticipant(Base):
|
||||
Integer, ForeignKey("users.id", ondelete="CASCADE"), nullable=False, index=True
|
||||
)
|
||||
created_at = Column(DateTime(timezone=True), server_default=func.now(), nullable=False)
|
||||
# DM unread tracking (app/routers/chat_dm.py, migration 0010): bumped to
|
||||
# "now" whenever this participant fetches the conversation's history.
|
||||
# Null means "never read" -- everything in the conversation is unread.
|
||||
last_read_at = Column(DateTime(timezone=True), nullable=True)
|
||||
|
||||
conversation = relationship("Conversation", back_populates="participants")
|
||||
user = relationship("User")
|
||||
|
||||
@@ -0,0 +1,129 @@
|
||||
"""User profile: bio, avatar reference, privacy settings, favorite worlds.
|
||||
|
||||
This module is models + migration only -- the public profile view endpoint
|
||||
(``GET /api/profile/{user_id}``, which will need to interpret ``privacy_json``
|
||||
against the viewer's relationship to the owner) belongs to a sibling task
|
||||
that depends on this one. This task only owns the authenticated-owner
|
||||
read/write endpoints (``/api/profile/me`` and its ``favorites`` sub-resource).
|
||||
|
||||
Design choices:
|
||||
|
||||
- ``profiles.user_id`` is both the primary key and the FK to ``users.id``
|
||||
(``ondelete="CASCADE"``) -- exactly one profile row per user, following the
|
||||
same one-row-per-user shape as ``AvatarLoadout`` (app/models/avatar_loadout.py).
|
||||
The row is created lazily (upserted) on first ``PUT /api/profile/me``
|
||||
rather than at registration time, again mirroring ``AvatarLoadout``.
|
||||
- ``avatar_asset_id`` -> ``assets.id`` with ``ondelete="SET NULL"``. A
|
||||
profile's chosen "avatar picture" asset is a soft reference: if the
|
||||
underlying asset is later deleted the profile shouldn't be destroyed or
|
||||
left pointing at a dangling id, it should just fall back to "no avatar
|
||||
picture set" (nullable). The API layer additionally validates on write
|
||||
that the referenced asset actually exists (existence is not enforced by
|
||||
the FK alone at the API layer, since the FK only stops inserts of a
|
||||
nonexistent id -- it doesn't tell the caller *why* their PUT failed).
|
||||
- ``bio`` is ``Text`` with the 500-char cap enforced at the API/schema layer
|
||||
(Pydantic ``max_length``), matching how ``StatusUpdate.status_message`` in
|
||||
presence.py enforces its length cap in the router rather than the schema.
|
||||
- ``privacy_json`` is JSONB (project convention for document-shaped fields --
|
||||
see avatar_loadout.py, world_content.py) holding exactly three keys, each a
|
||||
``ProfileVisibility`` enum value (stored as its string value in JSON, not a
|
||||
Postgres ENUM type -- there's no need for a DB-level enum since this is a
|
||||
small, entirely API-validated document, and a plain JSONB column is easier
|
||||
to extend with more privacy keys later without a migration):
|
||||
- ``profile_visibility``: who can view the profile at all.
|
||||
- ``friends_list_visibility``: who can see the user's friends list.
|
||||
- ``favorites_visibility``: who can see the user's favorited worlds.
|
||||
Each value is one of "public", "friends", "private". Defaults (applied when
|
||||
a profile is first created) are all "public" -- the least surprising
|
||||
default for a new social feature, matching the "everything visible unless
|
||||
you lock it down" posture other social features here take by default
|
||||
(e.g. presence/status has no privacy gate at all yet).
|
||||
- Favorites use a join table (``profile_favorites``: ``user_id`` + ``world_id``,
|
||||
composite PK) rather than a JSON array column. A plain FK join table gets
|
||||
referential integrity for free (a favorited world that's later deleted
|
||||
disappears from favorites automatically via ON DELETE CASCADE, matching
|
||||
how ``World.assets``/``World.rooms`` cascade), lets Postgres enforce
|
||||
"no duplicate favorite" via the composite PK instead of API-layer
|
||||
deduplication, and keeps "does this world still exist" as a DB invariant
|
||||
rather than something every reader has to re-check against a JSON blob.
|
||||
The tradeoff (an extra table/join vs. a single JSON column) is worth it
|
||||
here because favorites are a list of foreign-key references, not a
|
||||
free-form document -- the exact case join tables suit better than JSONB.
|
||||
"""
|
||||
import enum
|
||||
|
||||
from sqlalchemy import Column, Integer, ForeignKey, Text, DateTime
|
||||
from sqlalchemy.dialects.postgresql import JSONB
|
||||
from sqlalchemy.orm import relationship
|
||||
from sqlalchemy.sql import func
|
||||
|
||||
from app.database import Base
|
||||
|
||||
|
||||
class ProfileVisibility(str, enum.Enum):
|
||||
PUBLIC = "public"
|
||||
FRIENDS = "friends"
|
||||
PRIVATE = "private"
|
||||
|
||||
|
||||
# Applied when a profile is created for the first time (lazy upsert on the
|
||||
# first PUT /api/profile/me). Keys match the three privacy_json fields
|
||||
# documented above.
|
||||
DEFAULT_PRIVACY: dict = {
|
||||
"profile_visibility": ProfileVisibility.PUBLIC.value,
|
||||
"friends_list_visibility": ProfileVisibility.PUBLIC.value,
|
||||
"favorites_visibility": ProfileVisibility.PUBLIC.value,
|
||||
}
|
||||
|
||||
BIO_MAX_LEN = 500
|
||||
|
||||
|
||||
class Profile(Base):
|
||||
"""One row per user: bio, avatar picture reference, privacy settings."""
|
||||
|
||||
__tablename__ = "profiles"
|
||||
|
||||
user_id = Column(
|
||||
Integer,
|
||||
ForeignKey("users.id", ondelete="CASCADE"),
|
||||
primary_key=True,
|
||||
)
|
||||
avatar_asset_id = Column(
|
||||
Integer,
|
||||
ForeignKey("assets.id", ondelete="SET NULL"),
|
||||
nullable=True,
|
||||
)
|
||||
bio = Column(Text, nullable=True)
|
||||
privacy_json = Column(JSONB, nullable=False, server_default="{}")
|
||||
created_at = Column(DateTime(timezone=True), server_default=func.now(), nullable=False)
|
||||
updated_at = Column(DateTime(timezone=True), server_default=func.now(), onupdate=func.now(), nullable=False)
|
||||
|
||||
user = relationship("User", back_populates="profile")
|
||||
avatar_asset = relationship("Asset")
|
||||
# Deliberately no ORM relationship to ProfileFavorite here: profiles and
|
||||
# profile_favorites both independently FK users.id (no direct FK between
|
||||
# the two tables), and the router only ever needs to query/replace a
|
||||
# user's favorites by user_id directly -- not traverse it off a loaded
|
||||
# Profile object. Keeping it a plain queryable table avoids a
|
||||
# hand-spelled, easy-to-get-wrong primaryjoin for no real benefit.
|
||||
|
||||
|
||||
class ProfileFavorite(Base):
|
||||
"""A user's favorited world. Composite PK -- see module docstring for why
|
||||
this is a join table rather than a JSON array column."""
|
||||
|
||||
__tablename__ = "profile_favorites"
|
||||
|
||||
user_id = Column(
|
||||
Integer,
|
||||
ForeignKey("users.id", ondelete="CASCADE"),
|
||||
primary_key=True,
|
||||
)
|
||||
world_id = Column(
|
||||
Integer,
|
||||
ForeignKey("worlds.id", ondelete="CASCADE"),
|
||||
primary_key=True,
|
||||
)
|
||||
created_at = Column(DateTime(timezone=True), server_default=func.now(), nullable=False)
|
||||
|
||||
world = relationship("World")
|
||||
@@ -35,6 +35,14 @@ class User(Base):
|
||||
cascade="all, delete-orphan",
|
||||
)
|
||||
|
||||
# Profile (app/models/profile.py): bio/avatar picture/privacy + favorites.
|
||||
profile = relationship(
|
||||
"Profile",
|
||||
back_populates="user",
|
||||
uselist=False,
|
||||
cascade="all, delete-orphan",
|
||||
)
|
||||
|
||||
# Social graph (docs/planning/social.md US-1; app/models/social.py)
|
||||
sent_friend_requests = relationship(
|
||||
"Friendship",
|
||||
|
||||
@@ -54,6 +54,12 @@ def _client_key(request: Request) -> str:
|
||||
# brute-forcer.
|
||||
_auth_limiter = SlidingWindowLimiter(max_hits=10, window_seconds=60)
|
||||
|
||||
# Every limiter in the process -- named limits built via `rate_limit()`
|
||||
# below register themselves here too, so `reset_all()` (the test hook) and
|
||||
# any future process-wide accounting stay correct without each caller
|
||||
# having to remember to wire it up.
|
||||
_registered_limiters: list[SlidingWindowLimiter] = [_auth_limiter]
|
||||
|
||||
|
||||
async def auth_rate_limit(request: Request) -> None:
|
||||
"""FastAPI dependency: rate-limit auth attempts per client IP.
|
||||
@@ -68,6 +74,41 @@ async def auth_rate_limit(request: Request) -> None:
|
||||
_auth_limiter.check(f"auth:{_client_key(request)}")
|
||||
|
||||
|
||||
def rate_limit(name: str, *, max_hits: int, window_seconds: float):
|
||||
"""Build a named, per-client-IP FastAPI rate-limit dependency.
|
||||
|
||||
Generalizes the ``auth_rate_limit`` pattern above for other endpoints
|
||||
(e.g. chat send, message report) that want their own independent cap:
|
||||
|
||||
report_rate_limit = rate_limit("message_report", max_hits=5, window_seconds=60)
|
||||
|
||||
@router.post("/report", dependencies=[Depends(report_rate_limit)])
|
||||
...
|
||||
|
||||
Each call gets its own ``SlidingWindowLimiter`` -- counters for one
|
||||
named limit never bleed into another, even for the same client IP --
|
||||
and reuses ``SlidingWindowLimiter.check`` for the actual sliding-window
|
||||
accounting and the 429 + ``Retry-After`` response. Like
|
||||
``auth_rate_limit``, the returned dependency is a no-op when
|
||||
``settings.RATE_LIMIT_ENABLED`` is false, so the checkpoint smoke suite
|
||||
(one client IP for the whole run) doesn't trip on it.
|
||||
|
||||
``name`` only needs to be unique within the process; it namespaces the
|
||||
per-IP key so it doesn't collide with ``auth_rate_limit`` or any other
|
||||
named limit.
|
||||
"""
|
||||
limiter = SlidingWindowLimiter(max_hits=max_hits, window_seconds=window_seconds)
|
||||
_registered_limiters.append(limiter)
|
||||
|
||||
async def _dependency(request: Request) -> None:
|
||||
if not settings.RATE_LIMIT_ENABLED:
|
||||
return
|
||||
limiter.check(f"{name}:{_client_key(request)}")
|
||||
|
||||
return _dependency
|
||||
|
||||
|
||||
def reset_all() -> None:
|
||||
"""Test hook."""
|
||||
_auth_limiter.reset()
|
||||
for limiter in _registered_limiters:
|
||||
limiter.reset()
|
||||
|
||||
@@ -0,0 +1,396 @@
|
||||
"""Direct-message (DM) chat router.
|
||||
|
||||
docs/planning/social.md §4/§5 (US-4). Builds the send/list REST surface on
|
||||
top of ``app/models/chat.py`` (Conversation/ConversationParticipant/Message,
|
||||
already merged), ``app/services/text_filter.py`` (already merged), and
|
||||
``app/rate_limit.py`` (already merged).
|
||||
|
||||
Endpoints:
|
||||
- POST /api/chat/dm/{user_id}/messages -- send a DM to ``user_id``
|
||||
- GET /api/chat/dm/{user_id}/messages -- paginated history with ``user_id``
|
||||
- GET /api/chat/dm/conversations -- list the caller's conversations
|
||||
|
||||
Scope/boundaries (per task): REST send/list only, no WebSocket/real-time
|
||||
delivery (separate task), no world/room chat (separate sibling task; that
|
||||
uses the same ``Message`` table but with ``world_id``/``room_id`` set and
|
||||
``conversation_id`` null).
|
||||
|
||||
Design decisions this task owns:
|
||||
|
||||
- **Blocking.** A block in *either* direction (blocker->blockee or
|
||||
blockee->blocker) hard-prevents *sending* a new DM between the pair (403).
|
||||
It does not hide history the pair already has -- ``GET .../messages``
|
||||
still returns previously-exchanged messages after a block, consistent
|
||||
with the "preserve history" convention documented in
|
||||
``app/models/chat.py``'s module docstring. Only sending is blocked.
|
||||
- **Text filtering.** Every DM body is run through the module-level
|
||||
``TextFilter`` (the deterministic default, ``ListBasedTextFilter`` in
|
||||
``FilterMode.REDACT``) before storing:
|
||||
- ALLOW -> store the body as-is, ``filtered=False``.
|
||||
- REDACT -> store ``filtered_text`` (matched spans starred out),
|
||||
``filtered=True``.
|
||||
- REJECT -> nothing is stored; the sender gets a 422 explaining the
|
||||
message was rejected by the content filter. (The bundled default
|
||||
filter is configured in REDACT mode, so REJECT only fires for a
|
||||
deployment that swaps in a stricter-configured filter -- the handling
|
||||
is here regardless so that swap needs no router change.)
|
||||
- **Rate limiting.** Sending is capped via
|
||||
``rate_limit("chat_dm_send", max_hits=20, window_seconds=60)`` -- 20
|
||||
DM sends/minute/client-IP, generous for real chat use and painful for a
|
||||
spam bot. A no-op when ``settings.RATE_LIMIT_ENABLED`` is false (see
|
||||
``app/rate_limit.py``), matching every other rate-limited endpoint.
|
||||
- **Unread tracking.** A last-read timestamp per participant
|
||||
(``ConversationParticipant.last_read_at``, migration 0010). Fetching a
|
||||
conversation's *latest* page of history (``GET .../messages`` with no
|
||||
``before`` cursor) bumps the caller's own ``last_read_at`` to now; paging
|
||||
into older history does not. ``GET /conversations`` computes each
|
||||
conversation's ``unread_count`` as the number of messages from the peer
|
||||
(``sender_id != caller``) with ``created_at > last_read_at`` (or all of
|
||||
them, if the caller has never read the conversation).
|
||||
- **Pagination.**
|
||||
- History (``GET {user_id}/messages``): cursor-based, newest-first.
|
||||
``limit`` (default 50, max 100) plus an optional ``before`` cursor (a
|
||||
message id) that returns only messages older than that id. Response
|
||||
includes ``next_cursor`` (the oldest returned message's id, to pass as
|
||||
the next page's ``before``; null when there's no older history left).
|
||||
- Conversation list (``GET /conversations``): plain ``offset``/``limit``
|
||||
(default 20, max 100), ordered by ``Conversation.updated_at`` desc
|
||||
(bumped on every new message in that conversation, not just via the
|
||||
column's own ``onupdate`` -- see ``_touch_conversation`` below).
|
||||
- Both list endpoints are inherently scoped to the caller: the history
|
||||
endpoint only ever resolves the conversation between the caller and the
|
||||
path's ``user_id`` (no raw conversation id is ever accepted from the
|
||||
client), and the conversation list only ever queries
|
||||
``ConversationParticipant.user_id == caller``. There is no way for a
|
||||
client to address another pair's conversation.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from datetime import datetime, timezone
|
||||
from typing import Annotated
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, Query, status
|
||||
from pydantic import BaseModel, Field
|
||||
from sqlalchemy import and_, func, or_, select
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.database import get_db
|
||||
from app.dependencies import CurrentUser
|
||||
from app.models.chat import Conversation, ConversationParticipant, Message
|
||||
from app.models.social import Block
|
||||
from app.models.user import User
|
||||
from app.rate_limit import rate_limit
|
||||
from app.services.text_filter import FilterAction, default_text_filter
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
DbDep = Annotated[AsyncSession, Depends(get_db)]
|
||||
|
||||
_text_filter = default_text_filter()
|
||||
chat_dm_send_rate_limit = rate_limit("chat_dm_send", max_hits=20, window_seconds=60)
|
||||
|
||||
_BODY_MAX_LEN = 4000
|
||||
|
||||
# ──────────────────────────── Pydantic schemas ────────────────────────────
|
||||
|
||||
|
||||
class SendDMRequest(BaseModel):
|
||||
body: str = Field(..., min_length=1, max_length=_BODY_MAX_LEN)
|
||||
|
||||
|
||||
class DMMessageResponse(BaseModel):
|
||||
id: int
|
||||
conversation_id: int
|
||||
sender_id: int
|
||||
recipient_id: int
|
||||
body: str
|
||||
filtered: bool
|
||||
created_at: datetime
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class DMMessageListResponse(BaseModel):
|
||||
messages: list[DMMessageResponse]
|
||||
next_cursor: int | None = None
|
||||
|
||||
|
||||
class DMConversationSummary(BaseModel):
|
||||
conversation_id: int
|
||||
peer_id: int
|
||||
peer_username: str
|
||||
last_message: DMMessageResponse | None
|
||||
unread_count: int
|
||||
updated_at: datetime
|
||||
|
||||
|
||||
class DMConversationListResponse(BaseModel):
|
||||
conversations: list[DMConversationSummary]
|
||||
total: int
|
||||
|
||||
|
||||
# ──────────────────────────────── Helpers ──────────────────────────────────
|
||||
|
||||
|
||||
async def _get_target_user(db: AsyncSession, user_id: int) -> User:
|
||||
result = await db.execute(select(User).where(User.id == user_id))
|
||||
user = result.scalar_one_or_none()
|
||||
if user is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="User not found")
|
||||
return user
|
||||
|
||||
|
||||
async def _is_blocked_either_direction(db: AsyncSession, user_a: int, user_b: int) -> bool:
|
||||
result = await db.execute(
|
||||
select(Block.id).where(
|
||||
or_(
|
||||
and_(Block.blocker_id == user_a, Block.blocked_id == user_b),
|
||||
and_(Block.blocker_id == user_b, Block.blocked_id == user_a),
|
||||
)
|
||||
).limit(1)
|
||||
)
|
||||
return result.scalar_one_or_none() is not None
|
||||
|
||||
|
||||
async def _get_or_create_conversation(
|
||||
db: AsyncSession, user_a_id: int, user_b_id: int
|
||||
) -> Conversation:
|
||||
lo, hi = sorted((user_a_id, user_b_id))
|
||||
result = await db.execute(
|
||||
select(Conversation).where(
|
||||
Conversation.user_a_id == lo, Conversation.user_b_id == hi
|
||||
)
|
||||
)
|
||||
conversation = result.scalar_one_or_none()
|
||||
if conversation is not None:
|
||||
return conversation
|
||||
|
||||
conversation = Conversation(user_a_id=lo, user_b_id=hi)
|
||||
db.add(conversation)
|
||||
await db.flush() # assign conversation.id
|
||||
db.add(ConversationParticipant(conversation_id=conversation.id, user_id=lo))
|
||||
db.add(ConversationParticipant(conversation_id=conversation.id, user_id=hi))
|
||||
await db.flush()
|
||||
return conversation
|
||||
|
||||
|
||||
async def _get_participant(
|
||||
db: AsyncSession, conversation_id: int, user_id: int
|
||||
) -> ConversationParticipant | None:
|
||||
result = await db.execute(
|
||||
select(ConversationParticipant).where(
|
||||
ConversationParticipant.conversation_id == conversation_id,
|
||||
ConversationParticipant.user_id == user_id,
|
||||
)
|
||||
)
|
||||
return result.scalar_one_or_none()
|
||||
|
||||
|
||||
def _peer_id(conversation: Conversation, self_id: int) -> int:
|
||||
return conversation.user_b_id if conversation.user_a_id == self_id else conversation.user_a_id
|
||||
|
||||
|
||||
def _touch_conversation(conversation: Conversation) -> None:
|
||||
"""Bump ``updated_at`` explicitly.
|
||||
|
||||
``Conversation.updated_at`` has ``onupdate=func.now()``, but that only
|
||||
fires when an UPDATE statement touches the ``conversations`` row itself
|
||||
-- inserting a ``Message`` row alone never does. Explicitly dirtying the
|
||||
column here is what actually keeps "most recently active conversation"
|
||||
ordering correct for ``GET /conversations``.
|
||||
"""
|
||||
conversation.updated_at = datetime.now(timezone.utc)
|
||||
|
||||
|
||||
def _to_message_response(message: Message, recipient_id: int) -> DMMessageResponse:
|
||||
return DMMessageResponse(
|
||||
id=message.id,
|
||||
conversation_id=message.conversation_id,
|
||||
sender_id=message.sender_id,
|
||||
recipient_id=recipient_id,
|
||||
body=message.body,
|
||||
filtered=message.filtered,
|
||||
created_at=message.created_at,
|
||||
)
|
||||
|
||||
|
||||
# ──────────────────────────────── Endpoints ────────────────────────────────
|
||||
|
||||
|
||||
@router.post(
|
||||
"/{user_id}/messages",
|
||||
response_model=DMMessageResponse,
|
||||
status_code=status.HTTP_201_CREATED,
|
||||
dependencies=[Depends(chat_dm_send_rate_limit)],
|
||||
)
|
||||
async def send_dm(
|
||||
user_id: int,
|
||||
body: SendDMRequest,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Send a DM to ``user_id``."""
|
||||
if user_id == current_user.id:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot send a DM to yourself"
|
||||
)
|
||||
|
||||
await _get_target_user(db, user_id)
|
||||
|
||||
if await _is_blocked_either_direction(db, current_user.id, user_id):
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Cannot message this user",
|
||||
)
|
||||
|
||||
result = _text_filter.check(body.body)
|
||||
if result.action is FilterAction.REJECT:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
|
||||
detail="Message rejected by the content filter.",
|
||||
)
|
||||
|
||||
conversation = await _get_or_create_conversation(db, current_user.id, user_id)
|
||||
|
||||
message = Message(
|
||||
sender_id=current_user.id,
|
||||
conversation_id=conversation.id,
|
||||
body=result.filtered_text,
|
||||
filtered=(result.action is FilterAction.REDACT),
|
||||
)
|
||||
db.add(message)
|
||||
_touch_conversation(conversation)
|
||||
await db.commit()
|
||||
await db.refresh(message)
|
||||
|
||||
return _to_message_response(message, recipient_id=user_id)
|
||||
|
||||
|
||||
@router.get("/{user_id}/messages", response_model=DMMessageListResponse)
|
||||
async def get_dm_history(
|
||||
user_id: int,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
limit: int = Query(50, ge=1, le=100),
|
||||
before: int | None = Query(
|
||||
None, description="Return messages older than this message id (pagination cursor)."
|
||||
),
|
||||
):
|
||||
"""Paginated DM history between the caller and ``user_id``, newest first.
|
||||
|
||||
Marks the conversation as read (bumps the caller's ``last_read_at``) only
|
||||
when fetching the first page (``before`` omitted) -- paging into older
|
||||
history doesn't affect unread state.
|
||||
"""
|
||||
await _get_target_user(db, user_id)
|
||||
|
||||
lo, hi = sorted((current_user.id, user_id))
|
||||
conv_result = await db.execute(
|
||||
select(Conversation).where(Conversation.user_a_id == lo, Conversation.user_b_id == hi)
|
||||
)
|
||||
conversation = conv_result.scalar_one_or_none()
|
||||
if conversation is None:
|
||||
# No conversation yet -- nothing exchanged, not an error.
|
||||
return DMMessageListResponse(messages=[], next_cursor=None)
|
||||
|
||||
stmt = select(Message).where(Message.conversation_id == conversation.id)
|
||||
if before is not None:
|
||||
stmt = stmt.where(Message.id < before)
|
||||
stmt = stmt.order_by(Message.id.desc()).limit(limit + 1)
|
||||
|
||||
rows = (await db.execute(stmt)).scalars().all()
|
||||
has_more = len(rows) > limit
|
||||
page = rows[:limit]
|
||||
next_cursor = page[-1].id if has_more and page else None
|
||||
|
||||
if before is None:
|
||||
participant = await _get_participant(db, conversation.id, current_user.id)
|
||||
if participant is not None:
|
||||
participant.last_read_at = datetime.now(timezone.utc)
|
||||
await db.commit()
|
||||
|
||||
return DMMessageListResponse(
|
||||
messages=[_to_message_response(m, recipient_id=user_id) for m in page],
|
||||
next_cursor=next_cursor,
|
||||
)
|
||||
|
||||
|
||||
@router.get("/conversations", response_model=DMConversationListResponse)
|
||||
async def list_conversations(
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
limit: int = Query(20, ge=1, le=100),
|
||||
offset: int = Query(0, ge=0),
|
||||
):
|
||||
"""List the caller's DM conversations, most recently active first."""
|
||||
total_result = await db.execute(
|
||||
select(func.count())
|
||||
.select_from(ConversationParticipant)
|
||||
.where(ConversationParticipant.user_id == current_user.id)
|
||||
)
|
||||
total = total_result.scalar_one()
|
||||
|
||||
stmt = (
|
||||
select(Conversation, ConversationParticipant)
|
||||
.join(
|
||||
ConversationParticipant,
|
||||
ConversationParticipant.conversation_id == Conversation.id,
|
||||
)
|
||||
.where(ConversationParticipant.user_id == current_user.id)
|
||||
.order_by(Conversation.updated_at.desc())
|
||||
.offset(offset)
|
||||
.limit(limit)
|
||||
)
|
||||
rows = (await db.execute(stmt)).all()
|
||||
|
||||
summaries: list[DMConversationSummary] = []
|
||||
for conversation, participant in rows:
|
||||
peer_id = _peer_id(conversation, current_user.id)
|
||||
|
||||
peer = (
|
||||
await db.execute(select(User).where(User.id == peer_id))
|
||||
).scalar_one_or_none()
|
||||
peer_username = peer.username if peer is not None else "(deleted user)"
|
||||
|
||||
last_message_row = (
|
||||
await db.execute(
|
||||
select(Message)
|
||||
.where(Message.conversation_id == conversation.id)
|
||||
.order_by(Message.id.desc())
|
||||
.limit(1)
|
||||
)
|
||||
).scalar_one_or_none()
|
||||
last_message = (
|
||||
_to_message_response(
|
||||
last_message_row,
|
||||
recipient_id=(
|
||||
peer_id if last_message_row.sender_id == current_user.id else current_user.id
|
||||
),
|
||||
)
|
||||
if last_message_row is not None
|
||||
else None
|
||||
)
|
||||
|
||||
unread_filters = [
|
||||
Message.conversation_id == conversation.id,
|
||||
Message.sender_id != current_user.id,
|
||||
]
|
||||
if participant.last_read_at is not None:
|
||||
unread_filters.append(Message.created_at > participant.last_read_at)
|
||||
unread_count = (
|
||||
await db.execute(select(func.count()).select_from(Message).where(*unread_filters))
|
||||
).scalar_one()
|
||||
|
||||
summaries.append(
|
||||
DMConversationSummary(
|
||||
conversation_id=conversation.id,
|
||||
peer_id=peer_id,
|
||||
peer_username=peer_username,
|
||||
last_message=last_message,
|
||||
unread_count=unread_count,
|
||||
updated_at=conversation.updated_at,
|
||||
)
|
||||
)
|
||||
|
||||
return DMConversationListResponse(conversations=summaries, total=total)
|
||||
@@ -0,0 +1,465 @@
|
||||
"""Groups API router.
|
||||
|
||||
Endpoints:
|
||||
- POST /api/groups -- create (creator becomes owner)
|
||||
- GET /api/groups -- list groups (paginated), optional mine=true
|
||||
- GET /api/groups/{id} -- group page (name/description/members)
|
||||
- PATCH /api/groups/{id} -- update name/description (owner/admin)
|
||||
- DELETE /api/groups/{id} -- delete (owner only)
|
||||
- POST /api/groups/{id}/join -- join (idempotent)
|
||||
- POST /api/groups/{id}/leave -- leave (owner must transfer first)
|
||||
- POST /api/groups/{id}/members/{user_id}/role -- set role admin/member (owner only)
|
||||
- POST /api/groups/{id}/transfer -- transfer ownership (owner only)
|
||||
|
||||
See app/models/groups.py for the schema and delete-behavior rationale
|
||||
(docs/planning/social.md US-5). This module owns create/join/leave, role
|
||||
authorization, and the group page aggregate.
|
||||
"""
|
||||
|
||||
from datetime import datetime
|
||||
from typing import Annotated
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException, Query, status
|
||||
from pydantic import BaseModel, Field, field_validator
|
||||
from sqlalchemy import func, select
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.database import get_db
|
||||
from app.dependencies import CurrentUser
|
||||
from app.models.groups import Group, GroupMember, GroupRole
|
||||
from app.models.user import User
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
DbDep = Annotated[AsyncSession, Depends(get_db)]
|
||||
|
||||
_NAME_MAX_LEN = 100
|
||||
_DESCRIPTION_MAX_LEN = 2000
|
||||
|
||||
|
||||
# ──────────────────────────── Pydantic schemas ────────────────────────────────
|
||||
|
||||
|
||||
class GroupCreate(BaseModel):
|
||||
name: str = Field(..., min_length=1, max_length=_NAME_MAX_LEN)
|
||||
description: str | None = Field(default=None, max_length=_DESCRIPTION_MAX_LEN)
|
||||
|
||||
@field_validator("name")
|
||||
@classmethod
|
||||
def strip_name(cls, v: str) -> str:
|
||||
v = v.strip()
|
||||
if not v:
|
||||
raise ValueError("name must not be blank")
|
||||
return v
|
||||
|
||||
@field_validator("description")
|
||||
@classmethod
|
||||
def strip_description(cls, v: str | None) -> str | None:
|
||||
if v is not None:
|
||||
v = v.strip() or None
|
||||
return v
|
||||
|
||||
|
||||
class GroupUpdate(BaseModel):
|
||||
name: str | None = Field(default=None, min_length=1, max_length=_NAME_MAX_LEN)
|
||||
description: str | None = Field(default=None, max_length=_DESCRIPTION_MAX_LEN)
|
||||
|
||||
@field_validator("name")
|
||||
@classmethod
|
||||
def strip_name(cls, v: str | None) -> str | None:
|
||||
if v is not None:
|
||||
v = v.strip()
|
||||
if not v:
|
||||
raise ValueError("name must not be blank")
|
||||
return v
|
||||
|
||||
@field_validator("description")
|
||||
@classmethod
|
||||
def strip_description(cls, v: str | None) -> str | None:
|
||||
if v is not None:
|
||||
v = v.strip() or None
|
||||
return v
|
||||
|
||||
|
||||
class GroupSummary(BaseModel):
|
||||
id: int
|
||||
name: str
|
||||
description: str | None
|
||||
owner_id: int | None
|
||||
member_count: int
|
||||
created_at: datetime
|
||||
|
||||
|
||||
class GroupListResponse(BaseModel):
|
||||
groups: list[GroupSummary]
|
||||
total: int
|
||||
|
||||
|
||||
class GroupMemberOut(BaseModel):
|
||||
"""Public-safe member entry -- no email or other private User fields."""
|
||||
|
||||
user_id: int
|
||||
username: str
|
||||
role: GroupRole
|
||||
joined_at: datetime
|
||||
|
||||
|
||||
class GroupDetail(BaseModel):
|
||||
id: int
|
||||
name: str
|
||||
description: str | None
|
||||
owner_id: int | None
|
||||
member_count: int
|
||||
members: list[GroupMemberOut]
|
||||
created_at: datetime
|
||||
|
||||
|
||||
class RoleUpdateRequest(BaseModel):
|
||||
role: GroupRole
|
||||
|
||||
@field_validator("role")
|
||||
@classmethod
|
||||
def only_admin_or_member(cls, v: GroupRole) -> GroupRole:
|
||||
if v == GroupRole.OWNER:
|
||||
raise ValueError(
|
||||
"cannot set role to owner directly -- use POST /transfer"
|
||||
)
|
||||
return v
|
||||
|
||||
|
||||
class TransferRequest(BaseModel):
|
||||
new_owner_id: int
|
||||
|
||||
|
||||
class MembershipOut(BaseModel):
|
||||
group_id: int
|
||||
user_id: int
|
||||
role: GroupRole
|
||||
joined_at: datetime
|
||||
|
||||
|
||||
# ──────────────────────────────── Helpers ─────────────────────────────────────
|
||||
|
||||
|
||||
async def _get_group_or_404(db: AsyncSession, group_id: int) -> Group:
|
||||
group = await db.get(Group, group_id)
|
||||
if group is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Group not found")
|
||||
return group
|
||||
|
||||
|
||||
async def _get_membership(db: AsyncSession, group_id: int, user_id: int) -> GroupMember | None:
|
||||
result = await db.execute(
|
||||
select(GroupMember).where(
|
||||
GroupMember.group_id == group_id, GroupMember.user_id == user_id
|
||||
)
|
||||
)
|
||||
return result.scalar_one_or_none()
|
||||
|
||||
|
||||
async def _member_count(db: AsyncSession, group_id: int) -> int:
|
||||
result = await db.execute(
|
||||
select(func.count()).select_from(GroupMember).where(GroupMember.group_id == group_id)
|
||||
)
|
||||
return int(result.scalar_one())
|
||||
|
||||
|
||||
def _require_role(membership: GroupMember | None, *allowed: GroupRole) -> None:
|
||||
if membership is None or membership.role not in allowed:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="You do not have permission to perform this action",
|
||||
)
|
||||
|
||||
|
||||
# ──────────────────────────────── Endpoints ───────────────────────────────────
|
||||
|
||||
|
||||
@router.post("", response_model=GroupDetail, status_code=status.HTTP_201_CREATED)
|
||||
@router.post("/", response_model=GroupDetail, status_code=status.HTTP_201_CREATED, include_in_schema=False)
|
||||
async def create_group(
|
||||
body: GroupCreate,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Create a group. The creator becomes its owner."""
|
||||
group = Group(name=body.name, description=body.description, owner_id=current_user.id)
|
||||
db.add(group)
|
||||
await db.flush()
|
||||
|
||||
db.add(GroupMember(group_id=group.id, user_id=current_user.id, role=GroupRole.OWNER))
|
||||
await db.commit()
|
||||
await db.refresh(group)
|
||||
|
||||
return GroupDetail(
|
||||
id=group.id,
|
||||
name=group.name,
|
||||
description=group.description,
|
||||
owner_id=group.owner_id,
|
||||
member_count=1,
|
||||
members=[
|
||||
GroupMemberOut(
|
||||
user_id=current_user.id,
|
||||
username=current_user.username,
|
||||
role=GroupRole.OWNER,
|
||||
joined_at=group.created_at,
|
||||
)
|
||||
],
|
||||
created_at=group.created_at,
|
||||
)
|
||||
|
||||
|
||||
@router.get("", response_model=GroupListResponse)
|
||||
@router.get("/", response_model=GroupListResponse, include_in_schema=False)
|
||||
async def list_groups(
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
skip: int = Query(0, ge=0),
|
||||
limit: int = Query(50, ge=1, le=100),
|
||||
mine: bool = Query(False, description="If true, only groups the caller is a member of"),
|
||||
):
|
||||
"""List groups, paginated. With ``mine=true``, restrict to the caller's own groups."""
|
||||
base_query = select(Group)
|
||||
count_query = select(func.count()).select_from(Group)
|
||||
|
||||
if mine:
|
||||
base_query = base_query.join(
|
||||
GroupMember, GroupMember.group_id == Group.id
|
||||
).where(GroupMember.user_id == current_user.id)
|
||||
count_query = count_query.join(
|
||||
GroupMember, GroupMember.group_id == Group.id
|
||||
).where(GroupMember.user_id == current_user.id)
|
||||
|
||||
total = (await db.execute(count_query)).scalar_one()
|
||||
|
||||
result = await db.execute(
|
||||
base_query.order_by(Group.created_at.desc()).offset(skip).limit(limit)
|
||||
)
|
||||
groups = result.scalars().all()
|
||||
|
||||
summaries = []
|
||||
for group in groups:
|
||||
summaries.append(
|
||||
GroupSummary(
|
||||
id=group.id,
|
||||
name=group.name,
|
||||
description=group.description,
|
||||
owner_id=group.owner_id,
|
||||
member_count=await _member_count(db, group.id),
|
||||
created_at=group.created_at,
|
||||
)
|
||||
)
|
||||
|
||||
return GroupListResponse(groups=summaries, total=total)
|
||||
|
||||
|
||||
@router.get("/{group_id}", response_model=GroupDetail)
|
||||
async def get_group(
|
||||
group_id: int,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Group page: name, description, member count, and member list with roles."""
|
||||
group = await _get_group_or_404(db, group_id)
|
||||
|
||||
result = await db.execute(
|
||||
select(GroupMember, User.username)
|
||||
.join(User, User.id == GroupMember.user_id)
|
||||
.where(GroupMember.group_id == group_id)
|
||||
.order_by(GroupMember.joined_at.asc())
|
||||
)
|
||||
rows = result.all()
|
||||
|
||||
members = [
|
||||
GroupMemberOut(
|
||||
user_id=gm.user_id,
|
||||
username=username,
|
||||
role=gm.role,
|
||||
joined_at=gm.joined_at,
|
||||
)
|
||||
for gm, username in rows
|
||||
]
|
||||
|
||||
return GroupDetail(
|
||||
id=group.id,
|
||||
name=group.name,
|
||||
description=group.description,
|
||||
owner_id=group.owner_id,
|
||||
member_count=len(members),
|
||||
members=members,
|
||||
created_at=group.created_at,
|
||||
)
|
||||
|
||||
|
||||
@router.patch("/{group_id}", response_model=GroupDetail)
|
||||
async def update_group(
|
||||
group_id: int,
|
||||
body: GroupUpdate,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Update name/description. Owner/admin only."""
|
||||
group = await _get_group_or_404(db, group_id)
|
||||
membership = await _get_membership(db, group_id, current_user.id)
|
||||
_require_role(membership, GroupRole.OWNER, GroupRole.ADMIN)
|
||||
|
||||
if body.name is not None:
|
||||
group.name = body.name
|
||||
if body.description is not None:
|
||||
group.description = body.description if body.description else None
|
||||
|
||||
await db.commit()
|
||||
await db.refresh(group)
|
||||
|
||||
return await get_group(group_id, current_user, db)
|
||||
|
||||
|
||||
@router.delete("/{group_id}", status_code=status.HTTP_204_NO_CONTENT)
|
||||
async def delete_group(
|
||||
group_id: int,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Delete a group. Owner only."""
|
||||
group = await _get_group_or_404(db, group_id)
|
||||
if group.owner_id != current_user.id:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Only the owner can delete this group",
|
||||
)
|
||||
|
||||
await db.delete(group)
|
||||
await db.commit()
|
||||
return None
|
||||
|
||||
|
||||
@router.post("/{group_id}/join", response_model=MembershipOut)
|
||||
async def join_group(
|
||||
group_id: int,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Join a group. Idempotent -- joining an already-joined group is a no-op."""
|
||||
await _get_group_or_404(db, group_id)
|
||||
|
||||
existing = await _get_membership(db, group_id, current_user.id)
|
||||
if existing is not None:
|
||||
return MembershipOut(
|
||||
group_id=group_id,
|
||||
user_id=current_user.id,
|
||||
role=existing.role,
|
||||
joined_at=existing.joined_at,
|
||||
)
|
||||
|
||||
membership = GroupMember(group_id=group_id, user_id=current_user.id, role=GroupRole.MEMBER)
|
||||
db.add(membership)
|
||||
await db.commit()
|
||||
await db.refresh(membership)
|
||||
|
||||
return MembershipOut(
|
||||
group_id=group_id,
|
||||
user_id=current_user.id,
|
||||
role=membership.role,
|
||||
joined_at=membership.joined_at,
|
||||
)
|
||||
|
||||
|
||||
@router.post("/{group_id}/leave", response_model=dict)
|
||||
async def leave_group(
|
||||
group_id: int,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Leave a group. The owner cannot leave without transferring ownership first."""
|
||||
await _get_group_or_404(db, group_id)
|
||||
membership = await _get_membership(db, group_id, current_user.id)
|
||||
if membership is None:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND,
|
||||
detail="You are not a member of this group",
|
||||
)
|
||||
|
||||
if membership.role == GroupRole.OWNER:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_409_CONFLICT,
|
||||
detail="Transfer ownership before leaving this group",
|
||||
)
|
||||
|
||||
await db.delete(membership)
|
||||
await db.commit()
|
||||
return {"status": "ok"}
|
||||
|
||||
|
||||
@router.post("/{group_id}/members/{user_id}/role", response_model=MembershipOut)
|
||||
async def set_member_role(
|
||||
group_id: int,
|
||||
user_id: int,
|
||||
body: RoleUpdateRequest,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Set a member's role (admin/member). Owner only."""
|
||||
group = await _get_group_or_404(db, group_id)
|
||||
if group.owner_id != current_user.id:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Only the owner can change member roles",
|
||||
)
|
||||
|
||||
target = await _get_membership(db, group_id, user_id)
|
||||
if target is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Member not found")
|
||||
|
||||
if target.role == GroupRole.OWNER:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_400_BAD_REQUEST,
|
||||
detail="Use POST /transfer to change ownership",
|
||||
)
|
||||
|
||||
target.role = body.role
|
||||
await db.commit()
|
||||
await db.refresh(target)
|
||||
|
||||
return MembershipOut(
|
||||
group_id=group_id, user_id=user_id, role=target.role, joined_at=target.joined_at
|
||||
)
|
||||
|
||||
|
||||
@router.post("/{group_id}/transfer", response_model=GroupDetail)
|
||||
async def transfer_ownership(
|
||||
group_id: int,
|
||||
body: TransferRequest,
|
||||
current_user: CurrentUser,
|
||||
db: DbDep,
|
||||
):
|
||||
"""Transfer group ownership to another existing member. Owner only."""
|
||||
group = await _get_group_or_404(db, group_id)
|
||||
if group.owner_id != current_user.id:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_403_FORBIDDEN,
|
||||
detail="Only the owner can transfer ownership",
|
||||
)
|
||||
|
||||
if body.new_owner_id == current_user.id:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_400_BAD_REQUEST,
|
||||
detail="You already own this group",
|
||||
)
|
||||
|
||||
new_owner_membership = await _get_membership(db, group_id, body.new_owner_id)
|
||||
if new_owner_membership is None:
|
||||
raise HTTPException(
|
||||
status_code=status.HTTP_404_NOT_FOUND,
|
||||
detail="New owner must already be a member of this group",
|
||||
)
|
||||
|
||||
current_owner_membership = await _get_membership(db, group_id, current_user.id)
|
||||
|
||||
new_owner_membership.role = GroupRole.OWNER
|
||||
if current_owner_membership is not None:
|
||||
current_owner_membership.role = GroupRole.ADMIN
|
||||
group.owner_id = body.new_owner_id
|
||||
|
||||
await db.commit()
|
||||
|
||||
return await get_group(group_id, current_user, db)
|
||||
@@ -0,0 +1,365 @@
|
||||
"""Profile router -- the authenticated user's own profile + favorites.
|
||||
|
||||
Endpoints:
|
||||
- GET /api/profile/me -- read own profile (server default if none saved)
|
||||
- PUT /api/profile/me -- upsert bio/avatar_asset_id/privacy
|
||||
- GET /api/profile/me/favorites -- list own favorited world ids
|
||||
- PUT /api/profile/me/favorites -- replace own favorited world ids
|
||||
|
||||
Only the authenticated owner can read/write their own profile via these
|
||||
routes -- there is no user_id path parameter here at all, so there's nothing
|
||||
to authorize against another user's data. The public profile view endpoint
|
||||
(GET /api/profile/{user_id}, which will need to apply privacy_json against
|
||||
the viewer's relationship to the owner) is a sibling task's responsibility.
|
||||
"""
|
||||
|
||||
from typing import Annotated
|
||||
|
||||
from fastapi import APIRouter, Depends, HTTPException
|
||||
from pydantic import BaseModel, Field, field_validator
|
||||
from sqlalchemy import select, or_, and_
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.database import get_db
|
||||
from app.dependencies import CurrentUser
|
||||
from app.models.asset import Asset
|
||||
from app.models.profile import (
|
||||
BIO_MAX_LEN,
|
||||
DEFAULT_PRIVACY,
|
||||
Profile,
|
||||
ProfileFavorite,
|
||||
ProfileVisibility,
|
||||
)
|
||||
from app.models.social import Friendship, Block, FriendshipStatus
|
||||
from app.models.user import User
|
||||
from app.models.world import World
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
DbDep = Annotated[AsyncSession, Depends(get_db)]
|
||||
|
||||
_PRIVACY_KEYS = ("profile_visibility", "friends_list_visibility", "favorites_visibility")
|
||||
_VISIBILITY_VALUES = {v.value for v in ProfileVisibility}
|
||||
|
||||
|
||||
# ──────────────────────────── Pydantic schemas ────────────────────────────────
|
||||
|
||||
|
||||
class PublicProfileWorld(BaseModel):
|
||||
id: int
|
||||
name: str
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class PublicProfileUser(BaseModel):
|
||||
id: int
|
||||
username: str
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class PublicProfileResponse(BaseModel):
|
||||
user_id: int
|
||||
username: str
|
||||
avatar_asset_id: int | None = None
|
||||
bio: str | None = None
|
||||
favorites: list[PublicProfileWorld] = Field(default_factory=list)
|
||||
friends: list[PublicProfileUser] = Field(default_factory=list)
|
||||
is_restricted: bool = False
|
||||
|
||||
|
||||
class ProfileResponse(BaseModel):
|
||||
user_id: int
|
||||
avatar_asset_id: int | None
|
||||
bio: str | None
|
||||
privacy: dict[str, str]
|
||||
is_default: bool = Field(
|
||||
description="True when the user has never saved a profile and this "
|
||||
"is the server default (no bio/avatar, default-open privacy)."
|
||||
)
|
||||
|
||||
|
||||
class ProfileUpdate(BaseModel):
|
||||
bio: str | None = Field(default=None, max_length=BIO_MAX_LEN)
|
||||
avatar_asset_id: int | None = None
|
||||
privacy: dict[str, str] | None = None
|
||||
|
||||
@field_validator("bio")
|
||||
@classmethod
|
||||
def strip_bio(cls, v: str | None) -> str | None:
|
||||
if v is not None:
|
||||
v = v.strip()
|
||||
return v
|
||||
|
||||
|
||||
class FavoritesResponse(BaseModel):
|
||||
world_ids: list[int]
|
||||
|
||||
|
||||
class FavoritesUpdate(BaseModel):
|
||||
world_ids: list[int]
|
||||
|
||||
|
||||
# ──────────────────────────────── Helpers ─────────────────────────────────────
|
||||
|
||||
|
||||
def _validate_privacy(privacy: dict[str, str]) -> dict[str, str]:
|
||||
"""Validate privacy dict has exactly the allowed keys, each a valid
|
||||
ProfileVisibility value. Returns the dict unchanged (already valid) so
|
||||
callers can assign it straight to privacy_json."""
|
||||
extra = set(privacy.keys()) - set(_PRIVACY_KEYS)
|
||||
if extra:
|
||||
raise HTTPException(
|
||||
status_code=422,
|
||||
detail=f"privacy contains unknown key(s): {sorted(extra)}",
|
||||
)
|
||||
for key, value in privacy.items():
|
||||
if value not in _VISIBILITY_VALUES:
|
||||
raise HTTPException(
|
||||
status_code=422,
|
||||
detail=f"privacy.{key} must be one of {sorted(_VISIBILITY_VALUES)}, got {value!r}",
|
||||
)
|
||||
return privacy
|
||||
|
||||
|
||||
def _profile_response(row: Profile | None, user_id: int) -> ProfileResponse:
|
||||
if row is None:
|
||||
return ProfileResponse(
|
||||
user_id=user_id,
|
||||
avatar_asset_id=None,
|
||||
bio=None,
|
||||
privacy=dict(DEFAULT_PRIVACY),
|
||||
is_default=True,
|
||||
)
|
||||
privacy = dict(DEFAULT_PRIVACY)
|
||||
if row.privacy_json:
|
||||
privacy.update(row.privacy_json)
|
||||
return ProfileResponse(
|
||||
user_id=row.user_id,
|
||||
avatar_asset_id=row.avatar_asset_id,
|
||||
bio=row.bio,
|
||||
privacy=privacy,
|
||||
is_default=False,
|
||||
)
|
||||
|
||||
|
||||
# ──────────────────────────────── Endpoints ───────────────────────────────────
|
||||
|
||||
|
||||
@router.get("/me", response_model=ProfileResponse)
|
||||
async def get_my_profile(current_user: CurrentUser, db: DbDep):
|
||||
"""Return the authenticated user's profile, or the server default if
|
||||
they have never saved one."""
|
||||
row = await db.get(Profile, current_user.id)
|
||||
return _profile_response(row, current_user.id)
|
||||
|
||||
|
||||
@router.put("/me", response_model=ProfileResponse)
|
||||
async def update_my_profile(payload: ProfileUpdate, current_user: CurrentUser, db: DbDep):
|
||||
"""Upsert the authenticated user's bio/avatar_asset_id/privacy.
|
||||
|
||||
Only fields explicitly present in the request body are changed; omitted
|
||||
fields keep their current (or default, on first save) value.
|
||||
"""
|
||||
fields_set = payload.model_fields_set
|
||||
|
||||
if "avatar_asset_id" in fields_set and payload.avatar_asset_id is not None:
|
||||
asset = await db.get(Asset, payload.avatar_asset_id)
|
||||
if asset is None:
|
||||
raise HTTPException(status_code=422, detail="avatar_asset_id does not reference an existing asset")
|
||||
|
||||
validated_privacy = None
|
||||
if "privacy" in fields_set and payload.privacy is not None:
|
||||
validated_privacy = _validate_privacy(payload.privacy)
|
||||
|
||||
row = await db.get(Profile, current_user.id)
|
||||
if row is None:
|
||||
row = Profile(
|
||||
user_id=current_user.id,
|
||||
bio=payload.bio if "bio" in fields_set else None,
|
||||
avatar_asset_id=payload.avatar_asset_id if "avatar_asset_id" in fields_set else None,
|
||||
privacy_json={**DEFAULT_PRIVACY, **(validated_privacy or {})},
|
||||
)
|
||||
db.add(row)
|
||||
else:
|
||||
if "bio" in fields_set:
|
||||
row.bio = payload.bio
|
||||
if "avatar_asset_id" in fields_set:
|
||||
row.avatar_asset_id = payload.avatar_asset_id
|
||||
if validated_privacy is not None:
|
||||
merged = dict(row.privacy_json or DEFAULT_PRIVACY)
|
||||
merged.update(validated_privacy)
|
||||
row.privacy_json = merged
|
||||
|
||||
await db.commit()
|
||||
await db.refresh(row)
|
||||
return _profile_response(row, current_user.id)
|
||||
|
||||
|
||||
@router.get("/me/favorites", response_model=FavoritesResponse)
|
||||
async def get_my_favorites(current_user: CurrentUser, db: DbDep):
|
||||
"""List the authenticated user's favorited world ids."""
|
||||
result = await db.execute(
|
||||
select(ProfileFavorite.world_id).where(ProfileFavorite.user_id == current_user.id)
|
||||
)
|
||||
return FavoritesResponse(world_ids=[wid for wid in result.scalars().all()])
|
||||
|
||||
|
||||
@router.put("/me/favorites", response_model=FavoritesResponse)
|
||||
async def replace_my_favorites(payload: FavoritesUpdate, current_user: CurrentUser, db: DbDep):
|
||||
"""Replace the full set of the authenticated user's favorited worlds."""
|
||||
world_ids = list(dict.fromkeys(payload.world_ids)) # de-dupe, preserve order
|
||||
|
||||
if world_ids:
|
||||
result = await db.execute(select(World.id).where(World.id.in_(world_ids)))
|
||||
existing_ids = set(result.scalars().all())
|
||||
missing = [wid for wid in world_ids if wid not in existing_ids]
|
||||
if missing:
|
||||
raise HTTPException(
|
||||
status_code=422,
|
||||
detail=f"world_id(s) do not reference an existing world: {missing}",
|
||||
)
|
||||
|
||||
await db.execute(
|
||||
ProfileFavorite.__table__.delete().where(ProfileFavorite.user_id == current_user.id)
|
||||
)
|
||||
for wid in world_ids:
|
||||
db.add(ProfileFavorite(user_id=current_user.id, world_id=wid))
|
||||
|
||||
await db.commit()
|
||||
return FavoritesResponse(world_ids=world_ids)
|
||||
|
||||
|
||||
@router.get("/{user_id}", response_model=PublicProfileResponse)
|
||||
async def get_public_profile(user_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Return the public profile for a user, respecting server-side privacy
|
||||
settings and block relationships."""
|
||||
user_res = await db.execute(select(User).where(User.id == user_id))
|
||||
target_user = user_res.scalar_one_or_none()
|
||||
if target_user is None or not target_user.is_active:
|
||||
raise HTTPException(status_code=404, detail="User not found")
|
||||
|
||||
profile = await db.get(Profile, user_id)
|
||||
avatar_asset = None
|
||||
if profile and profile.avatar_asset_id:
|
||||
avatar_asset = await db.get(Asset, profile.avatar_asset_id)
|
||||
|
||||
privacy = dict(DEFAULT_PRIVACY)
|
||||
if profile and profile.privacy_json:
|
||||
privacy.update(profile.privacy_json)
|
||||
|
||||
is_self = current_user.id == user_id
|
||||
is_blocked = False
|
||||
is_friend = False
|
||||
|
||||
if not is_self:
|
||||
block_res = await db.execute(
|
||||
select(Block.id).where(
|
||||
or_(
|
||||
and_(Block.blocker_id == current_user.id, Block.blocked_id == user_id),
|
||||
and_(Block.blocker_id == user_id, Block.blocked_id == current_user.id),
|
||||
)
|
||||
)
|
||||
)
|
||||
is_blocked = block_res.scalar_one_or_none() is not None
|
||||
|
||||
if not is_blocked:
|
||||
friend_res = await db.execute(
|
||||
select(Friendship.id).where(
|
||||
or_(
|
||||
and_(Friendship.requester_id == current_user.id, Friendship.addressee_id == user_id),
|
||||
and_(Friendship.requester_id == user_id, Friendship.addressee_id == current_user.id),
|
||||
),
|
||||
Friendship.status == FriendshipStatus.ACCEPTED,
|
||||
)
|
||||
)
|
||||
is_friend = friend_res.scalar_one_or_none() is not None
|
||||
|
||||
profile_vis = privacy.get("profile_visibility", ProfileVisibility.PUBLIC.value)
|
||||
if profile_vis is False:
|
||||
profile_vis = ProfileVisibility.PRIVATE.value
|
||||
elif profile_vis is True:
|
||||
profile_vis = ProfileVisibility.PUBLIC.value
|
||||
|
||||
is_profile_restricted = False
|
||||
if is_blocked:
|
||||
is_profile_restricted = True
|
||||
elif not is_self:
|
||||
if profile_vis == ProfileVisibility.PRIVATE.value:
|
||||
is_profile_restricted = True
|
||||
elif profile_vis == ProfileVisibility.FRIENDS.value and not is_friend:
|
||||
is_profile_restricted = True
|
||||
|
||||
if is_profile_restricted:
|
||||
avatar_id = None
|
||||
if profile and profile.avatar_asset_id:
|
||||
if avatar_asset and avatar_asset.is_public:
|
||||
avatar_id = profile.avatar_asset_id
|
||||
return PublicProfileResponse(
|
||||
user_id=target_user.id,
|
||||
username=target_user.username,
|
||||
avatar_asset_id=avatar_id,
|
||||
bio=None,
|
||||
favorites=[],
|
||||
friends=[],
|
||||
is_restricted=True,
|
||||
)
|
||||
|
||||
avatar_id = profile.avatar_asset_id if profile else None
|
||||
bio = profile.bio if profile else None
|
||||
|
||||
fav_vis = privacy.get("favorites_visibility", ProfileVisibility.PUBLIC.value)
|
||||
if fav_vis is False:
|
||||
fav_vis = ProfileVisibility.PRIVATE.value
|
||||
elif fav_vis is True:
|
||||
fav_vis = ProfileVisibility.PUBLIC.value
|
||||
|
||||
can_see_favorites = is_self or (fav_vis == ProfileVisibility.PUBLIC.value) or (fav_vis == ProfileVisibility.FRIENDS.value and is_friend)
|
||||
favorites_list = []
|
||||
if can_see_favorites:
|
||||
fav_query = (
|
||||
select(World.id, World.name)
|
||||
.join(ProfileFavorite, ProfileFavorite.world_id == World.id)
|
||||
.where(ProfileFavorite.user_id == user_id)
|
||||
.order_by(ProfileFavorite.created_at.desc())
|
||||
)
|
||||
fav_res = await db.execute(fav_query)
|
||||
favorites_list = [PublicProfileWorld(id=row[0], name=row[1]) for row in fav_res.all()]
|
||||
|
||||
fr_vis = privacy.get("friends_list_visibility", ProfileVisibility.PUBLIC.value)
|
||||
if fr_vis is False:
|
||||
fr_vis = ProfileVisibility.PRIVATE.value
|
||||
elif fr_vis is True:
|
||||
fr_vis = ProfileVisibility.PUBLIC.value
|
||||
|
||||
can_see_friends = is_self or (fr_vis == ProfileVisibility.PUBLIC.value) or (fr_vis == ProfileVisibility.FRIENDS.value and is_friend)
|
||||
friends_list = []
|
||||
if can_see_friends:
|
||||
fr_res = await db.execute(
|
||||
select(Friendship).where(
|
||||
or_(Friendship.requester_id == user_id, Friendship.addressee_id == user_id),
|
||||
Friendship.status == FriendshipStatus.ACCEPTED,
|
||||
)
|
||||
)
|
||||
friendships = fr_res.scalars().all()
|
||||
other_ids = [
|
||||
fr.addressee_id if fr.requester_id == user_id else fr.requester_id
|
||||
for fr in friendships
|
||||
]
|
||||
if other_ids:
|
||||
users_res = await db.execute(
|
||||
select(User.id, User.username).where(User.id.in_(other_ids), User.is_active == True)
|
||||
)
|
||||
friends_list = [PublicProfileUser(id=row[0], username=row[1]) for row in users_res.all()]
|
||||
|
||||
return PublicProfileResponse(
|
||||
user_id=target_user.id,
|
||||
username=target_user.username,
|
||||
avatar_asset_id=avatar_id,
|
||||
bio=bio,
|
||||
favorites=favorites_list,
|
||||
friends=friends_list,
|
||||
is_restricted=False,
|
||||
)
|
||||
|
||||
@@ -0,0 +1,362 @@
|
||||
"""Friends/follow/block router.
|
||||
|
||||
docs/planning/social.md §4/§5 (US-1). Builds the request/accept/block
|
||||
business logic on top of the models in app/models/social.py (already
|
||||
merged): friend requests are directional (requester -> addressee) until
|
||||
accepted, at which point the relationship is treated as mutual; follow is
|
||||
one-way with no approval step; block is a hard deny that clears any
|
||||
existing friendship/follow between the two users and is queryable so a
|
||||
later layer (e.g. chat) can check it -- enforcing the block anywhere but
|
||||
here is out of scope for this router.
|
||||
|
||||
Endpoints:
|
||||
- POST /api/friends/requests -- send a friend request
|
||||
- GET /api/friends/requests -- list incoming (pending) requests
|
||||
- POST /api/friends/requests/{id}/accept -- accept an incoming request
|
||||
- POST /api/friends/requests/{id}/decline -- decline an incoming request
|
||||
- DELETE /api/friends/{user_id} -- unfriend
|
||||
- POST /api/friends/{user_id}/follow -- follow a user
|
||||
- DELETE /api/friends/{user_id}/follow -- unfollow a user
|
||||
- POST /api/friends/{user_id}/block -- block a user
|
||||
- DELETE /api/friends/{user_id}/block -- unblock a user
|
||||
- GET /api/friends -- list friends
|
||||
- GET /api/friends/following -- list users followed
|
||||
- GET /api/friends/blocked -- list blocked users
|
||||
"""
|
||||
|
||||
from datetime import datetime
|
||||
from typing import Annotated
|
||||
|
||||
from fastapi import APIRouter, HTTPException, status, Depends
|
||||
from pydantic import BaseModel
|
||||
from sqlalchemy import select, delete, or_, and_
|
||||
from sqlalchemy.exc import IntegrityError
|
||||
from sqlalchemy.ext.asyncio import AsyncSession
|
||||
|
||||
from app.database import get_db
|
||||
from app.dependencies import CurrentUser
|
||||
from app.models.social import Friendship, Follow, Block, FriendshipStatus
|
||||
from app.models.user import User
|
||||
|
||||
router = APIRouter()
|
||||
|
||||
DbDep = Annotated[AsyncSession, Depends(get_db)]
|
||||
|
||||
# ──────────────────────────── Pydantic schemas ────────────────────────────────
|
||||
|
||||
|
||||
class FriendRequestCreate(BaseModel):
|
||||
user_id: int
|
||||
|
||||
|
||||
class FriendRequestResponse(BaseModel):
|
||||
id: int
|
||||
requester_id: int
|
||||
addressee_id: int
|
||||
status: FriendshipStatus
|
||||
created_at: datetime
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class UserSummary(BaseModel):
|
||||
id: int
|
||||
username: str
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class FriendRequestListResponse(BaseModel):
|
||||
requests: list[FriendRequestResponse]
|
||||
|
||||
|
||||
class FriendListResponse(BaseModel):
|
||||
friends: list[UserSummary]
|
||||
|
||||
|
||||
class FollowListResponse(BaseModel):
|
||||
following: list[UserSummary]
|
||||
|
||||
|
||||
class BlockedListResponse(BaseModel):
|
||||
blocked: list[UserSummary]
|
||||
|
||||
|
||||
class ActionResponse(BaseModel):
|
||||
status: str
|
||||
|
||||
|
||||
# ──────────────────────────────── Helpers ──────────────────────────────────────
|
||||
|
||||
|
||||
def _friendship_pair(a: int, b: int):
|
||||
"""SQLAlchemy predicate matching a Friendship row between a and b,
|
||||
regardless of which one is the requester/addressee."""
|
||||
return or_(
|
||||
and_(Friendship.requester_id == a, Friendship.addressee_id == b),
|
||||
and_(Friendship.requester_id == b, Friendship.addressee_id == a),
|
||||
)
|
||||
|
||||
|
||||
def _follow_pair(a: int, b: int):
|
||||
"""Predicate matching a Follow row in either direction between a and b."""
|
||||
return or_(
|
||||
and_(Follow.follower_id == a, Follow.followed_id == b),
|
||||
and_(Follow.follower_id == b, Follow.followed_id == a),
|
||||
)
|
||||
|
||||
|
||||
async def _is_blocked_either_direction(db: AsyncSession, a: int, b: int) -> bool:
|
||||
result = await db.execute(
|
||||
select(Block.id).where(
|
||||
or_(
|
||||
and_(Block.blocker_id == a, Block.blocked_id == b),
|
||||
and_(Block.blocker_id == b, Block.blocked_id == a),
|
||||
)
|
||||
)
|
||||
)
|
||||
return result.scalar_one_or_none() is not None
|
||||
|
||||
|
||||
async def _get_user_or_404(db: AsyncSession, user_id: int) -> User:
|
||||
result = await db.execute(select(User).where(User.id == user_id))
|
||||
user = result.scalar_one_or_none()
|
||||
if user is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="User not found")
|
||||
return user
|
||||
|
||||
|
||||
# ──────────────────────────────── Requests ─────────────────────────────────────
|
||||
|
||||
|
||||
@router.post("/requests", response_model=FriendRequestResponse, status_code=status.HTTP_201_CREATED)
|
||||
async def send_friend_request(body: FriendRequestCreate, current_user: CurrentUser, db: DbDep):
|
||||
"""Send a friend request to another user."""
|
||||
target_id = body.user_id
|
||||
if target_id == current_user.id:
|
||||
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot send a friend request to yourself")
|
||||
|
||||
await _get_user_or_404(db, target_id)
|
||||
|
||||
if await _is_blocked_either_direction(db, current_user.id, target_id):
|
||||
raise HTTPException(status_code=status.HTTP_403_FORBIDDEN, detail="Cannot send a friend request to this user")
|
||||
|
||||
existing = await db.execute(select(Friendship).where(_friendship_pair(current_user.id, target_id)))
|
||||
if existing.scalar_one_or_none() is not None:
|
||||
raise HTTPException(status_code=status.HTTP_409_CONFLICT, detail="Friend request or friendship already exists")
|
||||
|
||||
fr = Friendship(requester_id=current_user.id, addressee_id=target_id)
|
||||
db.add(fr)
|
||||
try:
|
||||
await db.commit()
|
||||
except IntegrityError:
|
||||
await db.rollback()
|
||||
raise HTTPException(status_code=status.HTTP_409_CONFLICT, detail="Friend request or friendship already exists")
|
||||
await db.refresh(fr)
|
||||
return fr
|
||||
|
||||
|
||||
@router.get("/requests", response_model=FriendRequestListResponse)
|
||||
async def list_incoming_requests(current_user: CurrentUser, db: DbDep):
|
||||
"""List pending friend requests sent *to* the authenticated user."""
|
||||
result = await db.execute(
|
||||
select(Friendship).where(
|
||||
Friendship.addressee_id == current_user.id,
|
||||
Friendship.status == FriendshipStatus.PENDING,
|
||||
)
|
||||
)
|
||||
return FriendRequestListResponse(requests=list(result.scalars().all()))
|
||||
|
||||
|
||||
@router.post("/requests/{request_id}/accept", response_model=FriendRequestResponse)
|
||||
async def accept_friend_request(request_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Accept an incoming friend request, making the friendship mutual."""
|
||||
result = await db.execute(select(Friendship).where(Friendship.id == request_id))
|
||||
fr = result.scalar_one_or_none()
|
||||
# 404 (not a 403) both when the row doesn't exist and when it isn't
|
||||
# addressed to the caller, so ids can't be enumerated to probe other
|
||||
# accounts' pending requests.
|
||||
if fr is None or fr.addressee_id != current_user.id or fr.status != FriendshipStatus.PENDING:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Friend request not found")
|
||||
|
||||
fr.status = FriendshipStatus.ACCEPTED
|
||||
await db.commit()
|
||||
await db.refresh(fr)
|
||||
return fr
|
||||
|
||||
|
||||
@router.post("/requests/{request_id}/decline", response_model=ActionResponse)
|
||||
async def decline_friend_request(request_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Decline (and remove) an incoming friend request."""
|
||||
result = await db.execute(select(Friendship).where(Friendship.id == request_id))
|
||||
fr = result.scalar_one_or_none()
|
||||
if fr is None or fr.addressee_id != current_user.id or fr.status != FriendshipStatus.PENDING:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Friend request not found")
|
||||
|
||||
await db.delete(fr)
|
||||
await db.commit()
|
||||
return ActionResponse(status="declined")
|
||||
|
||||
|
||||
# ──────────────────────────────── Friends ──────────────────────────────────────
|
||||
|
||||
|
||||
@router.get("", response_model=FriendListResponse)
|
||||
async def list_friends(current_user: CurrentUser, db: DbDep):
|
||||
"""List the authenticated user's accepted friends."""
|
||||
result = await db.execute(
|
||||
select(Friendship).where(
|
||||
or_(Friendship.requester_id == current_user.id, Friendship.addressee_id == current_user.id),
|
||||
Friendship.status == FriendshipStatus.ACCEPTED,
|
||||
)
|
||||
)
|
||||
friendships = result.scalars().all()
|
||||
other_ids = [
|
||||
fr.addressee_id if fr.requester_id == current_user.id else fr.requester_id
|
||||
for fr in friendships
|
||||
]
|
||||
if not other_ids:
|
||||
return FriendListResponse(friends=[])
|
||||
|
||||
users_result = await db.execute(select(User).where(User.id.in_(other_ids)))
|
||||
return FriendListResponse(friends=list(users_result.scalars().all()))
|
||||
|
||||
|
||||
@router.delete("/{user_id}", response_model=ActionResponse)
|
||||
async def unfriend(user_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Remove an existing (accepted) friendship."""
|
||||
if user_id == current_user.id:
|
||||
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot unfriend yourself")
|
||||
|
||||
result = await db.execute(
|
||||
select(Friendship).where(
|
||||
_friendship_pair(current_user.id, user_id),
|
||||
Friendship.status == FriendshipStatus.ACCEPTED,
|
||||
)
|
||||
)
|
||||
fr = result.scalar_one_or_none()
|
||||
if fr is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Not friends with this user")
|
||||
|
||||
await db.delete(fr)
|
||||
await db.commit()
|
||||
return ActionResponse(status="unfriended")
|
||||
|
||||
|
||||
# ──────────────────────────────── Follow ───────────────────────────────────────
|
||||
|
||||
|
||||
@router.post("/{user_id}/follow", response_model=ActionResponse, status_code=status.HTTP_201_CREATED)
|
||||
async def follow_user(user_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Follow another user (one-way, no approval)."""
|
||||
if user_id == current_user.id:
|
||||
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot follow yourself")
|
||||
|
||||
await _get_user_or_404(db, user_id)
|
||||
|
||||
if await _is_blocked_either_direction(db, current_user.id, user_id):
|
||||
raise HTTPException(status_code=status.HTTP_403_FORBIDDEN, detail="Cannot follow this user")
|
||||
|
||||
existing = await db.execute(
|
||||
select(Follow).where(Follow.follower_id == current_user.id, Follow.followed_id == user_id)
|
||||
)
|
||||
if existing.scalar_one_or_none() is not None:
|
||||
raise HTTPException(status_code=status.HTTP_409_CONFLICT, detail="Already following this user")
|
||||
|
||||
db.add(Follow(follower_id=current_user.id, followed_id=user_id))
|
||||
try:
|
||||
await db.commit()
|
||||
except IntegrityError:
|
||||
await db.rollback()
|
||||
raise HTTPException(status_code=status.HTTP_409_CONFLICT, detail="Already following this user")
|
||||
return ActionResponse(status="followed")
|
||||
|
||||
|
||||
@router.delete("/{user_id}/follow", response_model=ActionResponse)
|
||||
async def unfollow_user(user_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Unfollow a user."""
|
||||
if user_id == current_user.id:
|
||||
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot unfollow yourself")
|
||||
|
||||
result = await db.execute(
|
||||
select(Follow).where(Follow.follower_id == current_user.id, Follow.followed_id == user_id)
|
||||
)
|
||||
follow = result.scalar_one_or_none()
|
||||
if follow is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Not following this user")
|
||||
|
||||
await db.delete(follow)
|
||||
await db.commit()
|
||||
return ActionResponse(status="unfollowed")
|
||||
|
||||
|
||||
@router.get("/following", response_model=FollowListResponse)
|
||||
async def list_following(current_user: CurrentUser, db: DbDep):
|
||||
"""List users the authenticated user follows."""
|
||||
result = await db.execute(select(Follow).where(Follow.follower_id == current_user.id))
|
||||
followed_ids = [f.followed_id for f in result.scalars().all()]
|
||||
if not followed_ids:
|
||||
return FollowListResponse(following=[])
|
||||
|
||||
users_result = await db.execute(select(User).where(User.id.in_(followed_ids)))
|
||||
return FollowListResponse(following=list(users_result.scalars().all()))
|
||||
|
||||
|
||||
# ──────────────────────────────── Block ────────────────────────────────────────
|
||||
|
||||
|
||||
@router.post("/{user_id}/block", response_model=ActionResponse, status_code=status.HTTP_201_CREATED)
|
||||
async def block_user(user_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Block a user: hard deny that also clears any existing friendship/follow
|
||||
between the two users in either direction."""
|
||||
if user_id == current_user.id:
|
||||
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot block yourself")
|
||||
|
||||
await _get_user_or_404(db, user_id)
|
||||
|
||||
existing = await db.execute(
|
||||
select(Block).where(Block.blocker_id == current_user.id, Block.blocked_id == user_id)
|
||||
)
|
||||
if existing.scalar_one_or_none() is not None:
|
||||
raise HTTPException(status_code=status.HTTP_409_CONFLICT, detail="User already blocked")
|
||||
|
||||
db.add(Block(blocker_id=current_user.id, blocked_id=user_id))
|
||||
await db.execute(delete(Friendship).where(_friendship_pair(current_user.id, user_id)))
|
||||
await db.execute(delete(Follow).where(_follow_pair(current_user.id, user_id)))
|
||||
|
||||
try:
|
||||
await db.commit()
|
||||
except IntegrityError:
|
||||
await db.rollback()
|
||||
raise HTTPException(status_code=status.HTTP_409_CONFLICT, detail="User already blocked")
|
||||
return ActionResponse(status="blocked")
|
||||
|
||||
|
||||
@router.delete("/{user_id}/block", response_model=ActionResponse)
|
||||
async def unblock_user(user_id: int, current_user: CurrentUser, db: DbDep):
|
||||
"""Remove a block."""
|
||||
if user_id == current_user.id:
|
||||
raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail="Cannot unblock yourself")
|
||||
|
||||
result = await db.execute(
|
||||
select(Block).where(Block.blocker_id == current_user.id, Block.blocked_id == user_id)
|
||||
)
|
||||
block = result.scalar_one_or_none()
|
||||
if block is None:
|
||||
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="User is not blocked")
|
||||
|
||||
await db.delete(block)
|
||||
await db.commit()
|
||||
return ActionResponse(status="unblocked")
|
||||
|
||||
|
||||
@router.get("/blocked", response_model=BlockedListResponse)
|
||||
async def list_blocked(current_user: CurrentUser, db: DbDep):
|
||||
"""List users the authenticated user has blocked."""
|
||||
result = await db.execute(select(Block).where(Block.blocker_id == current_user.id))
|
||||
blocked_ids = [b.blocked_id for b in result.scalars().all()]
|
||||
if not blocked_ids:
|
||||
return BlockedListResponse(blocked=[])
|
||||
|
||||
users_result = await db.execute(select(User).where(User.id.in_(blocked_ids)))
|
||||
return BlockedListResponse(blocked=list(users_result.scalars().all()))
|
||||
@@ -0,0 +1,304 @@
|
||||
"""Pluggable server-side text filtering, `docs/planning/social.md` §4/§5 (US-4).
|
||||
|
||||
social.md §4 calls for a "Pluggable `TextFilter` interface with a
|
||||
deterministic default (profanity list + normalization) so it runs without
|
||||
external services; third-party hook later". This module is that interface
|
||||
plus the default implementation:
|
||||
|
||||
- `TextFilter` is a `Protocol` -- the extension point. A future third-party
|
||||
moderation provider (a paid API, an ML classifier, etc.) just needs to
|
||||
implement `check(text) -> FilterResult`; nothing else in this module
|
||||
needs to change, and callers depend on the protocol, not a concrete
|
||||
class.
|
||||
- `ListBasedTextFilter` is the deterministic default: a configurable
|
||||
term list (JSON file, see `text_filter_terms.json` next to this module)
|
||||
matched against a normalized form of the input text so that trivial
|
||||
evasion (case changes, leetspeak substitutions, and punctuation/spacing
|
||||
inserted between letters) doesn't slip through.
|
||||
|
||||
Nothing here talks to a database, an HTTP client, or the FastAPI app -- it
|
||||
is a pure, side-effect-free (aside from reading the term list file once, at
|
||||
construction) service so it can be unit tested in isolation. It is NOT
|
||||
wired into any router/endpoint by this task; that's for the chat feature
|
||||
tasks that depend on it (social.md §6) to do.
|
||||
|
||||
Normalization approach
|
||||
-----------------------
|
||||
Matching naively against raw text misses "sh1t", "@ss", or "s.h.i.t". To
|
||||
catch these without a real tokenizer, every character of the input is
|
||||
independently normalized to at most one lowercase ASCII alphanumeric
|
||||
character (case-folded, then run through a small leetspeak substitution
|
||||
table); characters that don't reduce to `[a-z0-9]` (punctuation, spacing,
|
||||
symbols, non-ASCII) are dropped entirely rather than kept as separators.
|
||||
This collapses "s.h.i.t", "s h i t", and "SHIT" to the same normalized
|
||||
string ("shit") that a plain lowercase term list entry matches, while a
|
||||
side table (`index_map`) remembers which original character produced each
|
||||
surviving normalized character -- so a match found in the normalized
|
||||
string can still be translated back into a span of the *original* text for
|
||||
redaction.
|
||||
|
||||
This is a deliberate precision/recall tradeoff common to list-based
|
||||
filters: stripping separators and folding leetspeak increases recall
|
||||
against evasion at the cost of occasionally matching a term inside an
|
||||
unrelated longer word (e.g. a 3-letter term inside a longer benign word).
|
||||
That tradeoff is exactly why this is pluggable -- a deployment that needs
|
||||
tighter precision can swap in a smarter `TextFilter` implementation behind
|
||||
the same protocol.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import re
|
||||
from dataclasses import dataclass
|
||||
from enum import Enum
|
||||
from pathlib import Path
|
||||
from typing import Iterable, Protocol, runtime_checkable
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Public result / protocol
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
class FilterAction(str, Enum):
|
||||
"""What the caller should do with a checked message."""
|
||||
|
||||
ALLOW = "allow"
|
||||
REDACT = "redact"
|
||||
REJECT = "reject"
|
||||
|
||||
|
||||
@dataclass(frozen=True)
|
||||
class FilterResult:
|
||||
"""Outcome of running a piece of text through a `TextFilter`.
|
||||
|
||||
- `action`: ALLOW (no matches), REDACT (matches replaced in
|
||||
`filtered_text`), or REJECT (matches found; the message should be
|
||||
blocked -- callers should not persist/deliver it even though
|
||||
`filtered_text` is populated for logging/audit purposes).
|
||||
- `filtered_text`: the text to actually store/deliver. Equal to the
|
||||
input for ALLOW and REJECT; has matched spans replaced for REDACT.
|
||||
- `matched_terms`: the distinct matched terms (original, un-normalized
|
||||
list entries), in first-occurrence order. Empty for ALLOW.
|
||||
"""
|
||||
|
||||
action: FilterAction
|
||||
filtered_text: str
|
||||
matched_terms: tuple[str, ...] = ()
|
||||
|
||||
|
||||
@runtime_checkable
|
||||
class TextFilter(Protocol):
|
||||
"""Extension point for text filtering/moderation providers.
|
||||
|
||||
Any implementation -- the deterministic default below, or a future
|
||||
third-party service call -- just needs this one method.
|
||||
"""
|
||||
|
||||
def check(self, text: str) -> FilterResult:
|
||||
"""Check `text` and return the action to take plus filtered text."""
|
||||
...
|
||||
|
||||
|
||||
class FilterMode(str, Enum):
|
||||
"""Configures what `ListBasedTextFilter` does when it finds a match."""
|
||||
|
||||
REDACT = "redact"
|
||||
REJECT = "reject"
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Normalization
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
# Common leetspeak / lookalike substitutions, applied after case-folding.
|
||||
# Keys are already-lowercased single characters.
|
||||
_LEET_MAP: dict[str, str] = {
|
||||
"0": "o",
|
||||
"1": "i",
|
||||
"!": "i",
|
||||
"3": "e",
|
||||
"4": "a",
|
||||
"@": "a",
|
||||
"5": "s",
|
||||
"$": "s",
|
||||
"7": "t",
|
||||
"+": "t",
|
||||
"8": "b",
|
||||
"|": "l",
|
||||
}
|
||||
|
||||
_ALNUM_RE = re.compile(r"[a-z0-9]")
|
||||
|
||||
|
||||
def _normalize(text: str) -> tuple[str, list[int]]:
|
||||
"""Fold `text` to a lowercase-alnum-only string plus an index map.
|
||||
|
||||
Returns `(normalized, index_map)` where `index_map[i]` is the index
|
||||
into the *original* `text` that produced `normalized[i]`. Characters
|
||||
that don't reduce to a single `[a-z0-9]` character (punctuation,
|
||||
whitespace, symbols, most non-ASCII) are dropped from both outputs.
|
||||
"""
|
||||
normalized_chars: list[str] = []
|
||||
index_map: list[int] = []
|
||||
for i, ch in enumerate(text):
|
||||
folded = ch.casefold()
|
||||
# case-fold can expand to multiple characters for some unicode
|
||||
# (e.g. German "ß" -> "ss"); such characters are not part of the
|
||||
# leetspeak table and are not plain ascii alnum, so just skip them
|
||||
# like any other non-matching character rather than guessing.
|
||||
if len(folded) != 1:
|
||||
continue
|
||||
folded = _LEET_MAP.get(folded, folded)
|
||||
if _ALNUM_RE.fullmatch(folded):
|
||||
normalized_chars.append(folded)
|
||||
index_map.append(i)
|
||||
return "".join(normalized_chars), index_map
|
||||
|
||||
|
||||
def _normalize_term(term: str) -> str:
|
||||
normalized, _ = _normalize(term)
|
||||
return normalized
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Default term list loading
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
DEFAULT_TERMS_PATH = Path(__file__).with_name("text_filter_terms.json")
|
||||
|
||||
|
||||
def load_terms(path: Path | str | None = None) -> list[str]:
|
||||
"""Load a term list from a JSON file shaped `{"terms": [...]}`.
|
||||
|
||||
Any other top-level keys (e.g. `_readme`) are ignored. Defaults to the
|
||||
bundled `text_filter_terms.json` next to this module.
|
||||
"""
|
||||
resolved = Path(path) if path is not None else DEFAULT_TERMS_PATH
|
||||
with resolved.open("r", encoding="utf-8") as f:
|
||||
data = json.load(f)
|
||||
terms = data.get("terms", [])
|
||||
if not isinstance(terms, list):
|
||||
raise ValueError(f"{resolved}: 'terms' must be a list")
|
||||
return [str(t) for t in terms]
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Span merging / redaction helpers
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
def _merge_spans(spans: list[tuple[int, int, str]]) -> list[tuple[int, int]]:
|
||||
"""Merge overlapping/adjacent (start, end) spans, sorted by start."""
|
||||
if not spans:
|
||||
return []
|
||||
ordered = sorted((s, e) for s, e, _ in spans)
|
||||
merged: list[tuple[int, int]] = [ordered[0]]
|
||||
for start, end in ordered[1:]:
|
||||
last_start, last_end = merged[-1]
|
||||
if start <= last_end:
|
||||
merged[-1] = (last_start, max(last_end, end))
|
||||
else:
|
||||
merged.append((start, end))
|
||||
return merged
|
||||
|
||||
|
||||
def _apply_redactions(text: str, merged_spans: list[tuple[int, int]], redaction_char: str) -> str:
|
||||
if not merged_spans:
|
||||
return text
|
||||
pieces: list[str] = []
|
||||
cursor = 0
|
||||
for start, end in merged_spans:
|
||||
pieces.append(text[cursor:start])
|
||||
pieces.append(redaction_char * (end - start))
|
||||
cursor = end
|
||||
pieces.append(text[cursor:])
|
||||
return "".join(pieces)
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Default implementation
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
class ListBasedTextFilter:
|
||||
"""Deterministic `TextFilter`: normalized substring match against a term list.
|
||||
|
||||
`mode` controls what happens on a match:
|
||||
- `FilterMode.REDACT` (default): matched spans in the *original* text
|
||||
are replaced with `redaction_char` repeated to the matched span's
|
||||
original length; `action` is REDACT if anything matched, else ALLOW.
|
||||
- `FilterMode.REJECT`: `filtered_text` is returned unchanged but
|
||||
`action` is REJECT if anything matched (callers should treat this as
|
||||
"do not store/deliver"), else ALLOW.
|
||||
|
||||
An empty or whitespace-only string always returns ALLOW with no
|
||||
matches -- there is nothing to filter.
|
||||
"""
|
||||
|
||||
def __init__(
|
||||
self,
|
||||
terms: Iterable[str] | None = None,
|
||||
*,
|
||||
mode: FilterMode = FilterMode.REDACT,
|
||||
terms_path: Path | str | None = None,
|
||||
redaction_char: str = "*",
|
||||
) -> None:
|
||||
if terms is None:
|
||||
terms = load_terms(terms_path)
|
||||
# De-dupe while preserving order; drop blanks.
|
||||
seen: dict[str, None] = {}
|
||||
for t in terms:
|
||||
t = t.strip()
|
||||
if t:
|
||||
seen.setdefault(t, None)
|
||||
self._terms: tuple[str, ...] = tuple(seen)
|
||||
# Pre-normalize once at construction; skip terms that normalize to
|
||||
# nothing (e.g. a term that's pure punctuation).
|
||||
self._normalized_terms: list[tuple[str, str]] = [
|
||||
(normalized, original)
|
||||
for original in self._terms
|
||||
if (normalized := _normalize_term(original))
|
||||
]
|
||||
self.mode = mode
|
||||
self.redaction_char = redaction_char
|
||||
|
||||
def check(self, text: str) -> FilterResult:
|
||||
if not text or not text.strip():
|
||||
return FilterResult(action=FilterAction.ALLOW, filtered_text=text, matched_terms=())
|
||||
|
||||
normalized, index_map = _normalize(text)
|
||||
if not normalized:
|
||||
return FilterResult(action=FilterAction.ALLOW, filtered_text=text, matched_terms=())
|
||||
|
||||
spans: list[tuple[int, int, str]] = []
|
||||
for normalized_term, original_term in self._normalized_terms:
|
||||
start = 0
|
||||
term_len = len(normalized_term)
|
||||
while True:
|
||||
idx = normalized.find(normalized_term, start)
|
||||
if idx == -1:
|
||||
break
|
||||
end = idx + term_len
|
||||
orig_start = index_map[idx]
|
||||
orig_end = index_map[end - 1] + 1
|
||||
spans.append((orig_start, orig_end, original_term))
|
||||
start = end # non-overlapping: resume after this match
|
||||
|
||||
if not spans:
|
||||
return FilterResult(action=FilterAction.ALLOW, filtered_text=text, matched_terms=())
|
||||
|
||||
spans.sort(key=lambda s: s[0])
|
||||
matched_terms = tuple(dict.fromkeys(term for _, _, term in spans))
|
||||
|
||||
if self.mode is FilterMode.REJECT:
|
||||
return FilterResult(action=FilterAction.REJECT, filtered_text=text, matched_terms=matched_terms)
|
||||
|
||||
merged = _merge_spans(spans)
|
||||
filtered_text = _apply_redactions(text, merged, self.redaction_char)
|
||||
return FilterResult(action=FilterAction.REDACT, filtered_text=filtered_text, matched_terms=matched_terms)
|
||||
|
||||
|
||||
def default_text_filter(mode: FilterMode = FilterMode.REDACT) -> ListBasedTextFilter:
|
||||
"""Convenience factory for the bundled default term list."""
|
||||
return ListBasedTextFilter(mode=mode)
|
||||
@@ -0,0 +1,20 @@
|
||||
{
|
||||
"_readme": "Default deterministic term list for app.services.text_filter.ListBasedTextFilter. This is a minimal, illustrative starter list (common mild-to-strong English profanity, no slurs) meant to be replaced/extended per-deployment -- swap this file, or pass an explicit `terms`/`terms_path` to the filter, rather than editing this list in place for production moderation policy.",
|
||||
"terms": [
|
||||
"fuck",
|
||||
"shit",
|
||||
"ass",
|
||||
"asshole",
|
||||
"bitch",
|
||||
"bastard",
|
||||
"damn",
|
||||
"crap",
|
||||
"dick",
|
||||
"piss",
|
||||
"slut",
|
||||
"whore",
|
||||
"cunt",
|
||||
"douche",
|
||||
"bullshit"
|
||||
]
|
||||
}
|
||||
@@ -16,6 +16,7 @@ out dozens of times.
|
||||
"""
|
||||
|
||||
import asyncio
|
||||
import hashlib
|
||||
import os
|
||||
import socket
|
||||
import subprocess
|
||||
@@ -35,6 +36,9 @@ from app.main import app
|
||||
|
||||
TEST_TABLES = (
|
||||
"avatar_loadouts", "assets",
|
||||
# Profile (app/models/profile.py) -- both FK users.id, profile_favorites
|
||||
# additionally FKs worlds.id; list explicitly for clarity/consistency.
|
||||
"profile_favorites", "profiles",
|
||||
# world_chunk_revisions has no FK to worlds/world_chunks (world.md §4.7 /
|
||||
# world_persistence_impl.md §4.3, deliberate -- deleting a chunk or world
|
||||
# must not lose the audit trail), so it won't be cascade-truncated via
|
||||
@@ -58,9 +62,23 @@ TEST_TABLES = (
|
||||
)
|
||||
|
||||
BACKEND_DIR = Path(__file__).resolve().parents[1]
|
||||
_COMPOSE_PROJECT = "agp-pytest"
|
||||
_EPHEMERAL_PG_PORT = 25432
|
||||
_EPHEMERAL_REDIS_PORT = 26379
|
||||
|
||||
# A hardcoded project name/port here would mean every concurrent checkout
|
||||
# running `pytest` (e.g. several Claude Agent-tool subagents, each in their
|
||||
# own ~/agp/workspace/task_<id> clone) fights over the exact same Docker
|
||||
# Compose project and host ports -- one run's pytest_unconfigure teardown
|
||||
# can yank the ephemeral Postgres out from under a completely unrelated
|
||||
# concurrent run, surfacing as "connection was closed in the middle of
|
||||
# operation" with no obvious cause. Confirmed live 2026-09-15 running 3
|
||||
# parallel subagents. Same root cause and fix pattern as the agent_core
|
||||
# workspace/Docker-Compose collision documented in project_agp memory --
|
||||
# derive both the project name and the port from a hash of the checkout
|
||||
# directory, so different concurrent checkouts land on different projects/
|
||||
# ports while the same checkout is stable across repeated runs.
|
||||
_WORKSPACE_HASH = hashlib.sha256(str(BACKEND_DIR.parent).encode()).hexdigest()[:10]
|
||||
_COMPOSE_PROJECT = f"agp-pytest-{_WORKSPACE_HASH}"
|
||||
_EPHEMERAL_PG_PORT = 25400 + (int(_WORKSPACE_HASH, 16) % 100)
|
||||
_EPHEMERAL_REDIS_PORT = 26300 + (int(_WORKSPACE_HASH, 16) % 100)
|
||||
|
||||
# Set by pytest_configure() when it starts container(s) it owns; torn down in
|
||||
# pytest_unconfigure.
|
||||
|
||||
@@ -0,0 +1,312 @@
|
||||
"""Integration tests for the DM chat router (app/routers/chat_dm.py):
|
||||
|
||||
- POST /api/chat/dm/{user_id}/messages
|
||||
- GET /api/chat/dm/{user_id}/messages
|
||||
- GET /api/chat/dm/conversations
|
||||
|
||||
The block-relationship router doesn't exist yet (sibling task), so blocks
|
||||
are inserted directly against the ``Block`` model, same pattern already
|
||||
used by ``tests/test_chat_models.py`` for direct model setup.
|
||||
"""
|
||||
|
||||
import pytest
|
||||
from fastapi.testclient import TestClient
|
||||
from sqlalchemy import select
|
||||
from sqlalchemy.ext.asyncio import async_sessionmaker, create_async_engine
|
||||
from sqlalchemy.pool import NullPool
|
||||
|
||||
from app import rate_limit
|
||||
from app.config import settings
|
||||
from app.main import app
|
||||
from app.models.social import Block
|
||||
|
||||
|
||||
def _register(client: TestClient, username: str) -> dict:
|
||||
resp = client.post(
|
||||
"/api/auth/register",
|
||||
json={
|
||||
"username": username,
|
||||
"email": f"{username}@example.com",
|
||||
"password": "secret123",
|
||||
"date_of_birth": "1990-01-01",
|
||||
},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
token = resp.json()["access_token"]
|
||||
headers = {"Authorization": f"Bearer {token}"}
|
||||
me = client.get("/api/users/me", headers=headers)
|
||||
assert me.status_code == 200, me.text
|
||||
return {"headers": headers, "id": me.json()["id"], "username": username}
|
||||
|
||||
|
||||
async def _insert_block(blocker_id: int, blocked_id: int) -> None:
|
||||
engine = create_async_engine(settings.DATABASE_URL, poolclass=NullPool)
|
||||
session_factory = async_sessionmaker(engine, expire_on_commit=False)
|
||||
async with session_factory() as session:
|
||||
session.add(Block(blocker_id=blocker_id, blocked_id=blocked_id))
|
||||
await session.commit()
|
||||
await engine.dispose()
|
||||
|
||||
|
||||
class TestSendAndRetrieve:
|
||||
def test_send_then_fetch_history(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_alice1")
|
||||
bob = _register(client, "dm_bob1")
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "hey bob"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
sent = resp.json()
|
||||
assert sent["sender_id"] == alice["id"]
|
||||
assert sent["recipient_id"] == bob["id"]
|
||||
assert sent["body"] == "hey bob"
|
||||
assert sent["filtered"] is False
|
||||
assert sent["id"] is not None
|
||||
assert sent["created_at"] is not None
|
||||
|
||||
hist_alice = client.get(f"/api/chat/dm/{bob['id']}/messages", headers=alice["headers"])
|
||||
assert hist_alice.status_code == 200, hist_alice.text
|
||||
msgs = hist_alice.json()["messages"]
|
||||
assert len(msgs) == 1
|
||||
assert msgs[0]["body"] == "hey bob"
|
||||
|
||||
hist_bob = client.get(f"/api/chat/dm/{alice['id']}/messages", headers=bob["headers"])
|
||||
assert hist_bob.status_code == 200, hist_bob.text
|
||||
assert len(hist_bob.json()["messages"]) == 1
|
||||
assert hist_bob.json()["messages"][0]["body"] == "hey bob"
|
||||
|
||||
def test_cannot_message_self(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_self1")
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{alice['id']}/messages",
|
||||
json={"body": "hi me"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 400
|
||||
|
||||
def test_target_user_must_exist(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_noexist1")
|
||||
resp = client.post(
|
||||
"/api/chat/dm/999999999/messages",
|
||||
json={"body": "hello?"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 404
|
||||
|
||||
def test_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
resp = client.post("/api/chat/dm/1/messages", json={"body": "hi"})
|
||||
assert resp.status_code == 401
|
||||
|
||||
def test_history_pagination_cursor(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_page_a")
|
||||
bob = _register(client, "dm_page_b")
|
||||
|
||||
for i in range(5):
|
||||
r = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": f"msg {i}"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert r.status_code == 201, r.text
|
||||
|
||||
page1 = client.get(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
params={"limit": 2},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert page1.status_code == 200
|
||||
body1 = page1.json()
|
||||
assert len(body1["messages"]) == 2
|
||||
assert body1["messages"][0]["body"] == "msg 4" # newest first
|
||||
assert body1["next_cursor"] is not None
|
||||
|
||||
page2 = client.get(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
params={"limit": 2, "before": body1["next_cursor"]},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert page2.status_code == 200
|
||||
body2 = page2.json()
|
||||
assert [m["body"] for m in body2["messages"]] == ["msg 2", "msg 1"]
|
||||
|
||||
def test_no_conversation_yet_returns_empty_history(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_empty_a")
|
||||
bob = _register(client, "dm_empty_b")
|
||||
resp = client.get(f"/api/chat/dm/{bob['id']}/messages", headers=alice["headers"])
|
||||
assert resp.status_code == 200
|
||||
assert resp.json() == {"messages": [], "next_cursor": None}
|
||||
|
||||
|
||||
class TestConversationList:
|
||||
def test_lists_peer_last_message_and_unread_count(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_conv_a")
|
||||
bob = _register(client, "dm_conv_b")
|
||||
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "first"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "second"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
|
||||
convs_bob = client.get("/api/chat/dm/conversations", headers=bob["headers"])
|
||||
assert convs_bob.status_code == 200, convs_bob.text
|
||||
data = convs_bob.json()
|
||||
assert data["total"] == 1
|
||||
conv = data["conversations"][0]
|
||||
assert conv["peer_id"] == alice["id"]
|
||||
assert conv["peer_username"] == "dm_conv_a"
|
||||
assert conv["last_message"]["body"] == "second"
|
||||
assert conv["unread_count"] == 2 # bob hasn't read yet
|
||||
|
||||
# Bob reads the latest page -> unread resets to 0.
|
||||
client.get(f"/api/chat/dm/{alice['id']}/messages", headers=bob["headers"])
|
||||
convs_bob_after = client.get("/api/chat/dm/conversations", headers=bob["headers"])
|
||||
assert convs_bob_after.json()["conversations"][0]["unread_count"] == 0
|
||||
|
||||
# Alice sent them, so her own unread count for this conversation is 0.
|
||||
convs_alice = client.get("/api/chat/dm/conversations", headers=alice["headers"])
|
||||
assert convs_alice.json()["conversations"][0]["unread_count"] == 0
|
||||
|
||||
def test_scoped_to_authenticated_user_only(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_scope_a")
|
||||
bob = _register(client, "dm_scope_b")
|
||||
carol = _register(client, "dm_scope_c")
|
||||
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "hi bob"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
|
||||
convs_carol = client.get("/api/chat/dm/conversations", headers=carol["headers"])
|
||||
assert convs_carol.status_code == 200
|
||||
assert convs_carol.json() == {"conversations": [], "total": 0}
|
||||
|
||||
def test_cannot_read_another_pairs_conversation(self):
|
||||
"""A user's history endpoint only ever resolves *their own* pairing
|
||||
with the given peer id -- there is no conversation id in the URL an
|
||||
outsider could guess/pass to read someone else's DMs."""
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_iso_a")
|
||||
bob = _register(client, "dm_iso_b")
|
||||
carol = _register(client, "dm_iso_c")
|
||||
|
||||
client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "secret to bob"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
|
||||
# Carol asking for her "history with bob" gets her own (empty)
|
||||
# conversation, never alice's.
|
||||
resp = client.get(f"/api/chat/dm/{bob['id']}/messages", headers=carol["headers"])
|
||||
assert resp.status_code == 200
|
||||
assert resp.json()["messages"] == []
|
||||
|
||||
|
||||
class TestBlocking:
|
||||
async def test_blocker_cannot_send_to_blocked(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_block_a1")
|
||||
bob = _register(client, "dm_block_b1")
|
||||
await _insert_block(alice["id"], bob["id"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "let me in"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
async def test_blocked_cannot_send_to_blocker(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_block_a2")
|
||||
bob = _register(client, "dm_block_b2")
|
||||
await _insert_block(alice["id"], bob["id"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{alice['id']}/messages",
|
||||
json={"body": "please respond"},
|
||||
headers=bob["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
|
||||
class TestTextFilter:
|
||||
def test_message_tripping_filter_is_redacted_and_flagged(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_filter_a")
|
||||
bob = _register(client, "dm_filter_b")
|
||||
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "you are a bastard"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
data = resp.json()
|
||||
assert data["filtered"] is True
|
||||
assert "bastard" not in data["body"]
|
||||
assert "*" in data["body"]
|
||||
|
||||
# The stored/delivered copy is the redacted one, not the raw text.
|
||||
hist = client.get(f"/api/chat/dm/{alice['id']}/messages", headers=bob["headers"])
|
||||
assert hist.json()["messages"][0]["body"] == data["body"]
|
||||
|
||||
def test_clean_message_is_not_flagged(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_clean_a")
|
||||
bob = _register(client, "dm_clean_b")
|
||||
resp = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": "have a nice day"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
assert resp.status_code == 201
|
||||
assert resp.json()["filtered"] is False
|
||||
assert resp.json()["body"] == "have a nice day"
|
||||
|
||||
|
||||
class TestRateLimit:
|
||||
@pytest.fixture(autouse=True)
|
||||
def _enable_rate_limiting(self):
|
||||
prev = settings.RATE_LIMIT_ENABLED
|
||||
settings.RATE_LIMIT_ENABLED = True
|
||||
rate_limit.reset_all()
|
||||
yield
|
||||
rate_limit.reset_all()
|
||||
settings.RATE_LIMIT_ENABLED = prev
|
||||
|
||||
def test_send_rate_limit_exceeded_returns_429(self):
|
||||
client = TestClient(app)
|
||||
alice = _register(client, "dm_rl_a")
|
||||
bob = _register(client, "dm_rl_b")
|
||||
|
||||
codes = []
|
||||
for i in range(25):
|
||||
r = client.post(
|
||||
f"/api/chat/dm/{bob['id']}/messages",
|
||||
json={"body": f"spam {i}"},
|
||||
headers=alice["headers"],
|
||||
)
|
||||
codes.append(r.status_code)
|
||||
|
||||
assert codes[:20] == [201] * 20
|
||||
assert 429 in codes[20:]
|
||||
assert codes[-1] == 429
|
||||
@@ -0,0 +1,437 @@
|
||||
"""Integration tests for the Groups API router (app/routers/groups.py).
|
||||
|
||||
app/models/groups.py owns the schema (see test_group_models.py); this
|
||||
covers create/join/leave, role authorization, ownership transfer, and the
|
||||
group page's member-list privacy.
|
||||
"""
|
||||
|
||||
from fastapi.testclient import TestClient
|
||||
|
||||
from app.main import app
|
||||
|
||||
|
||||
def _register(client: TestClient, username: str) -> dict:
|
||||
resp = client.post(
|
||||
"/api/auth/register",
|
||||
json={
|
||||
"username": username,
|
||||
"email": f"{username}@example.com",
|
||||
"password": "secret123",
|
||||
"date_of_birth": "1990-01-01",
|
||||
},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
token = resp.json()["access_token"]
|
||||
headers = {"Authorization": f"Bearer {token}"}
|
||||
me = client.get("/api/users/me", headers=headers)
|
||||
assert me.status_code == 200, me.text
|
||||
return {"headers": headers, "id": me.json()["id"], "username": username}
|
||||
|
||||
|
||||
def _create_group(client: TestClient, headers: dict, name: str, description: str | None = None) -> dict:
|
||||
resp = client.post(
|
||||
"/api/groups",
|
||||
json={"name": name, "description": description},
|
||||
headers=headers,
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
return resp.json()
|
||||
|
||||
|
||||
class TestCreateGroup:
|
||||
def test_create_makes_creator_owner(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_create_owner")
|
||||
|
||||
group = _create_group(client, owner["headers"], "Explorers", "We explore worlds")
|
||||
assert group["name"] == "Explorers"
|
||||
assert group["description"] == "We explore worlds"
|
||||
assert group["owner_id"] == owner["id"]
|
||||
assert group["member_count"] == 1
|
||||
assert len(group["members"]) == 1
|
||||
assert group["members"][0]["user_id"] == owner["id"]
|
||||
assert group["members"][0]["role"] == "owner"
|
||||
|
||||
def test_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
resp = client.post("/api/groups", json={"name": "No Auth"})
|
||||
assert resp.status_code == 401
|
||||
|
||||
def test_blank_name_rejected(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_blank_name")
|
||||
resp = client.post("/api/groups", json={"name": " "}, headers=owner["headers"])
|
||||
assert resp.status_code == 422
|
||||
|
||||
def test_name_over_max_length_rejected(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_long_name")
|
||||
resp = client.post(
|
||||
"/api/groups", json={"name": "x" * 101}, headers=owner["headers"]
|
||||
)
|
||||
assert resp.status_code == 422
|
||||
|
||||
|
||||
class TestGroupPage:
|
||||
def test_get_group_page_shows_members_and_roles_no_private_fields(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_page_owner")
|
||||
member = _register(client, "grp_api_page_member")
|
||||
|
||||
group = _create_group(client, owner["headers"], "Page Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
resp = client.get(f"/api/groups/{group['id']}", headers=member["headers"])
|
||||
assert resp.status_code == 200, resp.text
|
||||
body = resp.json()
|
||||
assert body["name"] == "Page Group"
|
||||
assert body["member_count"] == 2
|
||||
by_user = {m["user_id"]: m for m in body["members"]}
|
||||
assert by_user[owner["id"]]["role"] == "owner"
|
||||
assert by_user[member["id"]]["role"] == "member"
|
||||
assert by_user[member["id"]]["username"] == member["username"]
|
||||
|
||||
# No private User fields (email, hashed_password, etc.) leak.
|
||||
for m in body["members"]:
|
||||
assert set(m.keys()) == {"user_id", "username", "role", "joined_at"}
|
||||
|
||||
def test_get_nonexistent_group_is_404(self):
|
||||
client = TestClient(app)
|
||||
user = _register(client, "grp_api_404")
|
||||
resp = client.get("/api/groups/999999999", headers=user["headers"])
|
||||
assert resp.status_code == 404
|
||||
|
||||
|
||||
class TestJoinLeave:
|
||||
def test_join_is_idempotent(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_join_owner")
|
||||
joiner = _register(client, "grp_api_join_joiner")
|
||||
group = _create_group(client, owner["headers"], "Join Group")
|
||||
|
||||
r1 = client.post(f"/api/groups/{group['id']}/join", headers=joiner["headers"])
|
||||
assert r1.status_code == 200, r1.text
|
||||
r2 = client.post(f"/api/groups/{group['id']}/join", headers=joiner["headers"])
|
||||
assert r2.status_code == 200, r2.text
|
||||
assert r1.json()["role"] == r2.json()["role"] == "member"
|
||||
|
||||
page = client.get(f"/api/groups/{group['id']}", headers=owner["headers"]).json()
|
||||
assert page["member_count"] == 2 # not 3 -- duplicate join didn't add a row
|
||||
|
||||
def test_leave_removes_membership(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_leave_owner")
|
||||
member = _register(client, "grp_api_leave_member")
|
||||
group = _create_group(client, owner["headers"], "Leave Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
resp = client.post(f"/api/groups/{group['id']}/leave", headers=member["headers"])
|
||||
assert resp.status_code == 200, resp.text
|
||||
|
||||
page = client.get(f"/api/groups/{group['id']}", headers=owner["headers"]).json()
|
||||
assert page["member_count"] == 1
|
||||
assert all(m["user_id"] != member["id"] for m in page["members"])
|
||||
|
||||
def test_owner_cannot_leave_without_transfer(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_owner_leave")
|
||||
group = _create_group(client, owner["headers"], "Owner Leave Group")
|
||||
|
||||
resp = client.post(f"/api/groups/{group['id']}/leave", headers=owner["headers"])
|
||||
assert resp.status_code == 409, resp.text
|
||||
|
||||
def test_leave_when_not_a_member_is_404(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_notmember_owner")
|
||||
stranger = _register(client, "grp_api_notmember_stranger")
|
||||
group = _create_group(client, owner["headers"], "Not A Member Group")
|
||||
|
||||
resp = client.post(f"/api/groups/{group['id']}/leave", headers=stranger["headers"])
|
||||
assert resp.status_code == 404
|
||||
|
||||
|
||||
class TestRoleAuthorization:
|
||||
def test_owner_can_promote_and_demote(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_role_owner")
|
||||
member = _register(client, "grp_api_role_member")
|
||||
group = _create_group(client, owner["headers"], "Role Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
promote = client.post(
|
||||
f"/api/groups/{group['id']}/members/{member['id']}/role",
|
||||
json={"role": "admin"},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
assert promote.status_code == 200, promote.text
|
||||
assert promote.json()["role"] == "admin"
|
||||
|
||||
demote = client.post(
|
||||
f"/api/groups/{group['id']}/members/{member['id']}/role",
|
||||
json={"role": "member"},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
assert demote.status_code == 200, demote.text
|
||||
assert demote.json()["role"] == "member"
|
||||
|
||||
def test_plain_member_cannot_promote(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_noauth_owner")
|
||||
member = _register(client, "grp_api_noauth_member")
|
||||
other = _register(client, "grp_api_noauth_other")
|
||||
group = _create_group(client, owner["headers"], "No Auth Promote Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=other["headers"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/groups/{group['id']}/members/{other['id']}/role",
|
||||
json={"role": "admin"},
|
||||
headers=member["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
def test_admin_cannot_promote_or_demote(self):
|
||||
"""Only the owner may change roles -- admins cannot, per spec."""
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_adminauth_owner")
|
||||
admin = _register(client, "grp_api_adminauth_admin")
|
||||
other = _register(client, "grp_api_adminauth_other")
|
||||
group = _create_group(client, owner["headers"], "Admin Cannot Promote Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=admin["headers"])
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=other["headers"])
|
||||
client.post(
|
||||
f"/api/groups/{group['id']}/members/{admin['id']}/role",
|
||||
json={"role": "admin"},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
|
||||
resp = client.post(
|
||||
f"/api/groups/{group['id']}/members/{other['id']}/role",
|
||||
json={"role": "admin"},
|
||||
headers=admin["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
def test_plain_member_cannot_delete_group(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_nodelete_owner")
|
||||
member = _register(client, "grp_api_nodelete_member")
|
||||
group = _create_group(client, owner["headers"], "No Delete Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
resp = client.delete(f"/api/groups/{group['id']}", headers=member["headers"])
|
||||
assert resp.status_code == 403
|
||||
|
||||
def test_admin_cannot_delete_group(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_admindelete_owner")
|
||||
admin = _register(client, "grp_api_admindelete_admin")
|
||||
group = _create_group(client, owner["headers"], "Admin No Delete Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=admin["headers"])
|
||||
client.post(
|
||||
f"/api/groups/{group['id']}/members/{admin['id']}/role",
|
||||
json={"role": "admin"},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
|
||||
resp = client.delete(f"/api/groups/{group['id']}", headers=admin["headers"])
|
||||
assert resp.status_code == 403
|
||||
|
||||
def test_plain_member_cannot_transfer_ownership(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_notransfer_owner")
|
||||
member = _register(client, "grp_api_notransfer_member")
|
||||
group = _create_group(client, owner["headers"], "No Transfer Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/groups/{group['id']}/transfer",
|
||||
json={"new_owner_id": member["id"]},
|
||||
headers=member["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
def test_cannot_set_role_to_owner_via_role_endpoint(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_noownerrole_owner")
|
||||
member = _register(client, "grp_api_noownerrole_member")
|
||||
group = _create_group(client, owner["headers"], "No Owner Role Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/groups/{group['id']}/members/{member['id']}/role",
|
||||
json={"role": "owner"},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
assert resp.status_code == 422
|
||||
|
||||
|
||||
class TestOwnershipTransfer:
|
||||
def test_transfer_moves_ownership_and_demotes_old_owner(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_xfer_owner")
|
||||
member = _register(client, "grp_api_xfer_member")
|
||||
group = _create_group(client, owner["headers"], "Transfer Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
resp = client.post(
|
||||
f"/api/groups/{group['id']}/transfer",
|
||||
json={"new_owner_id": member["id"]},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
assert resp.status_code == 200, resp.text
|
||||
body = resp.json()
|
||||
assert body["owner_id"] == member["id"]
|
||||
by_user = {m["user_id"]: m for m in body["members"]}
|
||||
assert by_user[member["id"]]["role"] == "owner"
|
||||
assert by_user[owner["id"]]["role"] == "admin"
|
||||
|
||||
# Exactly one owner remains.
|
||||
owners = [m for m in body["members"] if m["role"] == "owner"]
|
||||
assert len(owners) == 1
|
||||
|
||||
# Old owner can now leave (no longer the owner).
|
||||
leave = client.post(f"/api/groups/{group['id']}/leave", headers=owner["headers"])
|
||||
assert leave.status_code == 200, leave.text
|
||||
|
||||
# New owner cannot leave without transferring again.
|
||||
leave2 = client.post(f"/api/groups/{group['id']}/leave", headers=member["headers"])
|
||||
assert leave2.status_code == 409
|
||||
|
||||
def test_transfer_target_must_be_a_member(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_xfernonmember_owner")
|
||||
stranger = _register(client, "grp_api_xfernonmember_stranger")
|
||||
group = _create_group(client, owner["headers"], "Transfer Nonmember Group")
|
||||
|
||||
resp = client.post(
|
||||
f"/api/groups/{group['id']}/transfer",
|
||||
json={"new_owner_id": stranger["id"]},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
assert resp.status_code == 404
|
||||
|
||||
def test_transfer_to_self_rejected(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_xferself_owner")
|
||||
group = _create_group(client, owner["headers"], "Transfer Self Group")
|
||||
|
||||
resp = client.post(
|
||||
f"/api/groups/{group['id']}/transfer",
|
||||
json={"new_owner_id": owner["id"]},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
assert resp.status_code == 400
|
||||
|
||||
|
||||
class TestUpdateGroup:
|
||||
def test_owner_can_update_name_and_description(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_update_owner")
|
||||
group = _create_group(client, owner["headers"], "Old Name", "Old desc")
|
||||
|
||||
resp = client.patch(
|
||||
f"/api/groups/{group['id']}",
|
||||
json={"name": "New Name", "description": "New desc"},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
assert resp.status_code == 200, resp.text
|
||||
assert resp.json()["name"] == "New Name"
|
||||
assert resp.json()["description"] == "New desc"
|
||||
|
||||
def test_admin_can_update(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_adminupdate_owner")
|
||||
admin = _register(client, "grp_api_adminupdate_admin")
|
||||
group = _create_group(client, owner["headers"], "Admin Update Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=admin["headers"])
|
||||
client.post(
|
||||
f"/api/groups/{group['id']}/members/{admin['id']}/role",
|
||||
json={"role": "admin"},
|
||||
headers=owner["headers"],
|
||||
)
|
||||
|
||||
resp = client.patch(
|
||||
f"/api/groups/{group['id']}",
|
||||
json={"name": "Updated By Admin"},
|
||||
headers=admin["headers"],
|
||||
)
|
||||
assert resp.status_code == 200, resp.text
|
||||
assert resp.json()["name"] == "Updated By Admin"
|
||||
|
||||
def test_plain_member_cannot_update(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_noupdate_owner")
|
||||
member = _register(client, "grp_api_noupdate_member")
|
||||
group = _create_group(client, owner["headers"], "No Update Group")
|
||||
client.post(f"/api/groups/{group['id']}/join", headers=member["headers"])
|
||||
|
||||
resp = client.patch(
|
||||
f"/api/groups/{group['id']}",
|
||||
json={"name": "Hacked Name"},
|
||||
headers=member["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
def test_non_member_cannot_update(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_strangernoupdate_owner")
|
||||
stranger = _register(client, "grp_api_strangernoupdate_stranger")
|
||||
group = _create_group(client, owner["headers"], "Stranger No Update Group")
|
||||
|
||||
resp = client.patch(
|
||||
f"/api/groups/{group['id']}",
|
||||
json={"name": "Hacked Name"},
|
||||
headers=stranger["headers"],
|
||||
)
|
||||
assert resp.status_code == 403
|
||||
|
||||
|
||||
class TestDeleteGroup:
|
||||
def test_owner_can_delete(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_delete_owner")
|
||||
group = _create_group(client, owner["headers"], "Delete Group")
|
||||
|
||||
resp = client.delete(f"/api/groups/{group['id']}", headers=owner["headers"])
|
||||
assert resp.status_code == 204, resp.text
|
||||
|
||||
after = client.get(f"/api/groups/{group['id']}", headers=owner["headers"])
|
||||
assert after.status_code == 404
|
||||
|
||||
|
||||
class TestListGroups:
|
||||
def test_list_all_groups_paginated(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_list_owner")
|
||||
_create_group(client, owner["headers"], "List Group A")
|
||||
_create_group(client, owner["headers"], "List Group B")
|
||||
|
||||
resp = client.get("/api/groups", params={"limit": 1}, headers=owner["headers"])
|
||||
assert resp.status_code == 200, resp.text
|
||||
body = resp.json()
|
||||
assert len(body["groups"]) == 1
|
||||
assert body["total"] >= 2
|
||||
|
||||
def test_list_mine_only_returns_own_groups(self):
|
||||
client = TestClient(app)
|
||||
owner = _register(client, "grp_api_listmine_owner")
|
||||
other_owner = _register(client, "grp_api_listmine_other")
|
||||
mine = _create_group(client, owner["headers"], "Mine Group")
|
||||
_create_group(client, other_owner["headers"], "Not Mine Group")
|
||||
|
||||
resp = client.get("/api/groups", params={"mine": True}, headers=owner["headers"])
|
||||
assert resp.status_code == 200, resp.text
|
||||
ids = [g["id"] for g in resp.json()["groups"]]
|
||||
assert mine["id"] in ids
|
||||
assert all(
|
||||
g["id"] != mine["id"] or g["owner_id"] == owner["id"]
|
||||
for g in resp.json()["groups"]
|
||||
)
|
||||
# The other owner's group must not appear.
|
||||
other_group_ids = [
|
||||
g["id"] for g in client.get(
|
||||
"/api/groups", params={"mine": True}, headers=other_owner["headers"]
|
||||
).json()["groups"]
|
||||
]
|
||||
assert mine["id"] not in other_group_ids
|
||||
@@ -0,0 +1,406 @@
|
||||
"""Integration tests for /api/profile/me and /api/profile/me/favorites.
|
||||
|
||||
Hits the real app against the configured Postgres (same contract as the
|
||||
other integration tests -- migrations applied first).
|
||||
"""
|
||||
|
||||
import asyncio
|
||||
|
||||
import pytest
|
||||
from fastapi.testclient import TestClient
|
||||
from sqlalchemy import text
|
||||
from sqlalchemy.ext.asyncio import create_async_engine
|
||||
from sqlalchemy.pool import NullPool
|
||||
|
||||
from app.config import settings
|
||||
from app.main import app
|
||||
from app.models.profile import DEFAULT_PRIVACY
|
||||
|
||||
|
||||
def _auth_headers(client: TestClient, username: str) -> dict:
|
||||
resp = client.post(
|
||||
"/api/auth/register",
|
||||
json={
|
||||
"username": username,
|
||||
"email": f"{username}@example.com",
|
||||
"password": "secret123",
|
||||
"date_of_birth": "1990-01-01",
|
||||
},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
return {"Authorization": f"Bearer {resp.json()['access_token']}"}
|
||||
|
||||
|
||||
def _me_id(client: TestClient, headers: dict) -> int:
|
||||
me = client.get("/api/users/me", headers=headers)
|
||||
assert me.status_code == 200, me.text
|
||||
return me.json()["id"]
|
||||
|
||||
|
||||
def _make_world(client: TestClient, headers: dict, name: str = "W") -> int:
|
||||
r = client.post("/api/worlds/", headers=headers, json={"name": name, "visibility": "public"})
|
||||
assert r.status_code == 201, r.text
|
||||
return r.json()["id"]
|
||||
|
||||
|
||||
def _make_asset(client: TestClient, headers: dict, name: str = "A") -> int:
|
||||
"""Insert an asset row directly via raw SQL.
|
||||
|
||||
Not going through POST /api/assets/, and not through the Asset ORM
|
||||
model, deliberately: Asset.asset_type's ENUM column has no
|
||||
values_callable, so SQLAlchemy sends the Python enum *name* (e.g.
|
||||
"IMAGE") to Postgres instead of the lowercase value the DB enum
|
||||
actually stores ("image"), and both the router and a plain ORM insert
|
||||
500/fail on it. That's a pre-existing bug unrelated to this task; these
|
||||
tests only need a real asset row to reference by id, so insert with raw
|
||||
SQL to sidestep the buggy enum type entirely.
|
||||
"""
|
||||
owner_id = _me_id(client, headers)
|
||||
|
||||
async def _create() -> int:
|
||||
engine = create_async_engine(settings.DATABASE_URL, poolclass=NullPool)
|
||||
async with engine.begin() as conn:
|
||||
result = await conn.execute(
|
||||
text(
|
||||
"INSERT INTO assets (name, asset_type, file_path, owner_id, is_public) "
|
||||
"VALUES (:name, 'image', '', :owner_id, false) RETURNING id"
|
||||
),
|
||||
{"name": name, "owner_id": owner_id},
|
||||
)
|
||||
asset_id = result.scalar_one()
|
||||
await engine.dispose()
|
||||
return asset_id
|
||||
|
||||
return asyncio.run(_create())
|
||||
|
||||
|
||||
class TestGetProfile:
|
||||
def test_new_user_gets_the_default(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_default")
|
||||
resp = client.get("/api/profile/me", headers=headers)
|
||||
assert resp.status_code == 200
|
||||
body = resp.json()
|
||||
assert body["is_default"] is True
|
||||
assert body["bio"] is None
|
||||
assert body["avatar_asset_id"] is None
|
||||
assert body["privacy"] == DEFAULT_PRIVACY
|
||||
|
||||
def test_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
assert client.get("/api/profile/me").status_code == 401
|
||||
|
||||
|
||||
class TestPutProfile:
|
||||
def test_save_then_read_back(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_save")
|
||||
asset_id = _make_asset(client, headers)
|
||||
|
||||
put = client.put(
|
||||
"/api/profile/me", headers=headers,
|
||||
json={"bio": "hello world", "avatar_asset_id": asset_id,
|
||||
"privacy": {"profile_visibility": "friends"}},
|
||||
)
|
||||
assert put.status_code == 200, put.text
|
||||
body = put.json()
|
||||
assert body["is_default"] is False
|
||||
assert body["bio"] == "hello world"
|
||||
assert body["avatar_asset_id"] == asset_id
|
||||
assert body["privacy"]["profile_visibility"] == "friends"
|
||||
# unspecified privacy keys keep their default
|
||||
assert body["privacy"]["friends_list_visibility"] == "public"
|
||||
|
||||
got = client.get("/api/profile/me", headers=headers)
|
||||
assert got.status_code == 200
|
||||
assert got.json() == body
|
||||
|
||||
def test_partial_update_preserves_other_fields(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_partial")
|
||||
client.put("/api/profile/me", headers=headers, json={"bio": "first bio"})
|
||||
put2 = client.put("/api/profile/me", headers=headers, json={"privacy": {"favorites_visibility": "private"}})
|
||||
assert put2.status_code == 200, put2.text
|
||||
body = put2.json()
|
||||
assert body["bio"] == "first bio"
|
||||
assert body["privacy"]["favorites_visibility"] == "private"
|
||||
|
||||
def test_other_user_cannot_edit_my_profile(self):
|
||||
"""There is no user_id-scoped edit route at all -- PUT /me always
|
||||
acts on the caller's own JWT identity, so another user's token can
|
||||
never touch this user's profile."""
|
||||
client = TestClient(app)
|
||||
headers_a = _auth_headers(client, "pf_owner")
|
||||
headers_b = _auth_headers(client, "pf_other")
|
||||
|
||||
client.put("/api/profile/me", headers=headers_a, json={"bio": "owner's bio"})
|
||||
client.put("/api/profile/me", headers=headers_b, json={"bio": "other's bio"})
|
||||
|
||||
got_a = client.get("/api/profile/me", headers=headers_a).json()
|
||||
got_b = client.get("/api/profile/me", headers=headers_b).json()
|
||||
assert got_a["bio"] == "owner's bio"
|
||||
assert got_b["bio"] == "other's bio"
|
||||
assert got_a["user_id"] != got_b["user_id"]
|
||||
|
||||
def test_rejects_invalid_avatar_asset_id(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_badasset")
|
||||
resp = client.put("/api/profile/me", headers=headers, json={"avatar_asset_id": 999999})
|
||||
assert resp.status_code == 422
|
||||
|
||||
def test_rejects_over_length_bio(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_longbio")
|
||||
resp = client.put("/api/profile/me", headers=headers, json={"bio": "x" * 501})
|
||||
assert resp.status_code == 422
|
||||
|
||||
def test_accepts_bio_at_max_length(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_maxbio")
|
||||
resp = client.put("/api/profile/me", headers=headers, json={"bio": "x" * 500})
|
||||
assert resp.status_code == 200, resp.text
|
||||
|
||||
def test_rejects_unknown_privacy_key(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_badprivkey")
|
||||
resp = client.put("/api/profile/me", headers=headers, json={"privacy": {"nonsense_key": "public"}})
|
||||
assert resp.status_code == 422
|
||||
|
||||
def test_rejects_invalid_privacy_value(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "pf_badprivval")
|
||||
resp = client.put("/api/profile/me", headers=headers, json={"privacy": {"profile_visibility": "nope"}})
|
||||
assert resp.status_code == 422
|
||||
|
||||
def test_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
resp = client.put("/api/profile/me", json={"bio": "x"})
|
||||
assert resp.status_code == 401
|
||||
|
||||
|
||||
class TestFavorites:
|
||||
def test_new_user_has_no_favorites(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "fav_default")
|
||||
resp = client.get("/api/profile/me/favorites", headers=headers)
|
||||
assert resp.status_code == 200
|
||||
assert resp.json() == {"world_ids": []}
|
||||
|
||||
def test_replace_then_read_back(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "fav_save")
|
||||
w1 = _make_world(client, headers, "W1")
|
||||
w2 = _make_world(client, headers, "W2")
|
||||
|
||||
put = client.put("/api/profile/me/favorites", headers=headers, json={"world_ids": [w1, w2]})
|
||||
assert put.status_code == 200, put.text
|
||||
assert set(put.json()["world_ids"]) == {w1, w2}
|
||||
|
||||
got = client.get("/api/profile/me/favorites", headers=headers)
|
||||
assert set(got.json()["world_ids"]) == {w1, w2}
|
||||
|
||||
def test_replace_is_a_full_replace_not_append(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "fav_replace")
|
||||
w1 = _make_world(client, headers, "W1")
|
||||
w2 = _make_world(client, headers, "W2")
|
||||
|
||||
client.put("/api/profile/me/favorites", headers=headers, json={"world_ids": [w1]})
|
||||
second = client.put("/api/profile/me/favorites", headers=headers, json={"world_ids": [w2]})
|
||||
assert second.json()["world_ids"] == [w2]
|
||||
|
||||
got = client.get("/api/profile/me/favorites", headers=headers)
|
||||
assert got.json()["world_ids"] == [w2]
|
||||
|
||||
def test_replace_with_empty_list_clears_favorites(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "fav_clear")
|
||||
w1 = _make_world(client, headers, "W1")
|
||||
client.put("/api/profile/me/favorites", headers=headers, json={"world_ids": [w1]})
|
||||
cleared = client.put("/api/profile/me/favorites", headers=headers, json={"world_ids": []})
|
||||
assert cleared.status_code == 200
|
||||
assert cleared.json() == {"world_ids": []}
|
||||
|
||||
def test_rejects_nonexistent_world_id(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "fav_badworld")
|
||||
resp = client.put("/api/profile/me/favorites", headers=headers, json={"world_ids": [999999]})
|
||||
assert resp.status_code == 422
|
||||
|
||||
def test_rejects_nonexistent_world_id_mixed_with_valid(self):
|
||||
client = TestClient(app)
|
||||
headers = _auth_headers(client, "fav_mixed")
|
||||
w1 = _make_world(client, headers, "W1")
|
||||
resp = client.put("/api/profile/me/favorites", headers=headers, json={"world_ids": [w1, 999999]})
|
||||
assert resp.status_code == 422
|
||||
# nothing partially applied
|
||||
got = client.get("/api/profile/me/favorites", headers=headers)
|
||||
assert got.json()["world_ids"] == []
|
||||
|
||||
def test_favorites_isolated_per_user(self):
|
||||
client = TestClient(app)
|
||||
headers_a = _auth_headers(client, "fav_owner")
|
||||
headers_b = _auth_headers(client, "fav_other")
|
||||
w1 = _make_world(client, headers_a, "W1")
|
||||
|
||||
client.put("/api/profile/me/favorites", headers=headers_a, json={"world_ids": [w1]})
|
||||
got_b = client.get("/api/profile/me/favorites", headers=headers_b)
|
||||
assert got_b.json()["world_ids"] == []
|
||||
|
||||
def test_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
assert client.get("/api/profile/me/favorites").status_code == 401
|
||||
assert client.put("/api/profile/me/favorites", json={"world_ids": []}).status_code == 401
|
||||
|
||||
|
||||
class TestPublicProfile:
|
||||
def test_public_profile_full_view(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_alice")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_bob")
|
||||
|
||||
w1 = _make_world(client, h_alice, "AliceWorld")
|
||||
asset_id = _make_asset(client, h_alice, "AliceAsset")
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={"bio": "Hi, I am Alice", "avatar_asset_id": asset_id},
|
||||
)
|
||||
client.put("/api/profile/me/favorites", headers=h_alice, json={"world_ids": [w1]})
|
||||
|
||||
resp = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp.status_code == 200, resp.text
|
||||
data = resp.json()
|
||||
assert data["user_id"] == alice_id
|
||||
assert data["username"] == "pub_alice"
|
||||
assert data["bio"] == "Hi, I am Alice"
|
||||
assert data["avatar_asset_id"] == asset_id
|
||||
assert data["is_restricted"] is False
|
||||
assert len(data["favorites"]) == 1
|
||||
assert data["favorites"][0]["id"] == w1
|
||||
assert data["favorites"][0]["name"] == "AliceWorld"
|
||||
assert "email" not in data
|
||||
assert "password" not in data
|
||||
|
||||
def test_public_profile_not_found(self):
|
||||
client = TestClient(app)
|
||||
h_bob = _auth_headers(client, "pub_nf_bob")
|
||||
resp = client.get("/api/profile/999999", headers=h_bob)
|
||||
assert resp.status_code == 404
|
||||
|
||||
def test_public_profile_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
assert client.get("/api/profile/1").status_code == 401
|
||||
|
||||
def test_public_profile_private_visibility(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_priv_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_priv_b")
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={"bio": "Top secret bio", "privacy": {"profile_visibility": "private"}},
|
||||
)
|
||||
|
||||
resp_bob = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp_bob.status_code == 200
|
||||
data_bob = resp_bob.json()
|
||||
assert data_bob["is_restricted"] is True
|
||||
assert data_bob["bio"] is None
|
||||
assert data_bob["favorites"] == []
|
||||
assert data_bob["friends"] == []
|
||||
|
||||
# Alice viewing herself is not restricted
|
||||
resp_alice = client.get(f"/api/profile/{alice_id}", headers=h_alice)
|
||||
assert resp_alice.status_code == 200
|
||||
assert resp_alice.json()["is_restricted"] is False
|
||||
assert resp_alice.json()["bio"] == "Top secret bio"
|
||||
|
||||
def test_public_profile_friends_only_visibility(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_fo_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_fo_b")
|
||||
bob_id = _me_id(client, h_bob)
|
||||
h_charlie = _auth_headers(client, "pub_fo_c")
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={"bio": "Friends only bio", "privacy": {"profile_visibility": "friends"}},
|
||||
)
|
||||
|
||||
# Charlie is not a friend -> restricted
|
||||
resp_c = client.get(f"/api/profile/{alice_id}", headers=h_charlie)
|
||||
assert resp_c.json()["is_restricted"] is True
|
||||
assert resp_c.json()["bio"] is None
|
||||
|
||||
# Bob becomes friends with Alice
|
||||
req = client.post("/api/friends/requests", headers=h_bob, json={"user_id": alice_id})
|
||||
req_id = req.json()["id"]
|
||||
client.post(f"/api/friends/requests/{req_id}/accept", headers=h_alice)
|
||||
|
||||
# Now Bob sees full profile and friends list contains Bob
|
||||
resp_b = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp_b.json()["is_restricted"] is False
|
||||
assert resp_b.json()["bio"] == "Friends only bio"
|
||||
assert any(f["id"] == bob_id for f in resp_b.json()["friends"])
|
||||
|
||||
def test_public_profile_blocked_user_gets_restricted(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_blk_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_dan = _auth_headers(client, "pub_blk_d")
|
||||
dan_id = _me_id(client, h_dan)
|
||||
|
||||
client.put("/api/profile/me", headers=h_alice, json={"bio": "Alice public bio"})
|
||||
client.post(f"/api/friends/{dan_id}/block", headers=h_alice)
|
||||
|
||||
# Dan viewing Alice gets restricted view
|
||||
resp_dan = client.get(f"/api/profile/{alice_id}", headers=h_dan)
|
||||
assert resp_dan.status_code == 200
|
||||
assert resp_dan.json()["is_restricted"] is True
|
||||
assert resp_dan.json()["bio"] is None
|
||||
|
||||
# Alice viewing Dan gets restricted view
|
||||
resp_alice = client.get(f"/api/profile/{dan_id}", headers=h_alice)
|
||||
assert resp_alice.status_code == 200
|
||||
assert resp_alice.json()["is_restricted"] is True
|
||||
|
||||
def test_public_profile_selective_favorites_and_friends_privacy(self):
|
||||
client = TestClient(app)
|
||||
h_alice = _auth_headers(client, "pub_sec_a")
|
||||
alice_id = _me_id(client, h_alice)
|
||||
h_bob = _auth_headers(client, "pub_sec_b")
|
||||
bob_id = _me_id(client, h_bob)
|
||||
w1 = _make_world(client, h_alice, "WorldSec")
|
||||
|
||||
client.put("/api/profile/me/favorites", headers=h_alice, json={"world_ids": [w1]})
|
||||
req = client.post("/api/friends/requests", headers=h_bob, json={"user_id": alice_id})
|
||||
req_id = req.json()["id"]
|
||||
client.post(f"/api/friends/requests/{req_id}/accept", headers=h_alice)
|
||||
|
||||
client.put(
|
||||
"/api/profile/me",
|
||||
headers=h_alice,
|
||||
json={
|
||||
"bio": "Bio is public",
|
||||
"privacy": {
|
||||
"profile_visibility": "public",
|
||||
"favorites_visibility": "private",
|
||||
"friends_list_visibility": "private",
|
||||
},
|
||||
},
|
||||
)
|
||||
|
||||
resp = client.get(f"/api/profile/{alice_id}", headers=h_bob)
|
||||
assert resp.status_code == 200
|
||||
data = resp.json()
|
||||
assert data["bio"] == "Bio is public"
|
||||
assert data["favorites"] == []
|
||||
assert data["friends"] == []
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
"""The auth endpoints are rate-limited per client IP."""
|
||||
|
||||
import pytest
|
||||
from fastapi import Depends, FastAPI
|
||||
from fastapi.testclient import TestClient
|
||||
|
||||
from app import rate_limit
|
||||
@@ -54,3 +55,70 @@ def test_limiter_window_is_per_key():
|
||||
with pytest.raises(Exception):
|
||||
limiter.check("a")
|
||||
limiter.check("b") # different key, unaffected
|
||||
|
||||
|
||||
def _make_named_limit_app():
|
||||
"""A tiny standalone app exercising two independent named limits, so
|
||||
these tests don't depend on any sibling endpoint existing yet."""
|
||||
limit_a = rate_limit.rate_limit("test_named_a", max_hits=2, window_seconds=60)
|
||||
limit_b = rate_limit.rate_limit("test_named_b", max_hits=2, window_seconds=60)
|
||||
|
||||
app = FastAPI()
|
||||
|
||||
@app.post("/a", dependencies=[Depends(limit_a)])
|
||||
def _a():
|
||||
return {"ok": True}
|
||||
|
||||
@app.post("/b", dependencies=[Depends(limit_b)])
|
||||
def _b():
|
||||
return {"ok": True}
|
||||
|
||||
return TestClient(app)
|
||||
|
||||
|
||||
def test_named_limits_do_not_share_counters():
|
||||
client = _make_named_limit_app()
|
||||
|
||||
# Burn out limit "a" entirely.
|
||||
assert client.post("/a").status_code == 200
|
||||
assert client.post("/a").status_code == 200
|
||||
r = client.post("/a")
|
||||
assert r.status_code == 429
|
||||
assert "Retry-After" in r.headers
|
||||
|
||||
# Limit "b" is untouched -- same process, same client IP, different name.
|
||||
assert client.post("/b").status_code == 200
|
||||
assert client.post("/b").status_code == 200
|
||||
assert client.post("/b").status_code == 429
|
||||
|
||||
|
||||
def test_named_limit_returns_429_with_retry_after_once_exhausted():
|
||||
client = _make_named_limit_app()
|
||||
client.post("/a")
|
||||
client.post("/a")
|
||||
r = client.post("/a")
|
||||
assert r.status_code == 429
|
||||
retry_after = r.headers["Retry-After"]
|
||||
assert int(retry_after) >= 1
|
||||
|
||||
|
||||
def test_named_limit_is_a_noop_when_rate_limiting_disabled():
|
||||
prev = settings.RATE_LIMIT_ENABLED
|
||||
settings.RATE_LIMIT_ENABLED = False
|
||||
try:
|
||||
client = _make_named_limit_app()
|
||||
codes = [client.post("/a").status_code for _ in range(10)]
|
||||
assert codes == [200] * 10
|
||||
finally:
|
||||
settings.RATE_LIMIT_ENABLED = prev
|
||||
|
||||
|
||||
def test_reset_all_clears_named_limiters_too():
|
||||
client = _make_named_limit_app()
|
||||
client.post("/a")
|
||||
client.post("/a")
|
||||
assert client.post("/a").status_code == 429
|
||||
|
||||
rate_limit.reset_all()
|
||||
|
||||
assert client.post("/a").status_code == 200
|
||||
|
||||
@@ -0,0 +1,317 @@
|
||||
"""Integration tests for the friends/follow/block API:
|
||||
|
||||
- POST /api/friends/requests
|
||||
- GET /api/friends/requests
|
||||
- POST /api/friends/requests/{id}/accept
|
||||
- POST /api/friends/requests/{id}/decline
|
||||
- DELETE /api/friends/{user_id}
|
||||
- POST /api/friends/{user_id}/follow
|
||||
- DELETE /api/friends/{user_id}/follow
|
||||
- POST /api/friends/{user_id}/block
|
||||
- DELETE /api/friends/{user_id}/block
|
||||
- GET /api/friends
|
||||
- GET /api/friends/following
|
||||
- GET /api/friends/blocked
|
||||
|
||||
app/routers/social_friends.py, built on the merged models in
|
||||
app/models/social.py (Friendship/Follow/Block).
|
||||
"""
|
||||
|
||||
from fastapi.testclient import TestClient
|
||||
|
||||
from app.main import app
|
||||
|
||||
|
||||
def _register(client: TestClient, username: str) -> dict:
|
||||
resp = client.post(
|
||||
"/api/auth/register",
|
||||
json={
|
||||
"username": username,
|
||||
"email": f"{username}@example.com",
|
||||
"password": "secret123",
|
||||
"date_of_birth": "1990-01-01",
|
||||
},
|
||||
)
|
||||
assert resp.status_code == 201, resp.text
|
||||
token = resp.json()["access_token"]
|
||||
headers = {"Authorization": f"Bearer {token}"}
|
||||
me = client.get("/api/users/me", headers=headers)
|
||||
assert me.status_code == 200, me.text
|
||||
return {"headers": headers, "id": me.json()["id"]}
|
||||
|
||||
|
||||
class TestFriendRequestFlow:
|
||||
def test_send_list_accept_makes_mutual_friendship(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "fr_flow_a")
|
||||
b = _register(client, "fr_flow_b")
|
||||
|
||||
resp = client.post("/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"])
|
||||
assert resp.status_code == 201, resp.text
|
||||
request_id = resp.json()["id"]
|
||||
assert resp.json()["status"] == "pending"
|
||||
|
||||
incoming = client.get("/api/friends/requests", headers=b["headers"])
|
||||
assert incoming.status_code == 200
|
||||
ids = [r["id"] for r in incoming.json()["requests"]]
|
||||
assert request_id in ids
|
||||
|
||||
# Requester doesn't see it in their own incoming list.
|
||||
a_incoming = client.get("/api/friends/requests", headers=a["headers"])
|
||||
assert a_incoming.json()["requests"] == []
|
||||
|
||||
accept = client.post(f"/api/friends/requests/{request_id}/accept", headers=b["headers"])
|
||||
assert accept.status_code == 200, accept.text
|
||||
assert accept.json()["status"] == "accepted"
|
||||
|
||||
# Mutual: shows up in both users' friend lists.
|
||||
a_friends = client.get("/api/friends", headers=a["headers"]).json()["friends"]
|
||||
b_friends = client.get("/api/friends", headers=b["headers"]).json()["friends"]
|
||||
assert any(u["id"] == b["id"] for u in a_friends)
|
||||
assert any(u["id"] == a["id"] for u in b_friends)
|
||||
|
||||
def test_decline_removes_request_and_allows_re_request(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "fr_decl_a")
|
||||
b = _register(client, "fr_decl_b")
|
||||
|
||||
resp = client.post("/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"])
|
||||
request_id = resp.json()["id"]
|
||||
|
||||
decline = client.post(f"/api/friends/requests/{request_id}/decline", headers=b["headers"])
|
||||
assert decline.status_code == 200, decline.text
|
||||
|
||||
assert client.get("/api/friends/requests", headers=b["headers"]).json()["requests"] == []
|
||||
|
||||
# A can send a new request now that the old one is gone.
|
||||
resp2 = client.post("/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"])
|
||||
assert resp2.status_code == 201, resp2.text
|
||||
|
||||
def test_accept_or_decline_of_others_request_is_404_not_403(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "fr_enum_a")
|
||||
b = _register(client, "fr_enum_b")
|
||||
c = _register(client, "fr_enum_c")
|
||||
|
||||
resp = client.post("/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"])
|
||||
request_id = resp.json()["id"]
|
||||
|
||||
# c is neither requester nor addressee -- must not be able to act on it,
|
||||
# and must not be able to distinguish "not yours" from "doesn't exist".
|
||||
accept = client.post(f"/api/friends/requests/{request_id}/accept", headers=c["headers"])
|
||||
assert accept.status_code == 404
|
||||
|
||||
decline = client.post(f"/api/friends/requests/{request_id}/decline", headers=c["headers"])
|
||||
assert decline.status_code == 404
|
||||
|
||||
nonexistent = client.post("/api/friends/requests/999999999/accept", headers=c["headers"])
|
||||
assert nonexistent.status_code == 404
|
||||
|
||||
def test_unfriend_removes_mutual_friendship(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "fr_unfr_a")
|
||||
b = _register(client, "fr_unfr_b")
|
||||
|
||||
request_id = client.post(
|
||||
"/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"]
|
||||
).json()["id"]
|
||||
client.post(f"/api/friends/requests/{request_id}/accept", headers=b["headers"])
|
||||
|
||||
unfriend = client.delete(f"/api/friends/{a['id']}", headers=b["headers"])
|
||||
assert unfriend.status_code == 200, unfriend.text
|
||||
|
||||
assert client.get("/api/friends", headers=a["headers"]).json()["friends"] == []
|
||||
assert client.get("/api/friends", headers=b["headers"]).json()["friends"] == []
|
||||
|
||||
# Idempotency / no dangling state: unfriending again is a clean 404, not 500.
|
||||
again = client.delete(f"/api/friends/{a['id']}", headers=b["headers"])
|
||||
assert again.status_code == 404
|
||||
|
||||
|
||||
class TestSelfAndDuplicateRejection:
|
||||
def test_self_request_rejected(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "self_req_a")
|
||||
resp = client.post("/api/friends/requests", json={"user_id": a["id"]}, headers=a["headers"])
|
||||
assert resp.status_code == 400
|
||||
|
||||
def test_self_follow_rejected(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "self_follow_a")
|
||||
resp = client.post(f"/api/friends/{a['id']}/follow", headers=a["headers"])
|
||||
assert resp.status_code == 400
|
||||
|
||||
def test_self_block_rejected(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "self_block_a")
|
||||
resp = client.post(f"/api/friends/{a['id']}/block", headers=a["headers"])
|
||||
assert resp.status_code == 400
|
||||
|
||||
def test_duplicate_friend_request_is_conflict_not_500(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "dup_req_a")
|
||||
b = _register(client, "dup_req_b")
|
||||
assert client.post("/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"]).status_code == 201
|
||||
dup = client.post("/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"])
|
||||
assert dup.status_code == 409
|
||||
|
||||
def test_reverse_duplicate_friend_request_is_conflict(self):
|
||||
"""b requesting a while a's request to b is still pending is treated
|
||||
as a duplicate of the same pair, not a second independent request."""
|
||||
client = TestClient(app)
|
||||
a = _register(client, "dup_rev_a")
|
||||
b = _register(client, "dup_rev_b")
|
||||
assert client.post("/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"]).status_code == 201
|
||||
reverse = client.post("/api/friends/requests", json={"user_id": a["id"]}, headers=b["headers"])
|
||||
assert reverse.status_code == 409
|
||||
|
||||
def test_duplicate_follow_is_conflict_not_500(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "dup_follow_a")
|
||||
b = _register(client, "dup_follow_b")
|
||||
assert client.post(f"/api/friends/{b['id']}/follow", headers=a["headers"]).status_code == 201
|
||||
dup = client.post(f"/api/friends/{b['id']}/follow", headers=a["headers"])
|
||||
assert dup.status_code == 409
|
||||
|
||||
def test_duplicate_block_is_conflict_not_500(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "dup_block_a")
|
||||
b = _register(client, "dup_block_b")
|
||||
assert client.post(f"/api/friends/{b['id']}/block", headers=a["headers"]).status_code == 201
|
||||
dup = client.post(f"/api/friends/{b['id']}/block", headers=a["headers"])
|
||||
assert dup.status_code == 409
|
||||
|
||||
def test_friend_request_to_nonexistent_user_is_404(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "req_missing_a")
|
||||
resp = client.post("/api/friends/requests", json={"user_id": 999999999}, headers=a["headers"])
|
||||
assert resp.status_code == 404
|
||||
|
||||
|
||||
class TestFollow:
|
||||
def test_follow_unfollow_and_list(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "follow_flow_a")
|
||||
b = _register(client, "follow_flow_b")
|
||||
|
||||
follow = client.post(f"/api/friends/{b['id']}/follow", headers=a["headers"])
|
||||
assert follow.status_code == 201, follow.text
|
||||
|
||||
following = client.get("/api/friends/following", headers=a["headers"]).json()["following"]
|
||||
assert any(u["id"] == b["id"] for u in following)
|
||||
|
||||
# One-way: b does not follow a.
|
||||
b_following = client.get("/api/friends/following", headers=b["headers"]).json()["following"]
|
||||
assert b_following == []
|
||||
|
||||
unfollow = client.delete(f"/api/friends/{b['id']}/follow", headers=a["headers"])
|
||||
assert unfollow.status_code == 200, unfollow.text
|
||||
|
||||
following_after = client.get("/api/friends/following", headers=a["headers"]).json()["following"]
|
||||
assert following_after == []
|
||||
|
||||
# Unfollowing again is a clean 404, not 500.
|
||||
again = client.delete(f"/api/friends/{b['id']}/follow", headers=a["headers"])
|
||||
assert again.status_code == 404
|
||||
|
||||
def test_follow_requires_auth(self):
|
||||
client = TestClient(app)
|
||||
b = _register(client, "follow_noauth_b")
|
||||
resp = client.post(f"/api/friends/{b['id']}/follow", json={})
|
||||
assert resp.status_code == 401
|
||||
|
||||
|
||||
class TestBlock:
|
||||
def test_block_clears_existing_friendship_and_follow(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "block_clear_a")
|
||||
b = _register(client, "block_clear_b")
|
||||
|
||||
request_id = client.post(
|
||||
"/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"]
|
||||
).json()["id"]
|
||||
client.post(f"/api/friends/requests/{request_id}/accept", headers=b["headers"])
|
||||
client.post(f"/api/friends/{a['id']}/follow", headers=b["headers"])
|
||||
|
||||
assert any(
|
||||
u["id"] == b["id"] for u in client.get("/api/friends", headers=a["headers"]).json()["friends"]
|
||||
)
|
||||
assert any(
|
||||
u["id"] == a["id"]
|
||||
for u in client.get("/api/friends/following", headers=b["headers"]).json()["following"]
|
||||
)
|
||||
|
||||
block = client.post(f"/api/friends/{b['id']}/block", headers=a["headers"])
|
||||
assert block.status_code == 201, block.text
|
||||
|
||||
assert client.get("/api/friends", headers=a["headers"]).json()["friends"] == []
|
||||
assert client.get("/api/friends", headers=b["headers"]).json()["friends"] == []
|
||||
assert client.get("/api/friends/following", headers=b["headers"]).json()["following"] == []
|
||||
|
||||
blocked_list = client.get("/api/friends/blocked", headers=a["headers"]).json()["blocked"]
|
||||
assert any(u["id"] == b["id"] for u in blocked_list)
|
||||
|
||||
def test_block_prevents_new_friend_request_and_follow(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "block_prevent_a")
|
||||
b = _register(client, "block_prevent_b")
|
||||
|
||||
client.post(f"/api/friends/{b['id']}/block", headers=a["headers"])
|
||||
|
||||
req = client.post("/api/friends/requests", json={"user_id": a["id"]}, headers=b["headers"])
|
||||
assert req.status_code == 403
|
||||
|
||||
follow = client.post(f"/api/friends/{a['id']}/follow", headers=b["headers"])
|
||||
assert follow.status_code == 403
|
||||
|
||||
def test_unblock_removes_block(self):
|
||||
client = TestClient(app)
|
||||
a = _register(client, "unblock_a")
|
||||
b = _register(client, "unblock_b")
|
||||
|
||||
client.post(f"/api/friends/{b['id']}/block", headers=a["headers"])
|
||||
unblock = client.delete(f"/api/friends/{b['id']}/block", headers=a["headers"])
|
||||
assert unblock.status_code == 200, unblock.text
|
||||
|
||||
assert client.get("/api/friends/blocked", headers=a["headers"]).json()["blocked"] == []
|
||||
|
||||
# Idempotency: unblocking again is a clean 404, not 500.
|
||||
again = client.delete(f"/api/friends/{b['id']}/block", headers=a["headers"])
|
||||
assert again.status_code == 404
|
||||
|
||||
# After unblock, a fresh follow/request works again.
|
||||
assert client.post(f"/api/friends/{a['id']}/follow", headers=b["headers"]).status_code == 201
|
||||
|
||||
|
||||
class TestDataIsolation:
|
||||
def test_list_endpoints_are_scoped_to_caller(self):
|
||||
"""A third party's friends/following/blocked lists must never leak
|
||||
into another user's response."""
|
||||
client = TestClient(app)
|
||||
a = _register(client, "iso_a")
|
||||
b = _register(client, "iso_b")
|
||||
c = _register(client, "iso_c")
|
||||
|
||||
request_id = client.post(
|
||||
"/api/friends/requests", json={"user_id": b["id"]}, headers=a["headers"]
|
||||
).json()["id"]
|
||||
client.post(f"/api/friends/requests/{request_id}/accept", headers=b["headers"])
|
||||
client.post(f"/api/friends/{b['id']}/follow", headers=a["headers"])
|
||||
client.post(f"/api/friends/{b['id']}/block", headers=c["headers"])
|
||||
|
||||
c_friends = client.get("/api/friends", headers=c["headers"]).json()["friends"]
|
||||
c_following = client.get("/api/friends/following", headers=c["headers"]).json()["following"]
|
||||
assert c_friends == []
|
||||
assert c_following == []
|
||||
|
||||
# c's block of b must not appear in a's or b's blocked list.
|
||||
a_blocked = client.get("/api/friends/blocked", headers=a["headers"]).json()["blocked"]
|
||||
assert a_blocked == []
|
||||
|
||||
def test_requires_auth_on_all_endpoints(self):
|
||||
client = TestClient(app)
|
||||
assert client.get("/api/friends").status_code == 401
|
||||
assert client.get("/api/friends/requests").status_code == 401
|
||||
assert client.get("/api/friends/following").status_code == 401
|
||||
assert client.get("/api/friends/blocked").status_code == 401
|
||||
assert client.post("/api/friends/requests", json={"user_id": 1}).status_code == 401
|
||||
@@ -0,0 +1,194 @@
|
||||
"""Unit tests for app.services.text_filter (docs/planning/social.md §4/§5 US-4).
|
||||
|
||||
Pure, side-effect-free service -- no DB/Redis fixtures needed.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
from app.services.text_filter import (
|
||||
DEFAULT_TERMS_PATH,
|
||||
FilterAction,
|
||||
FilterMode,
|
||||
FilterResult,
|
||||
ListBasedTextFilter,
|
||||
TextFilter,
|
||||
default_text_filter,
|
||||
load_terms,
|
||||
)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def redact_filter() -> ListBasedTextFilter:
|
||||
return ListBasedTextFilter(terms=["badword", "shoot"], mode=FilterMode.REDACT)
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def reject_filter() -> ListBasedTextFilter:
|
||||
return ListBasedTextFilter(terms=["badword", "shoot"], mode=FilterMode.REJECT)
|
||||
|
||||
|
||||
class TestAllowPath:
|
||||
def test_clean_text_is_allowed_unchanged(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("hello there, how are you today?")
|
||||
assert result.action is FilterAction.ALLOW
|
||||
assert result.filtered_text == "hello there, how are you today?"
|
||||
assert result.matched_terms == ()
|
||||
|
||||
def test_message_with_no_matches(self, reject_filter: ListBasedTextFilter) -> None:
|
||||
# Distinct from the clean-text case above: exercises the reject-mode
|
||||
# filter's no-match path specifically (mode should not matter when
|
||||
# nothing matches).
|
||||
text = "let's meet at the plaza around noon"
|
||||
result = reject_filter.check(text)
|
||||
assert result.action is FilterAction.ALLOW
|
||||
assert result.filtered_text == text
|
||||
assert result.matched_terms == ()
|
||||
|
||||
|
||||
class TestRedactPath:
|
||||
def test_exact_match_is_redacted(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("don't be a badword about it")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert result.matched_terms == ("badword",)
|
||||
assert "badword" not in result.filtered_text
|
||||
assert result.filtered_text == "don't be a ******* about it"
|
||||
|
||||
def test_multiple_distinct_matches(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("badword, don't shoot!")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert set(result.matched_terms) == {"badword", "shoot"}
|
||||
assert "badword" not in result.filtered_text
|
||||
assert "shoot" not in result.filtered_text
|
||||
# Length is preserved (asterisks replace matched spans 1:1).
|
||||
assert len(result.filtered_text) == len("badword, don't shoot!")
|
||||
|
||||
def test_redaction_char_is_configurable(self) -> None:
|
||||
f = ListBasedTextFilter(terms=["badword"], mode=FilterMode.REDACT, redaction_char="#")
|
||||
result = f.check("that's a badword thing to say")
|
||||
assert result.filtered_text == "that's a ####### thing to say"
|
||||
|
||||
|
||||
class TestRejectPath:
|
||||
def test_match_is_rejected_and_text_left_intact(self, reject_filter: ListBasedTextFilter) -> None:
|
||||
text = "stop, badword!"
|
||||
result = reject_filter.check(text)
|
||||
assert result.action is FilterAction.REJECT
|
||||
assert result.matched_terms == ("badword",)
|
||||
# Reject mode does not mutate the text -- callers are expected to
|
||||
# not store/deliver it at all, based on `action`.
|
||||
assert result.filtered_text == text
|
||||
|
||||
|
||||
class TestNormalization:
|
||||
def test_leetspeak_variant_is_caught(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
# "b4dw0rd" -> normalizes to "badword" via the leet map (4->a, 0->o).
|
||||
result = redact_filter.check("you're being a b4dw0rd right now")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert result.matched_terms == ("badword",)
|
||||
|
||||
def test_separators_between_letters_are_stripped(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("that is b.a.d.w.o.r.d behavior")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert result.matched_terms == ("badword",)
|
||||
|
||||
def test_spacing_between_letters_is_stripped(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("b a d w o r d, seriously")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert result.matched_terms == ("badword",)
|
||||
|
||||
def test_case_folding(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("BADWORD in all caps")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert result.matched_terms == ("badword",)
|
||||
|
||||
def test_symbol_lookalikes(self) -> None:
|
||||
# @ -> a, $ -> s: "@ss" should normalize to "ass".
|
||||
f = ListBasedTextFilter(terms=["ass"], mode=FilterMode.REDACT)
|
||||
result = f.check("what an @$$ move")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert result.matched_terms == ("ass",)
|
||||
|
||||
|
||||
class TestEmptyAndWhitespace:
|
||||
def test_empty_string(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("")
|
||||
assert result.action is FilterAction.ALLOW
|
||||
assert result.filtered_text == ""
|
||||
assert result.matched_terms == ()
|
||||
|
||||
def test_whitespace_only_string(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
text = " \t\n "
|
||||
result = redact_filter.check(text)
|
||||
assert result.action is FilterAction.ALLOW
|
||||
assert result.filtered_text == text
|
||||
assert result.matched_terms == ()
|
||||
|
||||
def test_punctuation_only_string_has_nothing_to_normalize(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
# No alnum characters survive normalization at all -- must not
|
||||
# crash on an empty normalized string / empty index_map.
|
||||
result = redact_filter.check("...!!!???")
|
||||
assert result.action is FilterAction.ALLOW
|
||||
assert result.matched_terms == ()
|
||||
|
||||
|
||||
class TestConfigurability:
|
||||
def test_custom_term_list_is_used_instead_of_default(self) -> None:
|
||||
f = ListBasedTextFilter(terms=["zzzcustomzzz"], mode=FilterMode.REDACT)
|
||||
result = f.check("this contains zzzcustomzzz right here")
|
||||
assert result.action is FilterAction.REDACT
|
||||
assert result.matched_terms == ("zzzcustomzzz",)
|
||||
# Default list terms should NOT match since we overrode the list.
|
||||
result2 = f.check("this is fucking unrelated")
|
||||
assert result2.action is FilterAction.ALLOW
|
||||
|
||||
def test_duplicate_and_blank_terms_are_deduped(self) -> None:
|
||||
f = ListBasedTextFilter(terms=["badword", "badword", " ", ""], mode=FilterMode.REDACT)
|
||||
assert f._terms == ("badword",)
|
||||
|
||||
def test_default_terms_file_loads_and_is_nonempty(self) -> None:
|
||||
terms = load_terms()
|
||||
assert isinstance(terms, list)
|
||||
assert len(terms) > 0
|
||||
assert all(isinstance(t, str) and t for t in terms)
|
||||
|
||||
def test_default_terms_path_exists(self) -> None:
|
||||
assert DEFAULT_TERMS_PATH.exists()
|
||||
assert DEFAULT_TERMS_PATH.suffix == ".json"
|
||||
|
||||
def test_load_terms_from_explicit_path(self, tmp_path: Path) -> None:
|
||||
custom = tmp_path / "custom_terms.json"
|
||||
custom.write_text('{"terms": ["foo", "bar"]}', encoding="utf-8")
|
||||
assert load_terms(custom) == ["foo", "bar"]
|
||||
|
||||
def test_default_text_filter_factory_matches_default_list(self) -> None:
|
||||
f = default_text_filter(mode=FilterMode.REJECT)
|
||||
result = f.check("that's fucking ridiculous")
|
||||
assert result.action is FilterAction.REJECT
|
||||
assert "fuck" in result.matched_terms
|
||||
|
||||
|
||||
class TestProtocol:
|
||||
def test_list_based_filter_satisfies_text_filter_protocol(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
assert isinstance(redact_filter, TextFilter)
|
||||
|
||||
def test_check_returns_filter_result(self, redact_filter: ListBasedTextFilter) -> None:
|
||||
result = redact_filter.check("hi")
|
||||
assert isinstance(result, FilterResult)
|
||||
|
||||
def test_a_third_party_style_implementation_satisfies_the_protocol(self) -> None:
|
||||
# Demonstrates the extension point: any object with a matching
|
||||
# `check` method satisfies TextFilter without inheriting from
|
||||
# anything -- this is how a future third-party provider would plug
|
||||
# in without touching this module.
|
||||
class AlwaysAllow:
|
||||
def check(self, text: str) -> FilterResult:
|
||||
return FilterResult(action=FilterAction.ALLOW, filtered_text=text, matched_terms=())
|
||||
|
||||
provider: TextFilter = AlwaysAllow()
|
||||
assert isinstance(provider, TextFilter)
|
||||
result = provider.check("anything at all, even fuck")
|
||||
assert result.action is FilterAction.ALLOW
|
||||
Reference in New Issue
Block a user