Address review feedback: Research and design GDScript sandboxing approach #19

2026-08-18T02:24:33Z

architect-bot commented

2026-08-18 02:24:33 +00:00

Fixes PR #16's blocking issue: root project.godot had been accidentally overwritten with the sandbox probe's config. Reverted to match main exactly (verified: git diff origin/main -- project.godot is empty) — sandbox_probe/project.godot keeps the probe's own separate config, untouched.

Supersedes #16.

Fixes PR #16's blocking issue: root project.godot had been accidentally overwritten with the sandbox probe's config. Reverted to match main exactly (verified: git diff origin/main -- project.godot is empty) — sandbox_probe/project.godot keeps the probe's own separate config, untouched. Supersedes #16.

architect-bot added 26 commits 2026-08-18 02:24:34 +00:00

Recovered orphaned WIP before switching to a new task 9e2e0ed921

WIP checkpoint: Research and design GDScript sandboxing approach 8b17cc3ddd

WIP checkpoint: Research and design GDScript sandboxing approach 42914aec85

WIP checkpoint: Research and design GDScript sandboxing approach a3fc36db19

WIP checkpoint: Research and design GDScript sandboxing approach a3cdb18a5c

WIP checkpoint: Research and design GDScript sandboxing approach 19a63bda11

WIP checkpoint: Research and design GDScript sandboxing approach 0b5034759c

WIP checkpoint: Research and design GDScript sandboxing approach 68b783909d

WIP checkpoint: Research and design GDScript sandboxing approach c931670e9d

WIP checkpoint: Research and design GDScript sandboxing approach 62447258b2

WIP checkpoint: Research and design GDScript sandboxing approach a1846f34b5

WIP checkpoint: Research and design GDScript sandboxing approach a863bb2ab4

WIP checkpoint: Research and design GDScript sandboxing approach 9450fb86d0

WIP checkpoint: Research and design GDScript sandboxing approach fed16f1f1d

WIP checkpoint: Research and design GDScript sandboxing approach ae6ccc3e5f

WIP checkpoint: Research and design GDScript sandboxing approach d422eff912

Recovered orphaned WIP before switching to a new task bd8f311a96

WIP checkpoint: Research and design GDScript sandboxing approach 20be724115

WIP checkpoint: Research and design GDScript sandboxing approach 2df195734b

WIP checkpoint: Research and design GDScript sandboxing approach 8d50de075d

WIP checkpoint: Research and design GDScript sandboxing approach 0b00b01502

WIP checkpoint: Research and design GDScript sandboxing approach a576c25124

WIP checkpoint: Research and design GDScript sandboxing approach 119cd9400a

Document GDScript sandboxing findings and recommendation 4da8687f2c

Verified all three options from the task against Godot 4.6.2 directly
(godot --headless), rather than trusting the probe scripts' own printed
output from earlier sessions:
- ScriptServer doesn't exist as a class; no disable_os/disable_file_access/
  disable_network project settings exist either. Nothing to configure.
- SubViewport isolates rendering/input only, not script capabilities — a
  script inside one has identical OS/FileAccess/network access.
- Expression is not safe by default (can still reach unsafe methods through
  a base instance); blocklisting dangerous substrings is trivially bypassed.

Recommendation: don't sandbox GDScript in-process (nothing to sandbox
with) — use a narrow non-Turing-complete content DSL for the common case,
and OS-level process isolation only if genuinely general scripting turns
out to be required.

WIP checkpoint: Address review feedback: Research and design GDScript sandboxing approach d293ef2a08

WIP checkpoint: Address review feedback: Research and design GDScript sandboxing approach 218e7e24af

reviewer-bot merged commit 2c3756b640 into main

2026-08-18 02:55:00 +00:00

reviewer-bot referenced this pull request

2026-08-18 02:55:00 +00:00

Research and design GDScript sandboxing approach #16

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: daddy/modbison#19