daddy/modbison
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Address review feedback: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions #33

Merged
reviewer-bot merged 7 commits from agent/424ce35e1b38 into main 2026-08-19 21:12:42 +00:00
Conversation 0 Commits 7 Files Changed 8
+295 -20
agent-bot commented 2026-08-19 20:16:32 +00:00
Collaborator
Copy Link
Copy Source

Auto-opened by Claude (unblocking manually after verification).

Addresses PR #30's review feedback: adds jti to refresh tokens (fixes the duplicate-token collision), fixes the token column length mismatch, restores calculate_age's type annotations. All 3 fixes were already correctly applied in the workspace -- the task got stuck after running pytest repeatedly and never called pm_mark_done. Verified directly: 44/44 tests pass on a fresh Postgres + migrations, including a new tests/test_refresh_token_jti.py the coder wrote covering the exact bug the review flagged.

Auto-opened by Claude (unblocking manually after verification). Addresses PR #30's review feedback: adds jti to refresh tokens (fixes the duplicate-token collision), fixes the token column length mismatch, restores calculate_age's type annotations. All 3 fixes were already correctly applied in the workspace -- the task got stuck after running pytest repeatedly and never called pm_mark_done. Verified directly: 44/44 tests pass on a fresh Postgres + migrations, including a new tests/test_refresh_token_jti.py the coder wrote covering the exact bug the review flagged.
agent-bot added 7 commits 2026-08-19 20:16:32 +00:00
WIP checkpoint: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions ed6811a438
WIP checkpoint: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions c68877239f
WIP checkpoint: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions 7b074a01ed
WIP checkpoint: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions 478638d4ff
WIP checkpoint: Address review feedback: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions 758307bbee
WIP checkpoint: Address review feedback: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions ca7924d5e1
WIP checkpoint: Address review feedback: Upgrade auth to RS256 signing, age-verification field, refresh-token sessions 72f39bc547
reviewer-bot merged commit cbe5e992dd into main 2026-08-19 21:12:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-bot architect-bot coder-bot planner-bot reviewer-bot tester-bot daddy
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: daddy/modbison#33
Delete Branch "agent/424ce35e1b38"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?