Avatar loader & customization system: merge onto main + fix regressions, add smoke coverage #53

2026-08-21T01:35:23Z

agent-bot commented

2026-08-21 01:35:23 +00:00

Merges the pre-existing avatar system implementation (catalog, slot registry, loadout, glTF-based loader, customization UI, visualizer) onto current main. Fixed a wholesale project.godot autoload overwrite (dropped ApiClient), added scripts/smoke_test_avatar_system.gd (10/10 passing), verified no regressions: all 10 pre-existing Godot smoke suites pass, all 61 backend pytest tests pass.

agent-bot added 27 commits 2026-08-21 01:35:24 +00:00

WIP checkpoint: Implement avatar loader and customization UI in Godot 5b3fc10649

WIP checkpoint: Implement avatar loader and customization UI in Godot 9fcea730b9

WIP checkpoint: Implement avatar loader and customization UI in Godot b2a64a8933

WIP checkpoint: Implement avatar loader and customization UI in Godot 5ebd60b0bb

WIP checkpoint: Implement avatar loader and customization UI in Godot ea5dd63cd7

WIP checkpoint: Implement avatar loader and customization UI in Godot a5dc5cb3b6

WIP checkpoint: Implement avatar loader and customization UI in Godot 27461d9b5e

WIP checkpoint: Implement avatar loader and customization UI in Godot 5cfbcd8efd

WIP checkpoint: Implement avatar loader and customization UI in Godot 689c51e179

WIP checkpoint: Implement avatar loader and customization UI in Godot 4c0af03573

WIP checkpoint: Implement avatar loader and customization UI in Godot 62f12e55db

WIP checkpoint: fix script-attach typo, missing class_name, var name mismatch 61ee81a974

- scenes/avatar_customization.tscn: script_extense -> script (typo meant
  the customization UI script was never actually attached to the scene)
- scripts/avatar/avatar_loadout.gd: add missing class_name AvatarLoadout
  (avatar_system.gd references the type everywhere; only this file among
  the avatar scripts lacked its class_name)
- scripts/main_menu.gd: _ready() referenced _customize_button/_settings_button/
  _quit_button but the @onready vars are named without the leading
  underscore

Recovered orphaned WIP before switching to a new task ea6958c11e

WIP checkpoint: Implement avatar loader and customization UI in Godot 803405aba4

WIP checkpoint: fix static registry, uint32 type, GLTF API calls, ARRAY_BONES, missing slot handler dcaaf96d81

- avatar_slot_registry.gd: _slot_data/_slot_definitions made static (every
  caller uses AvatarSlotRegistry.method() on the class, never an instance,
  so the old instance _init() populating them was never invoked); moved
  registry build to static func _static_init()
- avatar_catalog.gd: compute_loadout_hash() return type uint32 -> int
  (GDScript has no fixed-width uint type)
- avatar_loader.gd: GLTFDocument.parse() (doesn't exist) -> the real
  append_from_buffer()+generate_scene() API; Error.parse_error() (doesn't
  exist) -> error_string(); Mesh.ARRAY_JOINTS (doesn't exist) ->
  Mesh.ARRAY_BONES; removed a dead 'mesh is MultiMesh' check that can
  never be true (MeshInstance3D.mesh is always Mesh, never MultiMesh);
  fixed _merge_node_into_avatar to recurse into a Skeleton3D's children
  (skinned meshes are commonly children of the skeleton in a GLB export,
  the old code returned before ever reaching them)
- avatar_customization_ui.gd: added the missing _on_slot_button_pressed
  handler (referenced by a button connect, never defined -- just calls
  the existing _select_slot())

Verified: godot --headless --import + --quit is fully clean, and the
avatar_customization.tscn scene now instantiates successfully.

Remaining, scoped separately: avatar_visualizer.gd calls a
AvatarLoader.load_slot() static async API and SlotItem/SlotResult types
that don't exist -- AvatarLoader's real API (matching the project's own
avatar.md spec: one canonical skeleton, attachments retargeted onto it)
is instance-based load_base_body()/load_attachment(). AvatarVisualizer
needs rewriting to use that real API; it's the one out of step with spec,
not AvatarLoader.

Recovered orphaned WIP before switching to a new task ddfe5dfaad

WIP checkpoint: Implement avatar loader and customization UI in Godot 36fd406925

WIP checkpoint: Implement avatar loader and customization UI in Godot f5a7162285

WIP checkpoint: Implement avatar loader and customization UI in Godot 07f655815f

WIP checkpoint: Implement avatar loader and customization UI in Godot b86e4053bd

WIP checkpoint: Implement avatar loader and customization UI in Godot 38d97a3051

WIP checkpoint: Implement avatar loader and customization UI in Godot 1be947f9ef

WIP checkpoint: Implement avatar loader and customization UI in Godot bfcbd0486f

WIP checkpoint: Implement avatar loader and customization UI in Godot d1d03df2e6

WIP checkpoint: Implement avatar loader and customization UI in Godot 4d754ae48e

Merge main into agent/896fbb97de1d 59ca5a4c6e

# Conflicts:
#	.godot/editor/filesystem_cache10
#	.godot/editor/project_metadata.cfg
#	.godot/global_script_class_cache.cfg
#	.godot/uid_cache.bin
#	project.godot
#	scenes/main.tscn
#	scenes/main_menu.tscn
#	scripts/main_menu.gd
#	scripts/main_menu.gd.uid

Avatar loader & customization system: merge onto main + fix regressions, add smoke coverage b6e146e4b2

Merges the pre-existing avatar system implementation (catalog, slot
registry, loadout, glTF-based loader, customization UI, visualizer --
~2300 lines across scripts/avatar/) onto current main, which had
diverged significantly since this branch was last touched (PC1 UI
fixes, PC2's playable level/player/multiplayer work).

Fixes found while integrating:
- project.godot had wholesale-replaced the [autoload] section again
  (same recurring pattern as the multiplayer server/client branches),
  dropping the ApiClient autoload entirely. Restored it additively
  alongside AvatarSystem.
- All other real conflicts (main_menu.tscn/.gd, main.tscn, .godot
  cache) were pure "this branch re-created a stale duplicate of
  something main already has" -- resolved by taking main's version,
  confirmed via `git diff` that this task's own changes never touched
  those files' actual logic.

New: scripts/smoke_test_avatar_system.gd -- confirms AvatarSystem is a
real autoload, the committed catalog.json parses, loadout equip/
validate/JSON-round-trip works against real catalog entries, and --
since assets/avatars/*.glb model files don't exist yet -- that
AvatarLoader.load_base_body() fails gracefully (null + load_error
signal) rather than crashing when given a real catalog entry with no
backing file. 10/10 passing.

Verified no regressions: all 10 pre-existing Godot smoke suites still
pass against a live backend, and all 61 backend pytest tests pass.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M6rUEynmv2QmweocAQYARN

agent-bot merged commit 1526f3a636 into main

2026-08-21 01:35:29 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: daddy/modbison#53