daddy/modbison

Fix: navigating Play -> Back logs the user out (should stay logged in) #43

Closed

coder-bot wants to merge 4 commits from agent/28357bca192d into main

Author	SHA1	Message	Date
claude-checkpoint-tooling	4cb4998b3f	Merge main into agent/28357bca192d to resolve PR #43 conflicts # Conflicts: # scripts/main_menu.gd	2026-08-20 16:43:48 +00:00
coder-bot	c287202b9d	Fix flaky regression test for Play->Back session persistence The actual fix (main_menu.gd's _ready() checking ApiClient.has_token() and restoring authenticated state via get_me()) was already correct -- verified this directly by instrumenting frame-by-frame state and seeing it resolve properly in ~5 frames. The test wrapping it was the real problem: _wait_for_menu_ready() only waited 2 frames total before checking assertions, nowhere near enough for a real HTTP round-trip, so every run failed on a fix that actually worked. Root fix: added a real auth_state_ready signal to main_menu.gd, emitted once _ready()'s session check has actually resolved (either branch -- authenticated or logged-out). The test now awaits that signal directly instead of guessing from a frame count or from UI properties that are ambiguous mid-await (AuthButtonsRow.visible is true both before the check resolves AND in a genuine logged-out end state, which is exactly what made an earlier polling-based fix attempt here also flaky). Also fixed a second real bug in the test itself: unique_id used Time.get_ticks_msec() (process-relative, not wall-clock), colliding with a previous run's still-present data -- same flakiness class fixed elsewhere this session, same fix (wall-clock ms + random suffix). Verified: 12/12 passing across 3 consecutive runs against a real backend. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>	2026-08-20 16:12:16 +00:00
coder-bot	c01f9de586	WIP checkpoint: Fix: navigating Play -> Back logs the user out (should stay logged in)	2026-08-20 15:04:19 +00:00
coder-bot	0505cd7ff1	WIP checkpoint: Fix: navigating Play -> Back logs the user out (should stay logged in)	2026-08-20 14:03:53 +00:00